* [PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone
@ 2020-07-25 14:37 John Oldman
2020-07-25 17:21 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: John Oldman @ 2020-07-25 14:37 UTC (permalink / raw)
To: gregkh; +Cc: devel, John Oldman, linux-kernel, gustavo
clear below issues reported by checkpatch.pl:
CHECK: Using comparison to true is error prone
Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
---
v1- First attempt: removed comparison to true.
v2- Removed unneccessary parentheses around 'pregistrypriv->ht_enable, missed in v1.
v3- Corrected the 'odd' subject line; moved the || and && to the end of the line.
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index ca98274ae390..46fad71197b6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -363,8 +363,9 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv)
}
/* HT Cap. */
- if (((pregistrypriv->wireless_mode&WIRELESS_11_5N) || (pregistrypriv->wireless_mode&WIRELESS_11_24N))
- && (pregistrypriv->ht_enable == true)) {
+ if (((pregistrypriv->wireless_mode & WIRELESS_11_5N) ||
+ (pregistrypriv->wireless_mode & WIRELESS_11_24N)) &&
+ pregistrypriv->ht_enable) {
/* todo: */
}
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone
2020-07-25 14:37 [PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone John Oldman
@ 2020-07-25 17:21 ` Greg KH
2020-07-25 17:36 ` <John Oldman>
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-07-25 17:21 UTC (permalink / raw)
To: John Oldman; +Cc: devel, linux-kernel, gustavo
On Sat, Jul 25, 2020 at 03:37:12PM +0100, John Oldman wrote:
> clear below issues reported by checkpatch.pl:
>
> CHECK: Using comparison to true is error prone
Again, you did more than just this in the patch :(
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone
2020-07-25 17:21 ` Greg KH
@ 2020-07-25 17:36 ` <John Oldman>
0 siblings, 0 replies; 3+ messages in thread
From: <John Oldman> @ 2020-07-25 17:36 UTC (permalink / raw)
To: Greg KH; +Cc: devel, linux-kernel, gustavo
On Sat, Jul 25, 2020 at 07:21:24PM +0200, Greg KH wrote:
> On Sat, Jul 25, 2020 at 03:37:12PM +0100, John Oldman wrote:
> > clear below issues reported by checkpatch.pl:
> >
> > CHECK: Using comparison to true is error prone
>
> Again, you did more than just this in the patch :(
do you mean by reducing line lengths??
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-25 17:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-25 14:37 [PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone John Oldman
2020-07-25 17:21 ` Greg KH
2020-07-25 17:36 ` <John Oldman>
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).