* [PATCH] Staging : media : atomisp : Fixed a brace coding sytle issue
@ 2020-07-28 2:15 Ankit Baluni
2020-07-29 8:05 ` [PATCH v2] Staging: media: atomisp: " Ankit Baluni
0 siblings, 1 reply; 4+ messages in thread
From: Ankit Baluni @ 2020-07-28 2:15 UTC (permalink / raw)
To: mchehab, sakari.ailus, gregkh
Cc: devel, linux-kernel, Ankit Baluni, linux-media
Fixing coding style issue by removing the braces that are not required.
Signed-off-by: Ankit Baluni<b18007@students.iitmandi.ac.in>
---
drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
index f8d616f08b51..701de098cb29 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
@@ -1828,11 +1828,10 @@ static int atomisp_streamon(struct file *file, void *fh,
dev_err(isp->dev, "master slave sensor stream on failed!\n");
goto out;
}
- if (!IS_ISP2401) {
+ if (!IS_ISP2401)
__wdt_on_master_slave_sensor(isp, wdt_duration);
- } else {
+ else
__wdt_on_master_slave_sensor_pipe(pipe, wdt_duration, true);
- }
goto start_delay_wq;
} else if (asd->depth_mode->val && (atomisp_streaming_count(isp) <
ATOMISP_DEPTH_SENSOR_STREAMON_COUNT)) {
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2] Staging: media: atomisp: Fixed a brace coding sytle issue
2020-07-28 2:15 [PATCH] Staging : media : atomisp : Fixed a brace coding sytle issue Ankit Baluni
@ 2020-07-29 8:05 ` Ankit Baluni
0 siblings, 0 replies; 4+ messages in thread
From: Ankit Baluni @ 2020-07-29 8:05 UTC (permalink / raw)
To: mchehab, gregkh, sakari.ailus; +Cc: devel, linux-kernel, b18007, linux-media
Removed braces in 'if else' condition as it only consists of
one line each and according to coding style rules , in this case
the braces are not required.
Signed-off-by: Ankit Baluni <b18007@students.iitmandi.ac.in>
---
Change in -v2:
-Removed space before ':' in subject line.
-Added space before '<' in 'From' and 'Signed-off-by' line.
-Added detailed description.
drivers/staging/media/atomisp/pci/atomisp_ioctl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
index f8d616f08b51..701de098cb29 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.c
@@ -1828,11 +1828,10 @@ static int atomisp_streamon(struct file *file, void *fh,
dev_err(isp->dev, "master slave sensor stream on failed!\n");
goto out;
}
- if (!IS_ISP2401) {
+ if (!IS_ISP2401)
__wdt_on_master_slave_sensor(isp, wdt_duration);
- } else {
+ else
__wdt_on_master_slave_sensor_pipe(pipe, wdt_duration, true);
- }
goto start_delay_wq;
} else if (asd->depth_mode->val && (atomisp_streaming_count(isp) <
ATOMISP_DEPTH_SENSOR_STREAMON_COUNT)) {
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging : media : atomisp : pci : fixed a brace coding sytle issue
@ 2020-07-27 12:16 Andy Shevchenko
2020-07-27 21:30 ` [PATCH] Staging : media : atomisp " Ankit
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2020-07-27 12:16 UTC (permalink / raw)
To: Ankit; +Cc: devel, gregkh, linux-kernel, sakari.ailus, mchehab, linux-media
On Mon, Jul 27, 2020 at 01:31:50PM +0530, Ankit wrote:
> From: Ankit Baluni<b18007@students.iitmandi.ac.in>
>
> Fixed a coding style issue.
One time is enough to be sent :-)
The Subject nevertheless can be amended, like
media: atomisp: fixed a brace coding sytle issue
--
With Best Regards,
Andy Shevchenko
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Staging : media : atomisp : fixed a brace coding sytle issue
2020-07-27 12:16 [PATCH] Staging : media : atomisp : pci : fixed " Andy Shevchenko
@ 2020-07-27 21:30 ` Ankit
2020-07-28 7:37 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Ankit @ 2020-07-27 21:30 UTC (permalink / raw)
To: mchehab, gregkh, sakari.ailus, andriy.shevchenko
Cc: devel, linux-kernel, b18007, linux-media
From: Ankit Baluni<b18007@students.iitmandi.ac.in>
Fixed a coding style issue.
Signed-off-by: Ankit Baluni<b18007@students.iitmandi.ac.in>
---
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 8ea65bef35d2..28b96b66f4f3 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -4981,9 +4981,8 @@ enum mipi_port_id __get_mipi_port(struct atomisp_device *isp,
case ATOMISP_CAMERA_PORT_SECONDARY:
return MIPI_PORT1_ID;
case ATOMISP_CAMERA_PORT_TERTIARY:
- if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID) {
+ if (MIPI_PORT1_ID + 1 != N_MIPI_PORT_ID)
return MIPI_PORT1_ID + 1;
- }
/* fall through */
default:
dev_err(isp->dev, "unsupported port: %d\n", port);
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Staging : media : atomisp : fixed a brace coding sytle issue
2020-07-27 21:30 ` [PATCH] Staging : media : atomisp " Ankit
@ 2020-07-28 7:37 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-07-28 7:37 UTC (permalink / raw)
To: Ankit
Cc: devel, mchehab, linux-kernel, sakari.ailus, andriy.shevchenko,
linux-media
On Tue, Jul 28, 2020 at 03:00:10AM +0530, Ankit wrote:
> From: Ankit Baluni<b18007@students.iitmandi.ac.in>
You need a ' ' before the '<' character.
>
> Fixed a coding style issue.
Be more descriptive of what you are doing, this is vague.
>
> Signed-off-by: Ankit Baluni<b18007@students.iitmandi.ac.in>
Same here with the ' '.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-29 8:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 2:15 [PATCH] Staging : media : atomisp : Fixed a brace coding sytle issue Ankit Baluni
2020-07-29 8:05 ` [PATCH v2] Staging: media: atomisp: " Ankit Baluni
-- strict thread matches above, loose matches on Subject: below --
2020-07-27 12:16 [PATCH] Staging : media : atomisp : pci : fixed " Andy Shevchenko
2020-07-27 21:30 ` [PATCH] Staging : media : atomisp " Ankit
2020-07-28 7:37 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).