From: kernel test robot <lkp@intel.com>
To: Coiby Xu <coiby.xu@gmail.com>, devel@driverdev.osuosl.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver
Date: Fri, 9 Oct 2020 01:45:00 +0800 [thread overview]
Message-ID: <202010090102.NOeyBbhQ-lkp@intel.com> (raw)
In-Reply-To: <20201008115808.91850-2-coiby.xu@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2601 bytes --]
Hi Coiby,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/0day-ci/linux/commits/Coiby-Xu/staging-qlge-Re-writing-the-debugging-features/20201008-200002
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 76c3bdd67d27289b9e407113821eab2a70bbcca6
config: arm64-randconfig-r025-20201008 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 8da0df3d6dcc0dd42740be60b0da4ec201190904)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/dda18d66af0554f1f2b69f9a61335f3de9ec5124
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Coiby-Xu/staging-qlge-Re-writing-the-debugging-features/20201008-200002
git checkout dda18d66af0554f1f2b69f9a61335f3de9ec5124
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/staging/qlge/qlge_devlink.c:37:9: warning: variable 'err' is uninitialized when used here [-Wuninitialized]
return err;
^~~
drivers/staging/qlge/qlge_devlink.c:19:9: note: initialize the variable 'err' to silence this warning
int err;
^
= 0
1 warning generated.
vim +/err +37 drivers/staging/qlge/qlge_devlink.c
16
17 int qlge_health_create_reporters(struct qlge_devlink *priv)
18 {
19 int err;
20
21 struct devlink_health_reporter *reporter;
22 struct devlink *devlink;
23
24 devlink = priv_to_devlink(priv);
25 reporter =
26 devlink_health_reporter_create(devlink, &qlge_reporter_ops,
27 0,
28 priv);
29 if (IS_ERR(reporter)) {
30 netdev_warn(priv->ndev,
31 "Failed to create reporter, err = %ld\n",
32 PTR_ERR(reporter));
33 return PTR_ERR(reporter);
34 }
35 priv->reporter = reporter;
36
> 37 return err;
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 47586 bytes --]
[-- Attachment #3: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-10-08 17:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 11:58 [PATCH v1 0/6] staging: qlge: Re-writing the debugging features Coiby Xu
2020-10-08 11:58 ` [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver Coiby Xu
2020-10-08 12:22 ` Willem de Bruijn
2020-10-08 12:54 ` Coiby Xu
2020-10-12 8:08 ` Coiby Xu
2020-10-08 13:31 ` Dan Carpenter
2020-10-09 0:12 ` Coiby Xu
2020-10-08 17:45 ` kernel test robot [this message]
2020-10-10 7:35 ` Benjamin Poirier
2020-10-10 10:24 ` Coiby Xu
2020-10-10 13:48 ` Benjamin Poirier
2020-10-12 11:24 ` Coiby Xu
2020-10-13 0:37 ` Benjamin Poirier
2020-10-15 3:37 ` Coiby Xu
2020-10-15 11:06 ` Benjamin Poirier
2020-10-16 23:08 ` Coiby Xu
2020-10-08 11:58 ` [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter Coiby Xu
2020-10-08 13:39 ` Dan Carpenter
2020-10-09 0:14 ` Coiby Xu
2020-10-10 7:48 ` Benjamin Poirier
2020-10-10 10:02 ` Coiby Xu
2020-10-10 13:22 ` Benjamin Poirier
2020-10-12 11:51 ` Coiby Xu
2020-10-13 1:18 ` Benjamin Poirier
2020-10-08 11:58 ` [PATCH v1 3/6] staging: qlge: support force_coredump option for devlink health dump Coiby Xu
2020-10-08 11:58 ` [PATCH v1 4/6] staging: qlge: remove mpi_core_to_log which sends coredump to the kernel ring buffer Coiby Xu
2020-10-08 11:58 ` [PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land Coiby Xu
2020-10-10 8:01 ` Benjamin Poirier
2020-10-10 10:00 ` Coiby Xu
2020-10-10 13:40 ` Benjamin Poirier
2020-10-12 11:29 ` Coiby Xu
2020-10-08 11:58 ` [PATCH v1 6/6] staging: qlge: add documentation for debugging qlge Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010090102.NOeyBbhQ-lkp@intel.com \
--to=lkp@intel.com \
--cc=coiby.xu@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).