[PATCH] staging/rtl8192u/ieee80211: fix line length exceeds 100 columns

[PATCH] staging/rtl8192u/ieee80211: fix line length exceeds 100 columns

[Elena Afanasova]

Reported by checkpatch.pl.

Signed-off-by: Elena Afanasova <eafanasova@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/dot11d.h | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h b/drivers/staging/rtl8192u/ieee80211/dot11d.h
index 8b485fa18089..e1d794d8ac69 100644
--- a/drivers/staging/rtl8192u/ieee80211/dot11d.h
+++ b/drivers/staging/rtl8192u/ieee80211/dot11d.h
@@ -17,14 +17,16 @@ enum dot11d_state {
 };
 
 struct rt_dot11d_info {
-	u16 country_ie_len; /* > 0 if country_ie_buf[] contains valid country information element. */
+	/* > 0 if country_ie_buf[] contains valid country information element. */
+	u16 country_ie_len;
 
 	/*  country_ie_src_addr u16 aligned for comparison and copy */
 	u8  country_ie_src_addr[ETH_ALEN]; /* Source AP of the country IE. */
 	u8  country_ie_buf[MAX_IE_LEN];
 	u8  country_ie_watchdog;
 
-	u8  channel_map[MAX_CHANNEL_NUMBER + 1];  /* !Value 0: Invalid, 1: Valid (active scan), 2: Valid (passive scan) */
+	/* !Value 0: Invalid, 1: Valid (active scan), 2: Valid (passive scan) */
+	u8  channel_map[MAX_CHANNEL_NUMBER + 1];
 	u8  max_tx_pwr_dbm_list[MAX_CHANNEL_NUMBER + 1];
 
 	enum dot11d_state state;
@@ -36,8 +38,10 @@ struct rt_dot11d_info {
 #define IS_DOT11D_ENABLE(ieee_dev) (GET_DOT11D_INFO(ieee_dev)->dot11d_enabled)
 #define IS_COUNTRY_IE_VALID(ieee_dev) (GET_DOT11D_INFO(ieee_dev)->country_ie_len > 0)
 
-#define IS_EQUAL_CIE_SRC(ieee_dev, addr) ether_addr_equal(GET_DOT11D_INFO(ieee_dev)->country_ie_src_addr, addr)
-#define UPDATE_CIE_SRC(ieee_dev, addr) ether_addr_copy(GET_DOT11D_INFO(ieee_dev)->country_ie_src_addr, addr)
+#define IS_EQUAL_CIE_SRC(ieee_dev, addr) \
+	ether_addr_equal(GET_DOT11D_INFO(ieee_dev)->country_ie_src_addr, addr)
+#define UPDATE_CIE_SRC(ieee_dev, addr) \
+	ether_addr_copy(GET_DOT11D_INFO(ieee_dev)->country_ie_src_addr, addr)
 
 #define GET_CIE_WATCHDOG(ieee_dev) (GET_DOT11D_INFO(ieee_dev)->country_ie_watchdog)
 #define RESET_CIE_WATCHDOG(ieee_dev) (GET_CIE_WATCHDOG(ieee_dev) = 0)
-- 
2.25.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging/rtl8192u/ieee80211: fix line length exceeds 100 columns

[Dan Carpenter]

On Tue, Oct 20, 2020 at 08:11:11AM -0700, Elena Afanasova wrote:
> Reported by checkpatch.pl.

The commit message should be considered like an separate thing from the
subject.  On my email client, I normally read either just the subject or
just the commit message.  It looks something like this:

https://lore.kernel.org/driverdev-devel/20201020151748.35937-1-eafanasova@gmail.com/T/#t

Do you see the subject?  It's far away from the commit message.

Here is how I would write this commit message:

Subject: [PATCH] Staging: rtl8192u: split up long lines

Checkpatch complains that these lines are over 100 characters so let's
split them up.

Some people care about verb tenses or whatever but most maintainers
don't.  I don't.  I only care about if I can basically see what you
are changing and why.  This patch doesn't affect runtime, but if it
did, then I would like some comments about what the bug looks like to
the user.  Basically if I can understand the commit message then it's
fine, and obviously "Reported by checkpatch.pl" is not sufficient to
understand what's going on.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel