* [PATCH] Fixed issues with alignment to open parenthesis.
@ 2020-10-12 1:08 Tabot Kevin
2020-11-09 15:07 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Tabot Kevin @ 2020-10-12 1:08 UTC (permalink / raw)
To: Vaibhav Agarwal; +Cc: devel
This patch fixes the following:
- Made sure alignment matched open parenthesis.
Signed-off-by: Tabot Kevin <tabot.kevin@gmail.com>
---
drivers/staging/greybus/audio_module.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/audio_module.c b/drivers/staging/greybus/audio_module.c
index c52c4f3..a243d60 100644
--- a/drivers/staging/greybus/audio_module.c
+++ b/drivers/staging/greybus/audio_module.c
@@ -175,8 +175,8 @@ static int gbaudio_codec_request_handler(struct gb_operation *op)
}
static int gb_audio_add_mgmt_connection(struct gbaudio_module_info *gbmodule,
- struct greybus_descriptor_cport *cport_desc,
- struct gb_bundle *bundle)
+ struct greybus_descriptor_cport *cport_desc,
+ struct gb_bundle *bundle)
{
struct gb_connection *connection;
@@ -199,8 +199,8 @@ static int gb_audio_add_mgmt_connection(struct gbaudio_module_info *gbmodule,
}
static int gb_audio_add_data_connection(struct gbaudio_module_info *gbmodule,
- struct greybus_descriptor_cport *cport_desc,
- struct gb_bundle *bundle)
+ struct greybus_descriptor_cport *cport_desc,
+ struct gb_bundle *bundle)
{
struct gb_connection *connection;
struct gbaudio_data_connection *dai;
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Fixed issues with alignment to open parenthesis.
2020-10-12 1:08 [PATCH] Fixed issues with alignment to open parenthesis Tabot Kevin
@ 2020-11-09 15:07 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-11-09 15:07 UTC (permalink / raw)
To: Tabot Kevin; +Cc: devel, Vaibhav Agarwal
On Mon, Oct 12, 2020 at 02:08:38AM +0100, Tabot Kevin wrote:
> This patch fixes the following:
> - Made sure alignment matched open parenthesis.
>
> Signed-off-by: Tabot Kevin <tabot.kevin@gmail.com>
> ---
> drivers/staging/greybus/audio_module.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_module.c b/drivers/staging/greybus/audio_module.c
> index c52c4f3..a243d60 100644
> --- a/drivers/staging/greybus/audio_module.c
> +++ b/drivers/staging/greybus/audio_module.c
Please use scripts/get_maintainer.pl to know who to cc: on a patch.
And look at other changes for this file, and copy the subject prefix for
them:
$ git log --oneline drivers/staging/greybus/audio_module.c | head
50a390ad1512 staging: greybus: fix warnings about endianness detected by sparse
ac40b4d1e409 staging: greybus: audio: Maintain jack list within GB Audio module
8478c35a858c staging: greybus: Parenthesis alignment
863dbc52e7f0 staging: greybus: Remove redundant license text
eb50fd3a22c7 staging: greybus: add SPDX identifiers to all greybus driver files
055fb9ce92d5 staging: greybus: audio: Ensure proper byte order
3282998c8010 staging: greybus: audio_module: remove redundant OOM message
49b9137a6002 staging: greybus: audio: remove redundant slot field
d0af1bd5f6f4 staging: greybus: audio: Rename cport with intf_id
948c6227e76e staging: greybus: remove CONFIG_PM_RUNTIME from kernel_ver.h
Can you fix that up and resend?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Fixed issues with alignment to open parenthesis.
@ 2020-10-19 15:24 Tabot Kevin
2020-10-27 11:26 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Tabot Kevin @ 2020-10-19 15:24 UTC (permalink / raw)
To: Vaibhav Agarwal; +Cc: devel
This patch fixes the following:
- Made sure alignment matched open parenthesis.
Signed-off-by: Tabot Kevin <tabot.kevin@gmail.com>
---
drivers/staging/greybus/audio_codec.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
index 494aa82..d61e79f 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -71,7 +71,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec,
i2s_port = 0; /* fixed for now */
cportid = data->connection->hd_cport_id;
ret = gb_audio_apbridgea_register_cport(data->connection,
- i2s_port, cportid,
+ i2s_port, cportid,
AUDIO_APBRIDGEA_DIRECTION_TX);
if (ret) {
dev_err_ratelimited(module->dev,
@@ -161,7 +161,7 @@ static int gbaudio_module_disable_tx(struct gbaudio_module_info *module, int id)
i2s_port = 0; /* fixed for now */
cportid = data->connection->hd_cport_id;
ret = gb_audio_apbridgea_unregister_cport(data->connection,
- i2s_port, cportid,
+ i2s_port, cportid,
AUDIO_APBRIDGEA_DIRECTION_TX);
if (ret) {
dev_err_ratelimited(module->dev,
@@ -206,7 +206,7 @@ static int gbaudio_module_enable_rx(struct gbaudio_codec_info *codec,
i2s_port = 0; /* fixed for now */
cportid = data->connection->hd_cport_id;
ret = gb_audio_apbridgea_register_cport(data->connection,
- i2s_port, cportid,
+ i2s_port, cportid,
AUDIO_APBRIDGEA_DIRECTION_RX);
if (ret) {
dev_err_ratelimited(module->dev,
@@ -296,7 +296,7 @@ static int gbaudio_module_disable_rx(struct gbaudio_module_info *module, int id)
i2s_port = 0; /* fixed for now */
cportid = data->connection->hd_cport_id;
ret = gb_audio_apbridgea_unregister_cport(data->connection,
- i2s_port, cportid,
+ i2s_port, cportid,
AUDIO_APBRIDGEA_DIRECTION_RX);
if (ret) {
dev_err_ratelimited(module->dev,
@@ -1057,7 +1057,6 @@ static int gbcodec_probe(struct snd_soc_component *comp)
static void gbcodec_remove(struct snd_soc_component *comp)
{
/* Empty function for now */
- return;
}
static int gbcodec_write(struct snd_soc_component *comp, unsigned int reg,
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Fixed issues with alignment to open parenthesis.
2020-10-19 15:24 Tabot Kevin
@ 2020-10-27 11:26 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-10-27 11:26 UTC (permalink / raw)
To: Tabot Kevin; +Cc: devel, Vaibhav Agarwal
On Mon, Oct 19, 2020 at 04:24:51PM +0100, Tabot Kevin wrote:
> This patch fixes the following:
> - Made sure alignment matched open parenthesis.
>
> Signed-off-by: Tabot Kevin <tabot.kevin@gmail.com>
> ---
> drivers/staging/greybus/audio_codec.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index 494aa82..d61e79f 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -71,7 +71,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec,
> i2s_port = 0; /* fixed for now */
> cportid = data->connection->hd_cport_id;
> ret = gb_audio_apbridgea_register_cport(data->connection,
> - i2s_port, cportid,
> + i2s_port, cportid,
> AUDIO_APBRIDGEA_DIRECTION_TX);
This just looks weird now. Please, just leave it as-is.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-09 15:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12 1:08 [PATCH] Fixed issues with alignment to open parenthesis Tabot Kevin
2020-11-09 15:07 ` Greg KH
2020-10-19 15:24 Tabot Kevin
2020-10-27 11:26 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).