* [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT @ 2020-12-14 11:03 Philipp Gerlesberger 2020-12-14 11:03 ` [PATCH v2 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE Philipp Gerlesberger ` (3 more replies) 0 siblings, 4 replies; 10+ messages in thread From: Philipp Gerlesberger @ 2020-12-14 11:03 UTC (permalink / raw) To: linux-kernel Cc: devel, linux-kernel, gregkh, ij72uhux, Philipp Gerlesberger, sakari.ailus, mchehab, linux-media You can sum up the two lines, because the maximum line length of 100 columns is not exceeded. Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de> --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c index 753a99703f1e..38f86764ccfc 100644 --- a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c +++ b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c @@ -37,8 +37,7 @@ static struct spctrl_context_info spctrl_cofig_info[N_SP_ID]; static bool spctrl_loaded[N_SP_ID] = {0}; /* Load firmware */ -int ia_css_spctrl_load_fw(sp_ID_t sp_id, - ia_css_spctrl_cfg *spctrl_cfg) +int ia_css_spctrl_load_fw(sp_ID_t sp_id, ia_css_spctrl_cfg *spctrl_cfg) { ia_css_ptr code_addr = mmgr_NULL; struct ia_css_sp_init_dmem_cfg *init_dmem_cfg; -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE 2020-12-14 11:03 [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT Philipp Gerlesberger @ 2020-12-14 11:03 ` Philipp Gerlesberger 2020-12-14 11:03 ` [PATCH v2 11/12] media: atomisp: Write function decleration in one line Philipp Gerlesberger ` (2 subsequent siblings) 3 siblings, 0 replies; 10+ messages in thread From: Philipp Gerlesberger @ 2020-12-14 11:03 UTC (permalink / raw) To: linux-kernel Cc: devel, linux-kernel, gregkh, ij72uhux, Philipp Gerlesberger, sakari.ailus, mchehab, linux-media Block comments should align the * on each line Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de> --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c index 38f86764ccfc..7f4592565af6 100644 --- a/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c +++ b/drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c @@ -105,8 +105,8 @@ int ia_css_spctrl_load_fw(sp_ID_t sp_id, ia_css_spctrl_cfg *spctrl_cfg) void sh_css_spctrl_reload_fw(sp_ID_t sp_id) { /* now we program the base address into the icache and - * invalidate the cache. - */ + * invalidate the cache. + */ sp_ctrl_store(sp_id, SP_ICACHE_ADDR_REG, (hrt_data)spctrl_cofig_info[sp_id].code_addr); sp_ctrl_setbit(sp_id, SP_ICACHE_INV_REG, SP_ICACHE_INV_BIT); -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 11/12] media: atomisp: Write function decleration in one line 2020-12-14 11:03 [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT Philipp Gerlesberger 2020-12-14 11:03 ` [PATCH v2 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE Philipp Gerlesberger @ 2020-12-14 11:03 ` Philipp Gerlesberger 2020-12-14 11:03 ` [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Philipp Gerlesberger 2020-12-14 11:49 ` [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT David Laight 3 siblings, 0 replies; 10+ messages in thread From: Philipp Gerlesberger @ 2020-12-14 11:03 UTC (permalink / raw) To: linux-kernel Cc: devel, linux-kernel, gregkh, ij72uhux, Philipp Gerlesberger, sakari.ailus, mchehab, linux-media CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' WARNING:LEADING_SPACE: please, no spaces at the start of a line Avoid these errors by writing the function decleration in one line. Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de> --- .../atomisp/pci/runtime/queue/src/queue.c | 44 +++++-------------- 1 file changed, 11 insertions(+), 33 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c index aea6c66a3cee..2f1c2df59f71 100644 --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c @@ -22,9 +22,7 @@ /***************************************************************************** * Queue Public APIs *****************************************************************************/ -int ia_css_queue_local_init( - ia_css_queue_t *qhandle, - ia_css_queue_local_t *desc) +int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc) { if (NULL == qhandle || NULL == desc || NULL == desc->cb_elems || NULL == desc->cb_desc) { @@ -43,9 +41,7 @@ int ia_css_queue_local_init( return 0; } -int ia_css_queue_remote_init( - ia_css_queue_t *qhandle, - ia_css_queue_remote_t *desc) +int ia_css_queue_remote_init(ia_css_queue_t *qhandle, ia_css_queue_remote_t *desc) { if (NULL == qhandle || NULL == desc) { /* Invalid parameters, return error*/ @@ -69,8 +65,7 @@ int ia_css_queue_remote_init( return 0; } -int ia_css_queue_uninit( - ia_css_queue_t *qhandle) +int ia_css_queue_uninit(ia_css_queue_t *qhandle) { if (!qhandle) return -EINVAL; @@ -84,9 +79,7 @@ int ia_css_queue_uninit( return 0; } -int ia_css_queue_enqueue( - ia_css_queue_t *qhandle, - uint32_t item) +int ia_css_queue_enqueue(ia_css_queue_t *qhandle, uint32_t item) { int error = 0; @@ -143,9 +136,7 @@ int ia_css_queue_enqueue( return 0; } -int ia_css_queue_dequeue( - ia_css_queue_t *qhandle, - uint32_t *item) +int ia_css_queue_dequeue(ia_css_queue_t *qhandle, uint32_t *item) { int error = 0; @@ -200,9 +191,7 @@ int ia_css_queue_dequeue( return 0; } -int ia_css_queue_is_full( - ia_css_queue_t *qhandle, - bool *is_full) +int ia_css_queue_is_full(ia_css_queue_t *qhandle, bool *is_full) { int error = 0; @@ -234,9 +223,7 @@ int ia_css_queue_is_full( return -EINVAL; } -int ia_css_queue_get_free_space( - ia_css_queue_t *qhandle, - uint32_t *size) +int ia_css_queue_get_free_space(ia_css_queue_t *qhandle, uint32_t *size) { int error = 0; @@ -268,9 +255,7 @@ int ia_css_queue_get_free_space( return -EINVAL; } -int ia_css_queue_get_used_space( - ia_css_queue_t *qhandle, - uint32_t *size) +int ia_css_queue_get_used_space(ia_css_queue_t *qhandle, uint32_t *size) { int error = 0; @@ -302,10 +287,7 @@ int ia_css_queue_get_used_space( return -EINVAL; } -int ia_css_queue_peek( - ia_css_queue_t *qhandle, - u32 offset, - uint32_t *element) +int ia_css_queue_peek(ia_css_queue_t *qhandle, u32 offset, uint32_t *element) { u32 num_elems = 0; int error = 0; @@ -354,9 +336,7 @@ int ia_css_queue_peek( return -EINVAL; } -int ia_css_queue_is_empty( - ia_css_queue_t *qhandle, - bool *is_empty) +int ia_css_queue_is_empty(ia_css_queue_t *qhandle, bool *is_empty) { int error = 0; @@ -388,9 +368,7 @@ int ia_css_queue_is_empty( return -EINVAL; } -int ia_css_queue_get_size( - ia_css_queue_t *qhandle, - uint32_t *size) +int ia_css_queue_get_size(ia_css_queue_t *qhandle, uint32_t *size) { int error = 0; -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS 2020-12-14 11:03 [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT Philipp Gerlesberger 2020-12-14 11:03 ` [PATCH v2 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE Philipp Gerlesberger 2020-12-14 11:03 ` [PATCH v2 11/12] media: atomisp: Write function decleration in one line Philipp Gerlesberger @ 2020-12-14 11:03 ` Philipp Gerlesberger 2020-12-14 11:49 ` [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT David Laight 3 siblings, 0 replies; 10+ messages in thread From: Philipp Gerlesberger @ 2020-12-14 11:03 UTC (permalink / raw) To: linux-kernel Cc: devel, linux-kernel, gregkh, ij72uhux, Philipp Gerlesberger, sakari.ailus, mchehab, linux-media Logical continuations should be on the previous line Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de> --- drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c index 2f1c2df59f71..7d44070c7114 100644 --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c @@ -24,8 +24,8 @@ *****************************************************************************/ int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc) { - if (NULL == qhandle || NULL == desc - || NULL == desc->cb_elems || NULL == desc->cb_desc) { + if (NULL == qhandle || NULL == desc || + NULL == desc->cb_elems || NULL == desc->cb_desc) { /* Invalid parameters, return error*/ return -EINVAL; } -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT 2020-12-14 11:03 [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT Philipp Gerlesberger ` (2 preceding siblings ...) 2020-12-14 11:03 ` [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Philipp Gerlesberger @ 2020-12-14 11:49 ` David Laight 2020-12-14 13:56 ` gregkh 3 siblings, 1 reply; 10+ messages in thread From: David Laight @ 2020-12-14 11:49 UTC (permalink / raw) To: 'Philipp Gerlesberger', linux-kernel Cc: devel, linux-kernel, gregkh, ij72uhux, sakari.ailus, mchehab, linux-media From: Philipp Gerlesberger > Sent: 14 December 2020 11:04 > > You can sum up the two lines, because the maximum line length of > 100 columns is not exceeded. IIRC the 80 column limit is preferred. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT 2020-12-14 11:49 ` [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT David Laight @ 2020-12-14 13:56 ` gregkh 0 siblings, 0 replies; 10+ messages in thread From: gregkh @ 2020-12-14 13:56 UTC (permalink / raw) To: David Laight Cc: devel, linux-kernel, linux-kernel, ij72uhux, 'Philipp Gerlesberger', sakari.ailus, mchehab, linux-media On Mon, Dec 14, 2020 at 11:49:56AM +0000, David Laight wrote: > From: Philipp Gerlesberger > > Sent: 14 December 2020 11:04 > > > > You can sum up the two lines, because the maximum line length of > > 100 columns is not exceeded. > > IIRC the 80 column limit is preferred. Not anymore, checkpatch has changed. _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 00/12] media: atomisp: Codingstyle @ 2020-12-14 11:01 Philipp Gerlesberger 2020-12-14 11:01 ` [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Philipp Gerlesberger 0 siblings, 1 reply; 10+ messages in thread From: Philipp Gerlesberger @ 2020-12-14 11:01 UTC (permalink / raw) To: linux-kernel Cc: devel, linux-kernel, gregkh, ij72uhux, Philipp Gerlesberger, sakari.ailus, mchehab, linux-media Hello! This series fix some codingstyle errors in the files rmgr_vbuf.c, ia_css_rmgr.h, timer.c, spctrl.c and queue.c in the drivers/staging/media area. V2: [Patch 1/12] Also remove NULL, 0 and false members to make it C99 standard comform. [Patch 6/12] Checkpatch throws COMPLEX_MACRO Error. Handle that error by deleting these defines. The other patches are the same. Best regards Philipp ---------------------------------------------------------------------- media: atomisp: Convert comments to C99 initializers media: atomisp: Fix Block Comments media: atomisp: Fix EMBEDDED_FUNCTION_NAME warning media: atomisp: Fix OPEN_ENDED_LINE media: atomisp: Fix overlong line media: atomisp: Remove defines media: atomisp: Fix funciton decleration media: atomisp: Delete braces media: atomisp: Fix PARENTHESIS_ALIGNMENT media: atomisp: Fix BLOCK_COMMENT_STYLE media: atomisp: Write function decleration in one line media: atomisp: Fix LOGICAL_CONTINUATIONS .../atomisp/pci/runtime/queue/src/queue.c | 48 +++++-------------- .../pci/runtime/rmgr/interface/ia_css_rmgr.h | 5 +- .../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 41 ++++++---------- .../atomisp/pci/runtime/spctrl/src/spctrl.c | 7 ++- .../atomisp/pci/runtime/timer/src/timer.c | 7 +-- 5 files changed, 33 insertions(+), 75 deletions(-) -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS 2020-12-14 11:01 [PATCH v2 00/12] media: atomisp: Codingstyle Philipp Gerlesberger @ 2020-12-14 11:01 ` Philipp Gerlesberger 2020-12-14 11:53 ` David Laight 2021-03-23 13:16 ` Mauro Carvalho Chehab 0 siblings, 2 replies; 10+ messages in thread From: Philipp Gerlesberger @ 2020-12-14 11:01 UTC (permalink / raw) To: linux-kernel Cc: devel, linux-kernel, gregkh, ij72uhux, Philipp Gerlesberger, sakari.ailus, mchehab, linux-media Logical continuations should be on the previous line Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de> --- drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c index 2f1c2df59f71..7d44070c7114 100644 --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c @@ -24,8 +24,8 @@ *****************************************************************************/ int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc) { - if (NULL == qhandle || NULL == desc - || NULL == desc->cb_elems || NULL == desc->cb_desc) { + if (NULL == qhandle || NULL == desc || + NULL == desc->cb_elems || NULL == desc->cb_desc) { /* Invalid parameters, return error*/ return -EINVAL; } -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS 2020-12-14 11:01 ` [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Philipp Gerlesberger @ 2020-12-14 11:53 ` David Laight 2020-12-14 14:16 ` Dan Carpenter 2021-03-23 13:16 ` Mauro Carvalho Chehab 1 sibling, 1 reply; 10+ messages in thread From: David Laight @ 2020-12-14 11:53 UTC (permalink / raw) To: 'Philipp Gerlesberger', linux-kernel Cc: devel, linux-kernel, gregkh, ij72uhux, sakari.ailus, mchehab, linux-media From: Philipp Gerlesberger > Sent: 14 December 2020 11:02 > > Logical continuations should be on the previous line > > Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> > Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> > Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de> > --- > drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > index 2f1c2df59f71..7d44070c7114 100644 > --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > @@ -24,8 +24,8 @@ > *****************************************************************************/ > int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc) > { > - if (NULL == qhandle || NULL == desc > - || NULL == desc->cb_elems || NULL == desc->cb_desc) { > + if (NULL == qhandle || NULL == desc || > + NULL == desc->cb_elems || NULL == desc->cb_desc) { > /* Invalid parameters, return error*/ > return -EINVAL; Get rid of the obnoxious backwards tests and it probably fits in 80 columns. if (!qhandle || !desc || !desc->cb_elems || !desc->desc) { ... OTOH if it isn't expected that any of these might be NULL just delete the test. If they ever are 'accidentally' NULL it is usually easier to debug the NULL pointer dereference than an obscure error return. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS 2020-12-14 11:53 ` David Laight @ 2020-12-14 14:16 ` Dan Carpenter 0 siblings, 0 replies; 10+ messages in thread From: Dan Carpenter @ 2020-12-14 14:16 UTC (permalink / raw) To: David Laight Cc: devel, linux-kernel, gregkh, linux-kernel, ij72uhux, 'Philipp Gerlesberger', sakari.ailus, mchehab, linux-media On Mon, Dec 14, 2020 at 11:53:04AM +0000, David Laight wrote: > From: Philipp Gerlesberger > > Sent: 14 December 2020 11:02 > > > > Logical continuations should be on the previous line > > > > Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> > > Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> > > Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de> > > --- > > drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > > b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > > index 2f1c2df59f71..7d44070c7114 100644 > > --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > > +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > > @@ -24,8 +24,8 @@ > > *****************************************************************************/ > > int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc) > > { > > - if (NULL == qhandle || NULL == desc > > - || NULL == desc->cb_elems || NULL == desc->cb_desc) { > > + if (NULL == qhandle || NULL == desc || > > + NULL == desc->cb_elems || NULL == desc->cb_desc) { > > /* Invalid parameters, return error*/ Delete this comment as well. It's pointless. (And the curly braces). > > return -EINVAL; > regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS 2020-12-14 11:01 ` [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Philipp Gerlesberger 2020-12-14 11:53 ` David Laight @ 2021-03-23 13:16 ` Mauro Carvalho Chehab 1 sibling, 0 replies; 10+ messages in thread From: Mauro Carvalho Chehab @ 2021-03-23 13:16 UTC (permalink / raw) To: Philipp Gerlesberger Cc: devel, linux-kernel, gregkh, linux-kernel, ij72uhux, sakari.ailus, linux-media Em Mon, 14 Dec 2020 12:01:56 +0100 Philipp Gerlesberger <Philipp.Gerlesberger@fau.de> escreveu: > Logical continuations should be on the previous line > > Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> > Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de> > Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de> > --- > drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > index 2f1c2df59f71..7d44070c7114 100644 > --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > @@ -24,8 +24,8 @@ > *****************************************************************************/ > int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc) > { > - if (NULL == qhandle || NULL == desc > - || NULL == desc->cb_elems || NULL == desc->cb_desc) { > + if (NULL == qhandle || NULL == desc || > + NULL == desc->cb_elems || NULL == desc->cb_desc) { Nah, there are coding style issues here... we usually do: if (foo == CONSTANT) instead of: if (CONSTANT == foo) Also, we usually simplify checks for null. So, the above should be, instead, just: if (!qhandle || !desc || !desc->cb_elements || !desc->cb_desc) > /* Invalid parameters, return error*/ > return -EINVAL; > } Thanks, Mauro _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-03-23 13:16 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-12-14 11:03 [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT Philipp Gerlesberger 2020-12-14 11:03 ` [PATCH v2 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE Philipp Gerlesberger 2020-12-14 11:03 ` [PATCH v2 11/12] media: atomisp: Write function decleration in one line Philipp Gerlesberger 2020-12-14 11:03 ` [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Philipp Gerlesberger 2020-12-14 11:49 ` [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT David Laight 2020-12-14 13:56 ` gregkh -- strict thread matches above, loose matches on Subject: below -- 2020-12-14 11:01 [PATCH v2 00/12] media: atomisp: Codingstyle Philipp Gerlesberger 2020-12-14 11:01 ` [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Philipp Gerlesberger 2020-12-14 11:53 ` David Laight 2020-12-14 14:16 ` Dan Carpenter 2021-03-23 13:16 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).