* [PATCH] fix comparisons - put constant on right side- eudyptula challenge 10 [not found] <20210218155422.7-1-fuzzybritches@protonmail.com> @ 2021-02-18 15:54 ` Kurt Manucredo 2021-02-18 16:04 ` Dan Carpenter 2021-02-18 16:01 ` [PATCH] fix comparisons - put constant on right side- eudyptula Dan Carpenter 1 sibling, 1 reply; 3+ messages in thread From: Kurt Manucredo @ 2021-02-18 15:54 UTC (permalink / raw) To: gregkh, devel, linux-kernel; +Cc: Kurt Manucredo Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com> --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index 975f2830e29e..089c6ec19373 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr) struct security_priv *psecpriv = &padapter->securitypriv; memset(pcur_dot11txpn, 0, 8); - if (NULL == StaAddr) + if (StaAddr == NULL) return; psta = rtw_get_stainfo(&padapter->stapriv, StaAddr); DBG_871X("%s(): StaAddr: %02x %02x %02x %02x %02x %02x\n", -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fix comparisons - put constant on right side- eudyptula challenge 10 2021-02-18 15:54 ` [PATCH] fix comparisons - put constant on right side- eudyptula challenge 10 Kurt Manucredo @ 2021-02-18 16:04 ` Dan Carpenter 0 siblings, 0 replies; 3+ messages in thread From: Dan Carpenter @ 2021-02-18 16:04 UTC (permalink / raw) To: Kurt Manucredo; +Cc: devel, gregkh, linux-kernel Fix the subject. Don't mention eudyptula. [PATCH] Staging: rtl8723bs: put constant on right side of comparison Add a commit message: Checkpatch complains that the constant needs to be on the right hand side of the comparion. On Thu, Feb 18, 2021 at 03:54:40PM +0000, Kurt Manucredo wrote: > Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com> > --- > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > index 975f2830e29e..089c6ec19373 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > @@ -2146,7 +2146,7 @@ void rtw_get_sec_iv(struct adapter *padapter, u8 *pcur_dot11txpn, u8 *StaAddr) > struct security_priv *psecpriv = &padapter->securitypriv; > > memset(pcur_dot11txpn, 0, 8); > - if (NULL == StaAddr) > + if (StaAddr == NULL) The prefered format for this is actually: if (!StaAddr) return; regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix comparisons - put constant on right side- eudyptula [not found] <20210218155422.7-1-fuzzybritches@protonmail.com> 2021-02-18 15:54 ` [PATCH] fix comparisons - put constant on right side- eudyptula challenge 10 Kurt Manucredo @ 2021-02-18 16:01 ` Dan Carpenter 1 sibling, 0 replies; 3+ messages in thread From: Dan Carpenter @ 2021-02-18 16:01 UTC (permalink / raw) To: Kurt Manucredo; +Cc: devel, gregkh, linux-kernel On Thu, Feb 18, 2021 at 03:54:29PM +0000, Kurt Manucredo wrote: > > Dear linux kernel developers, > > for my eudyptula challenge it is required of me to fix a coding style > issue in the staging area in linux-next. I am aware that it is in > general frowned upon when submitting these sorts of patches. However, to > finish my 10th challenge I was tasked to do exactly that. So I ask you > kindly to pull this patch if possible. > > Thank you for your time, These patches are fine in staging. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-18 16:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210218155422.7-1-fuzzybritches@protonmail.com>
2021-02-18 15:54 ` [PATCH] fix comparisons - put constant on right side- eudyptula challenge 10 Kurt Manucredo
2021-02-18 16:04 ` Dan Carpenter
2021-02-18 16:01 ` [PATCH] fix comparisons - put constant on right side- eudyptula Dan Carpenter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).