* [PATCH v3 1/3] staging: rtl8192u: fixed coding style of r8190_rtl8256.c
@ 2021-02-19 11:07 Du Cheng
2021-02-19 11:07 ` [PATCH v3 2/3] " Du Cheng
2021-02-19 11:07 ` [PATCH v3 3/3] " Du Cheng
0 siblings, 2 replies; 4+ messages in thread
From: Du Cheng @ 2021-02-19 11:07 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, Du Cheng
use MACRO __func__ instead of "phy_set_rf8256_bandwidth" for RT_TRACE()
inside phy_set_rf8256_bandwidth(), reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng <ducheng2@gmail.com>
---
changes v3:
* break up changes into 3 patches
changes v2:
* improve description
changes v1:
* fix coding style
drivers/staging/rtl8192u/r8190_rtl8256.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c
index fee3bfb99075..7294a3fbe205 100644
--- a/drivers/staging/rtl8192u/r8190_rtl8256.c
+++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
@@ -73,11 +73,11 @@ void phy_set_rf8256_bandwidth(struct net_device *dev, enum ht_channel_width Band
else
rtl8192_phy_SetRFReg(dev, (enum rf90_radio_path_e)eRFPath, 0x14, bMask12Bits, 0x5ab);
} else {
- RT_TRACE(COMP_ERR, "phy_set_rf8256_bandwidth(): unknown hardware version\n");
+ RT_TRACE(COMP_ERR, "%s(): unknown hardware version\n", __func__);
}
break;
default:
- RT_TRACE(COMP_ERR, "phy_set_rf8256_bandwidth(): unknown Bandwidth: %#X\n", Bandwidth);
+ RT_TRACE(COMP_ERR, "%s(): unknown Bandwidth: %#X\n", __func__, Bandwidth);
break;
}
}
--
2.27.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 2/3] staging: rtl8192u: fixed coding style of r8190_rtl8256.c
2021-02-19 11:07 [PATCH v3 1/3] staging: rtl8192u: fixed coding style of r8190_rtl8256.c Du Cheng
@ 2021-02-19 11:07 ` Du Cheng
2021-02-19 11:17 ` Greg Kroah-Hartman
2021-02-19 11:07 ` [PATCH v3 3/3] " Du Cheng
1 sibling, 1 reply; 4+ messages in thread
From: Du Cheng @ 2021-02-19 11:07 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, Du Cheng
use MACRO __func__ instead of "phy_rf8256_config_para_file" for RT_TRACE()
inside phy_rf8256_config_para_file(), reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng <ducheng2@gmail.com>
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c
index 7294a3fbe205..3e6bd6caf9da 100644
--- a/drivers/staging/rtl8192u/r8190_rtl8256.c
+++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
@@ -213,7 +213,7 @@ static void phy_rf8256_config_para_file(struct net_device *dev)
}
if (ret) {
- RT_TRACE(COMP_ERR, "phy_rf8256_config_para_file():Radio[%d] Fail!!", eRFPath);
+ RT_TRACE(COMP_ERR, "%s():Radio[%d] Fail!!", __func__, eRFPath);
goto phy_RF8256_Config_ParaFile_Fail;
}
}
--
2.27.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 3/3] staging: rtl8192u: fixed coding style of r8190_rtl8256.c
2021-02-19 11:07 [PATCH v3 1/3] staging: rtl8192u: fixed coding style of r8190_rtl8256.c Du Cheng
2021-02-19 11:07 ` [PATCH v3 2/3] " Du Cheng
@ 2021-02-19 11:07 ` Du Cheng
1 sibling, 0 replies; 4+ messages in thread
From: Du Cheng @ 2021-02-19 11:07 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, Du Cheng
remove the unnecessary return at the end of function
phy_set_rf8256_ofdm_tx_power(), reported by scripts/checkpatch.pl.
Signed-off-by: Du Cheng <ducheng2@gmail.com>
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c
index 3e6bd6caf9da..54747fda552f 100644
--- a/drivers/staging/rtl8192u/r8190_rtl8256.c
+++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
@@ -291,5 +291,4 @@ void phy_set_rf8256_ofdm_tx_power(struct net_device *dev, u8 powerlevel)
}
rtl8192_setBBreg(dev, RegOffset[index], 0x7f7f7f7f, writeVal);
}
- return;
}
--
2.27.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 2/3] staging: rtl8192u: fixed coding style of r8190_rtl8256.c
2021-02-19 11:07 ` [PATCH v3 2/3] " Du Cheng
@ 2021-02-19 11:17 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-02-19 11:17 UTC (permalink / raw)
To: Du Cheng; +Cc: devel
On Fri, Feb 19, 2021 at 07:07:54PM +0800, Du Cheng wrote:
> use MACRO __func__ instead of "phy_rf8256_config_para_file" for RT_TRACE()
> inside phy_rf8256_config_para_file(), reported by scripts/checkpatch.pl.
>
> Signed-off-by: Du Cheng <ducheng2@gmail.com>
> ---
> drivers/staging/rtl8192u/r8190_rtl8256.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Why isn't this part of patch 1/3? It does the same thing, right?
Please fix up and resend the series.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-19 11:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 11:07 [PATCH v3 1/3] staging: rtl8192u: fixed coding style of r8190_rtl8256.c Du Cheng
2021-02-19 11:07 ` [PATCH v3 2/3] " Du Cheng
2021-02-19 11:17 ` Greg Kroah-Hartman
2021-02-19 11:07 ` [PATCH v3 3/3] " Du Cheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).