* [PATCH] drivers: staging: qlge: Fixed an alignment issue.
@ 2021-03-16 15:56 Anish Udupa
2021-03-17 8:25 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Anish Udupa @ 2021-03-16 15:56 UTC (permalink / raw)
To: manishc, GR-Linux-NIC-Dev, gregkh, netdev, devel, linux-kernel
The * of the comment was not aligned properly. Ran checkpatch and
found the warning. Resolved it in this patch.
Signed-off-by: Anish Udupa <udupa.anish@gmail.com>
---
drivers/staging/qlge/qlge_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 5516be3af898..bfd7217f3953 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -3816,7 +3816,7 @@ static int qlge_adapter_down(struct qlge_adapter *qdev)
qlge_tx_ring_clean(qdev);
/* Call netif_napi_del() from common point.
- */
+ */
for (i = 0; i < qdev->rss_ring_count; i++)
netif_napi_del(&qdev->rx_ring[i].napi);
--
2.17.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: staging: qlge: Fixed an alignment issue.
2021-03-16 15:56 [PATCH] drivers: staging: qlge: Fixed an alignment issue Anish Udupa
@ 2021-03-17 8:25 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2021-03-17 8:25 UTC (permalink / raw)
To: Anish Udupa
Cc: devel, GR-Linux-NIC-Dev, manishc, gregkh, linux-kernel, netdev
On Tue, Mar 16, 2021 at 09:26:34PM +0530, Anish Udupa wrote:
> The * of the comment was not aligned properly. Ran checkpatch and
> found the warning. Resolved it in this patch.
>
> Signed-off-by: Anish Udupa <udupa.anish@gmail.com>
> ---
> drivers/staging/qlge/qlge_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> index 5516be3af898..bfd7217f3953 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -3816,7 +3816,7 @@ static int qlge_adapter_down(struct qlge_adapter *qdev)
> qlge_tx_ring_clean(qdev);
>
> /* Call netif_napi_del() from common point.
> - */
> + */
This has already been fixed upstream. You should be working against
linux-next or staging-next.
https://lore.kernel.org/driverdev-devel/20210216101945.187474-1-ducheng2@gmail.com/
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-17 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 15:56 [PATCH] drivers: staging: qlge: Fixed an alignment issue Anish Udupa
2021-03-17 8:25 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).