driverdev-devel.linuxdriverproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: wilc1000: remove label from examples in DT binding documentation
@ 2020-03-25 16:42 Ajay.Kathat
  2020-03-26  7:45 ` Kalle Valo
  0 siblings, 1 reply; 3+ messages in thread
From: Ajay.Kathat @ 2020-03-25 16:42 UTC (permalink / raw)
  To: linux-wireless
  Cc: devel, devicetree, Ajay.Kathat, robh, gregkh, Adham.Abozaeid, johannes

From: Ajay Singh <ajay.kathat@microchip.com>

Remove labels and not relevant property from DT binding documentation
examples as suggested in [1].

1. https://patchwork.ozlabs.org/patch/1252837

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---
 drivers/staging/wilc1000/microchip,wilc1000.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/microchip,wilc1000.yaml b/drivers/staging/wilc1000/microchip,wilc1000.yaml
index bc6cc5d3f347..2c320eb2a8c4 100644
--- a/drivers/staging/wilc1000/microchip,wilc1000.yaml
+++ b/drivers/staging/wilc1000/microchip,wilc1000.yaml
@@ -36,10 +36,9 @@ required:
 
 examples:
   - |
-    spi1: spi@fc018000 {
+    spi {
       #address-cells = <1>;
       #size-cells = <0>;
-      cs-gpios = <&pioB 21 0>;
       wifi@0 {
         compatible = "microchip,wilc1000";
         spi-max-frequency = <48000000>;
@@ -52,7 +51,7 @@ examples:
     };
 
   - |
-    mmc1: mmc@fc000000 {
+    mmc {
       #address-cells = <1>;
       #size-cells = <0>;
       pinctrl-names = "default";
-- 
2.24.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: wilc1000: remove label from examples in DT binding documentation
  2020-03-25 16:42 [PATCH] staging: wilc1000: remove label from examples in DT binding documentation Ajay.Kathat
@ 2020-03-26  7:45 ` Kalle Valo
  2020-03-26  8:12   ` Ajay.Kathat
  0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2020-03-26  7:45 UTC (permalink / raw)
  To: Ajay.Kathat
  Cc: devel, devicetree, robh, gregkh, linux-wireless, Adham.Abozaeid,
	johannes

<Ajay.Kathat@microchip.com> writes:

> From: Ajay Singh <ajay.kathat@microchip.com>
>
> Remove labels and not relevant property from DT binding documentation
> examples as suggested in [1].
>
> 1. https://patchwork.ozlabs.org/patch/1252837

Just a nitpick but patchwork links are not that reliable in the long
run. Instead using a lore link is better as the message id is visible
directly from the URL.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: wilc1000: remove label from examples in DT binding documentation
  2020-03-26  7:45 ` Kalle Valo
@ 2020-03-26  8:12   ` Ajay.Kathat
  0 siblings, 0 replies; 3+ messages in thread
From: Ajay.Kathat @ 2020-03-26  8:12 UTC (permalink / raw)
  To: kvalo
  Cc: devel, devicetree, robh, gregkh, linux-wireless, Adham.Abozaeid,
	johannes

Hi Kalle,

On 26/03/20 1:15 pm, Kalle Valo wrote:
> 
> <Ajay.Kathat@microchip.com> writes:
> 
>> From: Ajay Singh <ajay.kathat@microchip.com>
>>
>> Remove labels and not relevant property from DT binding documentation
>> examples as suggested in [1].
>>
>> 1. https://patchwork.ozlabs.org/patch/1252837
> 
> Just a nitpick but patchwork links are not that reliable in the long
> run. Instead using a lore link is better as the message id is visible
> directly from the URL.
> 

Sure. I will make use of lore link for future patches as this patch is
already applied.


Regards,
Ajay
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-26  8:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 16:42 [PATCH] staging: wilc1000: remove label from examples in DT binding documentation Ajay.Kathat
2020-03-26  7:45 ` Kalle Valo
2020-03-26  8:12   ` Ajay.Kathat

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).