From: <Ajay.Kathat@microchip.com>
To: <greg@kroah.com>
Cc: devel@driverdev.osuosl.org, Eugen.Hristev@microchip.com,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Adham.Abozaeid@microchip.com
Subject: Re: [PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property
Date: Thu, 5 Sep 2019 11:34:56 +0000 [thread overview]
Message-ID: <5878d3a6-65b7-0f02-2810-57f5c060b931@microchip.com> (raw)
In-Reply-To: <20190905073700.GA30339@kroah.com>
Hi Greg,
On 05-Sep-19 1:07 PM, Greg KH wrote:
> On Thu, Sep 05, 2019 at 06:09:43AM +0000, Ajay.Kathat@microchip.com wrote:
>> Hi Eugen,
>>
>> On 04-Sep-19 7:03 PM, Eugen Hristev - M18282 wrote:
>>> From: Eugen Hristev <eugen.hristev@microchip.com>
>>>
>>> Add bindings for optional rtc clock pin.
>>>
>>> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
>>
>> Thanks for sending the patch series. The changes in this series looks
>> good to me.
>>
>> Acked-by: Ajay Singh <ajay.kathat@microchip.com>
>
> This is good, but, you are adding new features to the driver, when it is
> still in the staging directory. What's the plan on getting it out of
> here? What is left to do?
>
The plan is to get this driver reviewed and identify if there are any
more TODO items. Waiting for the review to complete.
During the last review [1], we have received comment to simplify the
packing of WID commands by avoiding the translation layer. We had done
some improvements in this but still, there are few items under discussion.
But I am not sure if this is a blocker for mainline or can be addressed
later.
At this time, I don't know if there are any more TODO for this driver.
Currently also working on testing and fixing bugs.
[1].
https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/
Regards,
Ajay
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2019-09-05 11:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 13:33 [PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property Eugen.Hristev
2019-09-04 13:34 ` [PATCH 2/2] staging: wilc1000: look for rtc_clk clock Eugen.Hristev
2019-09-05 7:38 ` Greg KH
2019-09-05 6:09 ` [PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property Ajay.Kathat
2019-09-05 7:37 ` Greg KH
2019-09-05 11:34 ` Ajay.Kathat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5878d3a6-65b7-0f02-2810-57f5c060b931@microchip.com \
--to=ajay.kathat@microchip.com \
--cc=Adham.Abozaeid@microchip.com \
--cc=Eugen.Hristev@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).