From: <Ajay.Kathat@microchip.com>
To: <Eugen.Hristev@microchip.com>, <Adham.Abozaeid@microchip.com>,
<linux-wireless@vger.kernel.org>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property
Date: Thu, 5 Sep 2019 06:09:43 +0000 [thread overview]
Message-ID: <da5ea898-d8da-a6e2-97a0-4662b7d70b31@microchip.com> (raw)
In-Reply-To: <1567603548-13355-1-git-send-email-eugen.hristev@microchip.com>
Hi Eugen,
On 04-Sep-19 7:03 PM, Eugen Hristev - M18282 wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> Add bindings for optional rtc clock pin.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Thanks for sending the patch series. The changes in this series looks
good to me.
Acked-by: Ajay Singh <ajay.kathat@microchip.com>
Regards,
Ajay
> ---
> drivers/staging/wilc1000/microchip,wilc1000,sdio.txt | 8 +++++++-
> drivers/staging/wilc1000/microchip,wilc1000,spi.txt | 8 ++++++++
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/microchip,wilc1000,sdio.txt b/drivers/staging/wilc1000/microchip,wilc1000,sdio.txt
> index 4f7d1c2..da52359 100644
> --- a/drivers/staging/wilc1000/microchip,wilc1000,sdio.txt
> +++ b/drivers/staging/wilc1000/microchip,wilc1000,sdio.txt
> @@ -10,7 +10,9 @@ Required properties:
>
> Optional:
> - bus-width : Number of data lines wired up the slot. Default 1 bit.
> -
> +- rtc_clk : Clock connected on the rtc clock line. Must be assigned
> + a frequency with assigned-clocks property, and must be
> + connected to a clock provider.
>
> Examples:
> mmc1: mmc@fc000000 {
> @@ -24,6 +26,10 @@ mmc1: mmc@fc000000 {
> wilc_sdio@0 {
> compatible = "microchip,wilc1000-sdio";
> irq-gpios = <&pioC 27 0>;
> + clocks = <&pck1>;
> + clock-names = "rtc_clk";
> + assigned-clocks = <&pck1>;
> + assigned-clock-rates = <32768>;
> status = "okay";
> reg = <0>;
> bus-width = <4>;
> diff --git a/drivers/staging/wilc1000/microchip,wilc1000,spi.txt b/drivers/staging/wilc1000/microchip,wilc1000,spi.txt
> index 87db87b..3423693 100644
> --- a/drivers/staging/wilc1000/microchip,wilc1000,spi.txt
> +++ b/drivers/staging/wilc1000/microchip,wilc1000,spi.txt
> @@ -9,6 +9,10 @@ Required properties:
> - reg : Chip select address of device
> - irq-gpios : Connect to a host IRQ
>
> +Optional:
> +- rtc_clk : Clock connected on the rtc clock line. Must be assigned
> + a frequency with assigned-clocks property, and must be
> + connected to a clock provider.
>
> Examples:
>
> @@ -21,6 +25,10 @@ spi1: spi@fc018000 {
> spi-max-frequency = <48000000>;
> reg = <0>;
> irq-gpios = <&pioC 27 0>;
> + clocks = <&pck1>;
> + clock-names = "rtc_clk";
> + assigned-clocks = <&pck1>;
> + assigned-clock-rates = <32768>;
> status = "okay";
> };
> };
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-09-05 6:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 13:33 [PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property Eugen.Hristev
2019-09-04 13:34 ` [PATCH 2/2] staging: wilc1000: look for rtc_clk clock Eugen.Hristev
2019-09-05 7:38 ` Greg KH
2019-09-05 6:09 ` Ajay.Kathat [this message]
2019-09-05 7:37 ` [PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property Greg KH
2019-09-05 11:34 ` Ajay.Kathat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da5ea898-d8da-a6e2-97a0-4662b7d70b31@microchip.com \
--to=ajay.kathat@microchip.com \
--cc=Adham.Abozaeid@microchip.com \
--cc=Eugen.Hristev@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).