From: "Jan Sebastian Götte" <linux@jaseg.net>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: "Jan Sebastian Götte" <linux@jaseg.net>,
leobras.c@gmail.com, linux-fbdev@vger.kernel.org,
devel@driverdev.osuosl.org, nishadkamdar@gmail.com,
gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org,
bhanusreemahesh@gmail.com, "Phil Reid" <preid@electromag.com.au>
Subject: Re: [PATCH] Staging: fbtft: Fix wrong check in,fbtft_write_wmem16_bus8()
Date: Mon, 15 Jul 2019 23:58:01 +0900 [thread overview]
Message-ID: <5a77c18f-7338-888f-2379-12171b6a545e@jaseg.net> (raw)
In-Reply-To: <7b8242ab-cc0c-d90b-60af-ff1c53789e44@opensynergy.com>
Coincidentially, I've worked on the exact same issue this weekend. I can confirm this change is necessary, and with this and the other two patches from Phil Reid the driver works again. The same mistake occurred in several other locations, though. I'll send a patch fixing all of them.
I've tested this on a ili9486-based display connected to a raspberry pi 3b+.
Regards, Jan
On Mon, 15 Jul 2019 Nicolas Saenz Julienne wrote:
> We actually want to set the gpio pin if it's avilable, not the other way
> around.
>
> Fixes: c440eee1a7a1 ("Staging: fbtft: Switch to the gpio descriptor
> interface")
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> drivers/staging/fbtft/fbtft-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-bus.c
> b/drivers/staging/fbtft/fbtft-bus.c
> index 2ea814d0dca5..63c65dd67b17 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -135,7 +135,7 @@ int fbtft_write_vmem16_bus8(struct fbtft_par *par,
> size_t offset, size_t len)
> remain = len / 2;
> vmem16 = (u16 *)(par->info->screen_buffer + offset);
> - if (!par->gpio.dc)
> + if (par->gpio.dc)
> gpiod_set_value(par->gpio.dc, 1);
> /* non buffered write */
> --
> 2.22.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-07-15 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 14:30 [PATCH] Staging: fbtft: Fix wrong check in fbtft_write_wmem16_bus8() Nicolas Saenz Julienne
[not found] ` <7b8242ab-cc0c-d90b-60af-ff1c53789e44@opensynergy.com>
2019-07-15 14:58 ` Jan Sebastian Götte [this message]
2019-07-15 15:04 ` [PATCH] Staging: fbtft: Fix GPIO handling Jan Sebastian Götte
2019-07-15 15:04 ` Jan Sebastian Götte
2019-07-15 15:14 ` Nicolas Saenz Julienne
2019-07-17 14:41 ` [PATCH v2] " Jan Sebastian Götte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a77c18f-7338-888f-2379-12171b6a545e@jaseg.net \
--to=linux@jaseg.net \
--cc=bhanusreemahesh@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=leobras.c@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=nishadkamdar@gmail.com \
--cc=nsaenzjulienne@suse.de \
--cc=preid@electromag.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).