From: Helen Koike <helen.koike@collabora.com>
To: "zhangxiaoxu (A)" <zhangxiaoxu5@huawei.com>,
mchehab@kernel.org, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] media: staging: rkisp1: Fix undefined reference to `phy_mipi_dphy_get_default_config' in rkisp1_mipi_csi2_start
Date: Mon, 13 Jan 2020 23:57:08 -0300 [thread overview]
Message-ID: <8676c3c3-5a2a-ed21-e6a8-b7cc14875fbf@collabora.com> (raw)
In-Reply-To: <9013da2d-f50f-112b-77a1-92123ae25fcd@huawei.com>
On 1/13/20 11:53 PM, zhangxiaoxu (A) wrote:
>
>
> 在 2020/1/14 1:34, Helen Koike 写道:
>> Hi Zhang,
>>
>> Thank you for the patch.
>>
>> On 1/13/20 1:48 AM, Zhang Xiaoxu wrote:
>>> If 'GENERIC_PHY_MIPI_DPHY' not configured, there is an error:
>>>
>>> drivers/staging/media/rkisp1/rkisp1-isp.o:
>>> In function `rkisp1_mipi_csi2_start.isra.5':
>>> rkisp1-isp.c:(.text+0x1238):
>>> undefined reference to `phy_mipi_dphy_get_default_config'
>>> make: *** [vmlinux] Error 1
>>>
>>> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
>>> ---
>>> drivers/staging/media/rkisp1/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/staging/media/rkisp1/Kconfig
>>> index b859a493caba..788bcb703376 100644
>>> --- a/drivers/staging/media/rkisp1/Kconfig
>>> +++ b/drivers/staging/media/rkisp1/Kconfig
>>> @@ -8,6 +8,7 @@ config VIDEO_ROCKCHIP_ISP1
>>> select VIDEOBUF2_VMALLOC
>>> select V4L2_FWNODE
>>> select PHY_ROCKCHIP_DPHY_RX0
>>> + select GENERIC_PHY_MIPI_DPHY
>>> default n
>>> help
>>> Enable this to support the Image Signal Processing (ISP) module
>>>
>>
>> How are you reproducing this?
>>
>> VIDEO_ROCKCHIP_ISP1 selects PHY_ROCKCHIP_DPHY_RX0
>>
>> and
>>
>> PHY_ROCKCHIP_DPHY_RX0 already selects GENERIC_PHY_MIPI_DPHY,
>>
>> So it shouldn't be a problem (unless I misunderstood something, which is probably the case).
> Yes, you are right.
>
> This can be reproduce with the following config:
> # CONFIG_OF is not set
> #
> # soc_camera sensor drivers
> #
> CONFIG_PHY_ROCKCHIP_DPHY_RX0=y
> CONFIG_VIDEO_ROCKCHIP_ISP1=y
>
> I think the cause of the problem is:
> 'CONFIG_PHY_ROCKCHIP_DPHY_RX0' should also be depended on 'CONFIG_OF'.
>
You probably mean 'CONFIG_VIDEO_ROCKCHIP_ISP1' right? As the phy driver already depends on OF.
Yes, if I understand correctly it should. Could you send a patching adding it?
Thanks
Helen
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2020-01-14 2:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 3:48 [PATCH] media: staging: rkisp1: Fix undefined reference to `phy_mipi_dphy_get_default_config' in rkisp1_mipi_csi2_start Zhang Xiaoxu
2020-01-13 17:34 ` Helen Koike
2020-01-14 1:53 ` zhangxiaoxu (A)
2020-01-14 2:57 ` Helen Koike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8676c3c3-5a2a-ed21-e6a8-b7cc14875fbf@collabora.com \
--to=helen.koike@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).