* [PATCH] media: staging: rkisp1: Fix undefined reference to `phy_mipi_dphy_get_default_config' in rkisp1_mipi_csi2_start
@ 2020-01-13 3:48 Zhang Xiaoxu
2020-01-13 17:34 ` Helen Koike
0 siblings, 1 reply; 4+ messages in thread
From: Zhang Xiaoxu @ 2020-01-13 3:48 UTC (permalink / raw)
To: helen.koike, mchehab, gregkh, zhangxiaoxu5; +Cc: devel, linux-media
If 'GENERIC_PHY_MIPI_DPHY' not configured, there is an error:
drivers/staging/media/rkisp1/rkisp1-isp.o:
In function `rkisp1_mipi_csi2_start.isra.5':
rkisp1-isp.c:(.text+0x1238):
undefined reference to `phy_mipi_dphy_get_default_config'
make: *** [vmlinux] Error 1
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
---
drivers/staging/media/rkisp1/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/staging/media/rkisp1/Kconfig
index b859a493caba..788bcb703376 100644
--- a/drivers/staging/media/rkisp1/Kconfig
+++ b/drivers/staging/media/rkisp1/Kconfig
@@ -8,6 +8,7 @@ config VIDEO_ROCKCHIP_ISP1
select VIDEOBUF2_VMALLOC
select V4L2_FWNODE
select PHY_ROCKCHIP_DPHY_RX0
+ select GENERIC_PHY_MIPI_DPHY
default n
help
Enable this to support the Image Signal Processing (ISP) module
--
2.17.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] media: staging: rkisp1: Fix undefined reference to `phy_mipi_dphy_get_default_config' in rkisp1_mipi_csi2_start
2020-01-13 3:48 [PATCH] media: staging: rkisp1: Fix undefined reference to `phy_mipi_dphy_get_default_config' in rkisp1_mipi_csi2_start Zhang Xiaoxu
@ 2020-01-13 17:34 ` Helen Koike
2020-01-14 1:53 ` zhangxiaoxu (A)
0 siblings, 1 reply; 4+ messages in thread
From: Helen Koike @ 2020-01-13 17:34 UTC (permalink / raw)
To: Zhang Xiaoxu, mchehab, gregkh; +Cc: devel, linux-media
Hi Zhang,
Thank you for the patch.
On 1/13/20 1:48 AM, Zhang Xiaoxu wrote:
> If 'GENERIC_PHY_MIPI_DPHY' not configured, there is an error:
>
> drivers/staging/media/rkisp1/rkisp1-isp.o:
> In function `rkisp1_mipi_csi2_start.isra.5':
> rkisp1-isp.c:(.text+0x1238):
> undefined reference to `phy_mipi_dphy_get_default_config'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
> ---
> drivers/staging/media/rkisp1/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/staging/media/rkisp1/Kconfig
> index b859a493caba..788bcb703376 100644
> --- a/drivers/staging/media/rkisp1/Kconfig
> +++ b/drivers/staging/media/rkisp1/Kconfig
> @@ -8,6 +8,7 @@ config VIDEO_ROCKCHIP_ISP1
> select VIDEOBUF2_VMALLOC
> select V4L2_FWNODE
> select PHY_ROCKCHIP_DPHY_RX0
> + select GENERIC_PHY_MIPI_DPHY
> default n
> help
> Enable this to support the Image Signal Processing (ISP) module
>
How are you reproducing this?
VIDEO_ROCKCHIP_ISP1 selects PHY_ROCKCHIP_DPHY_RX0
and
PHY_ROCKCHIP_DPHY_RX0 already selects GENERIC_PHY_MIPI_DPHY,
So it shouldn't be a problem (unless I misunderstood something, which is probably the case).
Thanks
Helen
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: staging: rkisp1: Fix undefined reference to `phy_mipi_dphy_get_default_config' in rkisp1_mipi_csi2_start
2020-01-13 17:34 ` Helen Koike
@ 2020-01-14 1:53 ` zhangxiaoxu (A)
2020-01-14 2:57 ` Helen Koike
0 siblings, 1 reply; 4+ messages in thread
From: zhangxiaoxu (A) @ 2020-01-14 1:53 UTC (permalink / raw)
To: Helen Koike, mchehab, gregkh; +Cc: devel, linux-media
在 2020/1/14 1:34, Helen Koike 写道:
> Hi Zhang,
>
> Thank you for the patch.
>
> On 1/13/20 1:48 AM, Zhang Xiaoxu wrote:
>> If 'GENERIC_PHY_MIPI_DPHY' not configured, there is an error:
>>
>> drivers/staging/media/rkisp1/rkisp1-isp.o:
>> In function `rkisp1_mipi_csi2_start.isra.5':
>> rkisp1-isp.c:(.text+0x1238):
>> undefined reference to `phy_mipi_dphy_get_default_config'
>> make: *** [vmlinux] Error 1
>>
>> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
>> ---
>> drivers/staging/media/rkisp1/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/staging/media/rkisp1/Kconfig
>> index b859a493caba..788bcb703376 100644
>> --- a/drivers/staging/media/rkisp1/Kconfig
>> +++ b/drivers/staging/media/rkisp1/Kconfig
>> @@ -8,6 +8,7 @@ config VIDEO_ROCKCHIP_ISP1
>> select VIDEOBUF2_VMALLOC
>> select V4L2_FWNODE
>> select PHY_ROCKCHIP_DPHY_RX0
>> + select GENERIC_PHY_MIPI_DPHY
>> default n
>> help
>> Enable this to support the Image Signal Processing (ISP) module
>>
>
> How are you reproducing this?
>
> VIDEO_ROCKCHIP_ISP1 selects PHY_ROCKCHIP_DPHY_RX0
>
> and
>
> PHY_ROCKCHIP_DPHY_RX0 already selects GENERIC_PHY_MIPI_DPHY,
>
> So it shouldn't be a problem (unless I misunderstood something, which is probably the case).
Yes, you are right.
This can be reproduce with the following config:
# CONFIG_OF is not set
#
# soc_camera sensor drivers
#
CONFIG_PHY_ROCKCHIP_DPHY_RX0=y
CONFIG_VIDEO_ROCKCHIP_ISP1=y
I think the cause of the problem is:
'CONFIG_PHY_ROCKCHIP_DPHY_RX0' should also be depended on 'CONFIG_OF'.
>
> Thanks
> Helen
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: staging: rkisp1: Fix undefined reference to `phy_mipi_dphy_get_default_config' in rkisp1_mipi_csi2_start
2020-01-14 1:53 ` zhangxiaoxu (A)
@ 2020-01-14 2:57 ` Helen Koike
0 siblings, 0 replies; 4+ messages in thread
From: Helen Koike @ 2020-01-14 2:57 UTC (permalink / raw)
To: zhangxiaoxu (A), mchehab, gregkh; +Cc: devel, linux-media
On 1/13/20 11:53 PM, zhangxiaoxu (A) wrote:
>
>
> 在 2020/1/14 1:34, Helen Koike 写道:
>> Hi Zhang,
>>
>> Thank you for the patch.
>>
>> On 1/13/20 1:48 AM, Zhang Xiaoxu wrote:
>>> If 'GENERIC_PHY_MIPI_DPHY' not configured, there is an error:
>>>
>>> drivers/staging/media/rkisp1/rkisp1-isp.o:
>>> In function `rkisp1_mipi_csi2_start.isra.5':
>>> rkisp1-isp.c:(.text+0x1238):
>>> undefined reference to `phy_mipi_dphy_get_default_config'
>>> make: *** [vmlinux] Error 1
>>>
>>> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
>>> ---
>>> drivers/staging/media/rkisp1/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/staging/media/rkisp1/Kconfig
>>> index b859a493caba..788bcb703376 100644
>>> --- a/drivers/staging/media/rkisp1/Kconfig
>>> +++ b/drivers/staging/media/rkisp1/Kconfig
>>> @@ -8,6 +8,7 @@ config VIDEO_ROCKCHIP_ISP1
>>> select VIDEOBUF2_VMALLOC
>>> select V4L2_FWNODE
>>> select PHY_ROCKCHIP_DPHY_RX0
>>> + select GENERIC_PHY_MIPI_DPHY
>>> default n
>>> help
>>> Enable this to support the Image Signal Processing (ISP) module
>>>
>>
>> How are you reproducing this?
>>
>> VIDEO_ROCKCHIP_ISP1 selects PHY_ROCKCHIP_DPHY_RX0
>>
>> and
>>
>> PHY_ROCKCHIP_DPHY_RX0 already selects GENERIC_PHY_MIPI_DPHY,
>>
>> So it shouldn't be a problem (unless I misunderstood something, which is probably the case).
> Yes, you are right.
>
> This can be reproduce with the following config:
> # CONFIG_OF is not set
> #
> # soc_camera sensor drivers
> #
> CONFIG_PHY_ROCKCHIP_DPHY_RX0=y
> CONFIG_VIDEO_ROCKCHIP_ISP1=y
>
> I think the cause of the problem is:
> 'CONFIG_PHY_ROCKCHIP_DPHY_RX0' should also be depended on 'CONFIG_OF'.
>
You probably mean 'CONFIG_VIDEO_ROCKCHIP_ISP1' right? As the phy driver already depends on OF.
Yes, if I understand correctly it should. Could you send a patching adding it?
Thanks
Helen
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-14 2:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 3:48 [PATCH] media: staging: rkisp1: Fix undefined reference to `phy_mipi_dphy_get_default_config' in rkisp1_mipi_csi2_start Zhang Xiaoxu
2020-01-13 17:34 ` Helen Koike
2020-01-14 1:53 ` zhangxiaoxu (A)
2020-01-14 2:57 ` Helen Koike
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).