* [PATCH] staging: dpaa2-ethsw: fix switch/case fallthrough warning
@ 2020-07-20 5:30 Marian Posteuca
2020-07-20 6:09 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Marian Posteuca @ 2020-07-20 5:30 UTC (permalink / raw)
To: Ioana Radulescu, Ioana Ciornei, Greg Kroah-Hartman, linux-kernel, devel
Cc: Marian Posteuca
Fix the fallthrough warning that is reported by checkpatch.
Signed-off-by: Marian Posteuca <posteuca@mutex.one>
---
drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
index 2fb75a7c9314..4986591097dc 100644
--- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
+++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
@@ -1362,7 +1362,8 @@ static int port_switchdev_blocking_event(struct notifier_block *unused,
return NOTIFY_DONE;
switch (event) {
- case SWITCHDEV_PORT_OBJ_ADD: /* fall through */
+ case SWITCHDEV_PORT_OBJ_ADD:
+ fallthrough;
case SWITCHDEV_PORT_OBJ_DEL:
return ethsw_switchdev_port_obj_event(event, dev, ptr);
case SWITCHDEV_PORT_ATTR_SET:
--
2.26.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: dpaa2-ethsw: fix switch/case fallthrough warning
2020-07-20 5:30 [PATCH] staging: dpaa2-ethsw: fix switch/case fallthrough warning Marian Posteuca
@ 2020-07-20 6:09 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2020-07-20 6:09 UTC (permalink / raw)
To: Marian Posteuca, Ioana Radulescu, Ioana Ciornei,
Greg Kroah-Hartman, linux-kernel, devel
On Mon, 2020-07-20 at 08:30 +0300, Marian Posteuca wrote:
> Fix the fallthrough warning that is reported by checkpatch.
>
> Signed-off-by: Marian Posteuca <posteuca@mutex.one>
> ---
> drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
> index 2fb75a7c9314..4986591097dc 100644
> --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
> +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
> @@ -1362,7 +1362,8 @@ static int port_switchdev_blocking_event(struct notifier_block *unused,
> return NOTIFY_DONE;
>
> switch (event) {
> - case SWITCHDEV_PORT_OBJ_ADD: /* fall through */
> + case SWITCHDEV_PORT_OBJ_ADD:
> + fallthrough;
This comment is better removed instead of
converted to fallthrough;
It's no different than a multiple case block like:
switch (val) {
case FOO:
case BAR:
foobar();
break;
default:
return baz;
}
etc...
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-20 6:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 5:30 [PATCH] staging: dpaa2-ethsw: fix switch/case fallthrough warning Marian Posteuca
2020-07-20 6:09 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).