Re: [PATCH v2 1/2] staging: rtl8192u: Add or remove spaces to fix style issues

* Re: [PATCH v2 1/2] staging: rtl8192u: Add or remove spaces to fix style issues
       [not found] ` <20190827084319.GB23584@kadam>
@ 2019-09-08  7:28   ` Sumera Priyadarsini
  2019-09-10 11:30     ` Dan Carpenter
  0 siblings, 1 reply; 3+ messages in thread
From: Sumera Priyadarsini @ 2019-09-08  7:28 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: devel, Greg KH

On Tue, Aug 27, 2019 at 2:13 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Mon, Aug 26, 2019 at 11:39:09PM +0530, Sumera Priyadarsini wrote:
> > This patch fixes the file r8190_rtl8256.c to avoid the following
> > checkpatch.pl warnings:
> >       CHECK: spaces preferred around that '<<' (ctx:VxV)
> >       CHECK: spaces preferred around that '-' (ctx:VxV)
> >       CHECK: No space is necessary after a cast
> >
> > Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
> > ---
> > Changes since v1:
> > - Split the commit into two patches
> > ---
> >  drivers/staging/rtl8192u/r8190_rtl8256.c | 30 ++++++++++++------------
> >  1 file changed, 15 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c
> > index 0bedf88525cd..7c7f8247b27a 100644
> > --- a/drivers/staging/rtl8192u/r8190_rtl8256.c
> > +++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
> > @@ -42,9 +42,9 @@ void phy_set_rf8256_bandwidth(struct net_device *dev, enum ht_channel_width Band
> >
> >               switch (Bandwidth) {
> >               case HT_CHANNEL_WIDTH_20:
> > -                             if (priv->card_8192_version == VERSION_819XU_A
> > -                                     || priv->card_8192_version
> > -                                     == VERSION_819XU_B) { /* 8256 D-cut, E-cut, xiong: consider it later! */
> > +                             if (priv->card_8192_version == VERSION_819XU_A ||
> > +                                     priv->card_8192_version ==
> > +                                     VERSION_819XU_B) { /* 8256 D-cut, E-cut, xiong: consider it later! */
>
> These lines are indented too far and the == should go on the first line
> like the || does.
>
>                         if (priv->card_8192_version == VERSION_819XU_A ||
>                             priv->card_8192_version == VERSION_819XU_B) {
>                                 /* 8256 D-cut, E-cut, xiong: consider it later! */
>
> Probably do this in a separate patch.  It's sort of not really related
> to the other changes.
>
> regards,
> dan carpenter
>
>
Hi, I am extremely sorry for a late response to this. I was caught up
with some laptop issues. I will send a separate patch making the
change right away.

Regards,
Sumera
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread