DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] staging: exfat: make staging/exfat and fs/exfat mutually exclusive
@ 2020-01-11 12:14 Namjae Jeon
  2020-01-11 17:56 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Namjae Jeon @ 2020-01-11 12:14 UTC (permalink / raw)
  To: gregkh, valdis.kletnieks
  Cc: devel, Namjae Jeon, Namjae Jeon, amir73il, linux-kernel, linux-fsdevel

From: Namjae Jeon <namjae.jeon@samsung.com>

Make staging/exfat and fs/exfat mutually exclusive to select the one
between two same filesystem.

Suggested-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
---
 drivers/staging/exfat/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/exfat/Kconfig b/drivers/staging/exfat/Kconfig
index 292a19dfcaf5..9a0fccec65d9 100644
--- a/drivers/staging/exfat/Kconfig
+++ b/drivers/staging/exfat/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 config STAGING_EXFAT_FS
 	tristate "exFAT fs support"
-	depends on BLOCK
+	depends on BLOCK && !EXFAT_FS
 	select NLS
 	help
 	  This adds support for the exFAT file system.
-- 
2.17.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: exfat: make staging/exfat and fs/exfat mutually exclusive
  2020-01-11 12:14 [PATCH] staging: exfat: make staging/exfat and fs/exfat mutually exclusive Namjae Jeon
@ 2020-01-11 17:56 ` Greg KH
  2020-01-11 23:35   ` Namjae Jeon
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-01-11 17:56 UTC (permalink / raw)
  To: Namjae Jeon
  Cc: devel, valdis.kletnieks, Namjae Jeon, amir73il, linux-kernel,
	linux-fsdevel

On Sat, Jan 11, 2020 at 09:14:19PM +0900, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
> 
> Make staging/exfat and fs/exfat mutually exclusive to select the one
> between two same filesystem.
> 
> Suggested-by: Amir Goldstein <amir73il@gmail.com>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> ---
>  drivers/staging/exfat/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/exfat/Kconfig b/drivers/staging/exfat/Kconfig
> index 292a19dfcaf5..9a0fccec65d9 100644
> --- a/drivers/staging/exfat/Kconfig
> +++ b/drivers/staging/exfat/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0
>  config STAGING_EXFAT_FS
>  	tristate "exFAT fs support"
> -	depends on BLOCK
> +	depends on BLOCK && !EXFAT_FS

There is no such symbol in the kernel tree, so this isn't going to do
anything :(

When/if EXFAT_FS does show up, I will be glad to add this.  Or better
yet, just have this as part of the "real" exfat patchset, that would
make the most sense, right?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: exfat: make staging/exfat and fs/exfat mutually exclusive
  2020-01-11 17:56 ` Greg KH
@ 2020-01-11 23:35   ` Namjae Jeon
  0 siblings, 0 replies; 3+ messages in thread
From: Namjae Jeon @ 2020-01-11 23:35 UTC (permalink / raw)
  To: Greg KH
  Cc: devel, valdis.kletnieks, Namjae Jeon, amir73il, linux-kernel,
	linux-fsdevel

2020-01-12 2:56 GMT+09:00, Greg KH <gregkh@linuxfoundation.org>:
> On Sat, Jan 11, 2020 at 09:14:19PM +0900, Namjae Jeon wrote:
>> From: Namjae Jeon <namjae.jeon@samsung.com>
>>
>> Make staging/exfat and fs/exfat mutually exclusive to select the one
>> between two same filesystem.
>>
>> Suggested-by: Amir Goldstein <amir73il@gmail.com>
>> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
>> ---
>>  drivers/staging/exfat/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/exfat/Kconfig
>> b/drivers/staging/exfat/Kconfig
>> index 292a19dfcaf5..9a0fccec65d9 100644
>> --- a/drivers/staging/exfat/Kconfig
>> +++ b/drivers/staging/exfat/Kconfig
>> @@ -1,7 +1,7 @@
>>  # SPDX-License-Identifier: GPL-2.0
>>  config STAGING_EXFAT_FS
>>  	tristate "exFAT fs support"
>> -	depends on BLOCK
>> +	depends on BLOCK && !EXFAT_FS
>
> There is no such symbol in the kernel tree, so this isn't going to do
> anything :(
>
> When/if EXFAT_FS does show up, I will be glad to add this.  Or better
> yet, just have this as part of the "real" exfat patchset, that would
> make the most sense, right?
Right,
Thanks!
>
> thanks,
>
> greg k-h
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-11 12:14 [PATCH] staging: exfat: make staging/exfat and fs/exfat mutually exclusive Namjae Jeon
2020-01-11 17:56 ` Greg KH
2020-01-11 23:35   ` Namjae Jeon

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git