DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] staging: qlge: qlge_dbg: removed comment repition
@ 2020-07-28 18:26 Dhiraj Sharma
  2020-07-29  5:36 ` Dhiraj Sharma
  0 siblings, 1 reply; 4+ messages in thread
From: Dhiraj Sharma @ 2020-07-28 18:26 UTC (permalink / raw)
  To: manishc, gregkh; +Cc: devel, netdev, Dhiraj Sharma, linux-kernel

Inside function ql_get_dump comment statement had a repition of word
"to" which I removed and checkpatch.pl ouputs zero error or warnings
now.

Signed-off-by: Dhiraj Sharma <dhiraj.sharma0024@gmail.com>
---
 drivers/staging/qlge/qlge_dbg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 985a6c341294..a55bf0b3e9dc 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -1298,7 +1298,7 @@ void ql_get_dump(struct ql_adapter *qdev, void *buff)
 	 * If the dump has already been taken and is stored
 	 * in our internal buffer and if force dump is set then
 	 * just start the spool to dump it to the log file
-	 * and also, take a snapshot of the general regs to
+	 * and also, take a snapshot of the general regs
 	 * to the user's buffer or else take complete dump
 	 * to the user's buffer if force is not set.
 	 */
--
2.17.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: qlge: qlge_dbg: removed comment repition
  2020-07-28 18:26 [PATCH] staging: qlge: qlge_dbg: removed comment repition Dhiraj Sharma
@ 2020-07-29  5:36 ` Dhiraj Sharma
  2020-07-29  5:46   ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Dhiraj Sharma @ 2020-07-29  5:36 UTC (permalink / raw)
  To: manishc, Greg KH; +Cc: devel, netdev, linux-kernel

Hello,

 I know that I should ask for reviews etc after a week but the change
is for my eudyptula task and until it doesn't get merged little
penguin will not pass the task for me so please look at it.


Thank You
Dhiraj Sharma

On Tue, Jul 28, 2020 at 11:56 PM Dhiraj Sharma
<dhiraj.sharma0024@gmail.com> wrote:
>
> Inside function ql_get_dump comment statement had a repition of word
> "to" which I removed and checkpatch.pl ouputs zero error or warnings
> now.
>
> Signed-off-by: Dhiraj Sharma <dhiraj.sharma0024@gmail.com>
> ---
>  drivers/staging/qlge/qlge_dbg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
> index 985a6c341294..a55bf0b3e9dc 100644
> --- a/drivers/staging/qlge/qlge_dbg.c
> +++ b/drivers/staging/qlge/qlge_dbg.c
> @@ -1298,7 +1298,7 @@ void ql_get_dump(struct ql_adapter *qdev, void *buff)
>          * If the dump has already been taken and is stored
>          * in our internal buffer and if force dump is set then
>          * just start the spool to dump it to the log file
> -        * and also, take a snapshot of the general regs to
> +        * and also, take a snapshot of the general regs
>          * to the user's buffer or else take complete dump
>          * to the user's buffer if force is not set.
>          */
> --
> 2.17.1
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: qlge: qlge_dbg: removed comment repition
  2020-07-29  5:36 ` Dhiraj Sharma
@ 2020-07-29  5:46   ` Greg KH
  2020-07-29  6:05     ` Dhiraj Sharma
  0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2020-07-29  5:46 UTC (permalink / raw)
  To: Dhiraj Sharma; +Cc: devel, netdev, linux-kernel, manishc

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Wed, Jul 29, 2020 at 11:06:56AM +0530, Dhiraj Sharma wrote:
> Hello,

<snip>

It has been less than 24 hours for a simple comment cleanup patch.
Please give maintainers time, they deal with thousands of patches a
week.

Usually, if after 2 weeks, you have not gotten a response, you can
resend it.

>  I know that I should ask for reviews etc after a week but the change
> is for my eudyptula task and until it doesn't get merged little
> penguin will not pass the task for me so please look at it.

If you knew that you should wait for at least a week, and yet you did
not, that implies that you somehow feel this comment cleanup patch is
more important than everyone else, which is a bit rude, don't you think?

There are no such things as deadlines when it comes to upstream kernel
development, sorry.

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: qlge: qlge_dbg: removed comment repition
  2020-07-29  5:46   ` Greg KH
@ 2020-07-29  6:05     ` Dhiraj Sharma
  0 siblings, 0 replies; 4+ messages in thread
From: Dhiraj Sharma @ 2020-07-29  6:05 UTC (permalink / raw)
  To: Greg KH; +Cc: devel, netdev, linux-kernel, manishc

>
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
> http://daringfireball.net/2007/07/on_top
>


I will avoid such things and will do useful stuff.

>
> It has been less than 24 hours for a simple comment cleanup patch.
> Please give maintainers time, they deal with thousands of patches a
> week.
>
> Usually, if after 2 weeks, you have not gotten a response, you can
> resend it.
>
> >  I know that I should ask for reviews etc after a week but the change
> > is for my eudyptula task and until it doesn't get merged little
> > penguin will not pass the task for me so please look at it.
>
> If you knew that you should wait for at least a week, and yet you did
> not, that implies that you somehow feel this comment cleanup patch is
> more important than everyone else, which is a bit rude, don't you think?
>
> There are no such things as deadlines when it comes to upstream kernel
> development, sorry.
>

Alright, I will wait and hope it gets accepted before 1st August or
else I have patience.


Thank You
Dhiraj Sharma
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 18:26 [PATCH] staging: qlge: qlge_dbg: removed comment repition Dhiraj Sharma
2020-07-29  5:36 ` Dhiraj Sharma
2020-07-29  5:46   ` Greg KH
2020-07-29  6:05     ` Dhiraj Sharma

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git