* [PATCH] staging: gasket Fix comparision with Null
@ 2021-02-17 13:28 mayanksuman
2021-02-17 15:19 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: mayanksuman @ 2021-02-17 13:28 UTC (permalink / raw)
To: rspringer, toddpoynor, benchan, rcy, gregkh, devel, linux-kernel
Cc: Mayank Suman
From: Mayank Suman <mayanksuman@live.com>
The change was suggested by checkpatch.pl.
Signed-off-by: Mayank Suman <mayanksuman@live.com>
---
drivers/staging/gasket/gasket_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_sysfs.c b/drivers/staging/gasket/gasket_sysfs.c
index af26bc9f1..c5658fdf4 100644
--- a/drivers/staging/gasket/gasket_sysfs.c
+++ b/drivers/staging/gasket/gasket_sysfs.c
@@ -228,7 +228,7 @@ int gasket_sysfs_create_entries(struct device *device,
}
mutex_lock(&mapping->mutex);
- for (i = 0; attrs[i].attr.attr.name != NULL; i++) {
+ for (i = 0; attrs[i].attr.attr.name; i++) {
if (mapping->attribute_count == GASKET_SYSFS_MAX_NODES) {
dev_err(device,
"Maximum number of sysfs nodes reached for device\n");
--
2.30.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: gasket Fix comparision with Null
2021-02-17 13:28 [PATCH] staging: gasket Fix comparision with Null mayanksuman
@ 2021-02-17 15:19 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-02-17 15:19 UTC (permalink / raw)
To: mayanksuman; +Cc: devel, linux-kernel, rcy, rspringer, toddpoynor
On Wed, Feb 17, 2021 at 06:58:16PM +0530, mayanksuman@live.com wrote:
> From: Mayank Suman <mayanksuman@live.com>
>
> The change was suggested by checkpatch.pl.
What change?
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for a description of how to
write a good changelog text.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-17 15:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-17 13:28 [PATCH] staging: gasket Fix comparision with Null mayanksuman
2021-02-17 15:19 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).