* [PATCH] staging: ks7010: Enclose macros in parentheses
@ 2020-12-07 16:56 Ferdinand Schober
2020-12-07 17:49 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ferdinand Schober @ 2020-12-07 16:56 UTC (permalink / raw)
To: devel; +Cc: Ferdinand Schober, gregkh, Philipp Bruegmann, linux-kernel
Enclose macros in parentheses to ensure correct casting behaviour as
suggested by checkpatch.
Co-developed-by: Philipp Bruegmann <philipp.bruegmann@fau.de>
Signed-off-by: Philipp Bruegmann <philipp.bruegmann@fau.de>
Signed-off-by: Ferdinand Schober <ferdinand.schober@fau.de>
---
drivers/staging/ks7010/ks_hostif.h | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index 39138191a556..c62a494ed6bb 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -498,20 +498,20 @@ struct hostif_mic_failure_request {
#define TX_RATE_FIXED 5
/* 11b rate */
-#define TX_RATE_1M (u8)(10 / 5) /* 11b 11g basic rate */
-#define TX_RATE_2M (u8)(20 / 5) /* 11b 11g basic rate */
-#define TX_RATE_5M (u8)(55 / 5) /* 11g basic rate */
-#define TX_RATE_11M (u8)(110 / 5) /* 11g basic rate */
+#define TX_RATE_1M ((u8)(10 / 5)) /* 11b 11g basic rate */
+#define TX_RATE_2M ((u8)(20 / 5)) /* 11b 11g basic rate */
+#define TX_RATE_5M ((u8)(55 / 5)) /* 11g basic rate */
+#define TX_RATE_11M ((u8)(110 / 5)) /* 11g basic rate */
/* 11g rate */
-#define TX_RATE_6M (u8)(60 / 5) /* 11g basic rate */
-#define TX_RATE_12M (u8)(120 / 5) /* 11g basic rate */
-#define TX_RATE_24M (u8)(240 / 5) /* 11g basic rate */
-#define TX_RATE_9M (u8)(90 / 5)
-#define TX_RATE_18M (u8)(180 / 5)
-#define TX_RATE_36M (u8)(360 / 5)
-#define TX_RATE_48M (u8)(480 / 5)
-#define TX_RATE_54M (u8)(540 / 5)
+#define TX_RATE_6M ((u8)(60 / 5)) /* 11g basic rate */
+#define TX_RATE_12M ((u8)(120 / 5)) /* 11g basic rate */
+#define TX_RATE_24M ((u8)(240 / 5)) /* 11g basic rate */
+#define TX_RATE_9M ((u8)(90 / 5))
+#define TX_RATE_18M ((u8)(180 / 5))
+#define TX_RATE_36M ((u8)(360 / 5))
+#define TX_RATE_48M ((u8)(480 / 5))
+#define TX_RATE_54M ((u8)(540 / 5))
static inline bool is_11b_rate(u8 rate)
{
--
2.29.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: ks7010: Enclose macros in parentheses
2020-12-07 16:56 [PATCH] staging: ks7010: Enclose macros in parentheses Ferdinand Schober
@ 2020-12-07 17:49 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-12-07 17:49 UTC (permalink / raw)
To: Ferdinand Schober; +Cc: devel, Philipp Bruegmann, linux-kernel
On Mon, Dec 07, 2020 at 05:56:46PM +0100, Ferdinand Schober wrote:
> Enclose macros in parentheses to ensure correct casting behaviour as
> suggested by checkpatch.
checkpatch is wrong here :)
always use your brain when making changes like this, checkpatch is just
a perl script, and while it is quite smart, it does have limitations.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-07 17:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-07 16:56 [PATCH] staging: ks7010: Enclose macros in parentheses Ferdinand Schober
2020-12-07 17:49 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).