* [PATCH v2] staging: greybus: Add TODO item about modernizing the pwm code
@ 2020-12-08 10:16 Uwe Kleine-König
2020-12-08 10:51 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2020-12-08 10:16 UTC (permalink / raw)
To: Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: devel, linux-pwm, Thierry Reding, Lee Jones, greybus-dev
drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers
should stick to the atomic API instead.
Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
On 12/8/20 10:39 AM, Johan Hovold wrote:
> No sign off?
>
> Please also add a staging prefix since this part of greybus still lives
> there.
That after all these years I still fail occasionally to add a sign-off
... /me shakes his head about himself.
Anyhow, here comes a v2, also with the requested prefix.
drivers/staging/greybus/TODO | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/greybus/TODO b/drivers/staging/greybus/TODO
index 31f1f2cb401c..6461e0132fe3 100644
--- a/drivers/staging/greybus/TODO
+++ b/drivers/staging/greybus/TODO
@@ -1,3 +1,5 @@
* Convert all uses of the old GPIO API from <linux/gpio.h> to the
GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
lines from device tree or ACPI.
+* Make pwm.c use the struct pwm_ops::apply instead of ::config, ::set_polarity,
+ ::enable and ::disable.
--
2.29.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: greybus: Add TODO item about modernizing the pwm code
2020-12-08 10:16 [PATCH v2] staging: greybus: Add TODO item about modernizing the pwm code Uwe Kleine-König
@ 2020-12-08 10:51 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2020-12-08 10:51 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: devel, linux-pwm, Alex Elder, Greg Kroah-Hartman, Johan Hovold,
greybus-dev, Thierry Reding, Lee Jones
On Tue, Dec 08, 2020 at 11:16:07AM +0100, Uwe Kleine-König wrote:
> drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers
> should stick to the atomic API instead.
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
> On 12/8/20 10:39 AM, Johan Hovold wrote:
> > No sign off?
> >
> > Please also add a staging prefix since this part of greybus still lives
> > there.
>
> That after all these years I still fail occasionally to add a sign-off
> ... /me shakes his head about himself.
**it happens. :)
> Anyhow, here comes a v2, also with the requested prefix.
Thanks.
Acked-by: Johan Hovold <johan@kernel.org>
Johan
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-08 10:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08 10:16 [PATCH v2] staging: greybus: Add TODO item about modernizing the pwm code Uwe Kleine-König
2020-12-08 10:51 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).