From: Greg KH <gregkh@linuxfoundation.org>
To: Amrit Khera <amritkhera98@gmail.com>
Cc: devel@driverdev.osuosl.org, tkjos@android.com, surenb@google.com,
linux-kernel@vger.kernel.org, hridya@google.com,
arve@android.com, joel@joelfernandes.org, maco@android.com,
christian@brauner.io
Subject: Re: [PATCH] staging: android: Fix const keyword style issue in ashmem.c
Date: Fri, 19 Feb 2021 11:40:55 +0100 [thread overview]
Message-ID: <YC+Vt0qJbkCLPZfo@kroah.com> (raw)
In-Reply-To: <20210219101338.2670-1-amritkhera98@gmail.com>
On Fri, Feb 19, 2021 at 03:43:39PM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "struct file_operations should normally be const".
>
> Signed-off-by: Amrit Khera <amritkhera98@gmail.com>
> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index d66a64e42273..7854fd410efa 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>
> static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
> {
> - static struct file_operations vmfile_fops;
> + static const struct file_operations vmfile_fops;
> struct ashmem_area *asma = file->private_data;
> int ret = 0;
>
Always test-build your patches before sending them out, otherwise you
are wasting reviewer's time, right?
:(
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2021-02-19 10:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 10:13 [PATCH] staging: android: Fix const keyword style issue in ashmem.c Amrit Khera
2021-02-19 10:40 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC+Vt0qJbkCLPZfo@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amritkhera98@gmail.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).