[PATCH 0/2] pahole: fix maybe-uninitialized and rpm build

[PATCH 0/2] pahole: fix maybe-uninitialized and rpm build

[Yulia Kartseva]

From: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>

Fix issues encountered while builing RPM w/ v1.16:
- maybe uninitialized variable in ‘pahole_stealer' function
- malformed date in dwarves.spec changelog causing rpm build failure

Arnaldo, I wonder if we can have v1.16 package bump in the distros sooner?
Thanks!

Julia Kartseva (2):
  pahole: fix compiler warning
  pahole: fix changelog date in dwarves.spec

 pahole.c               | 2 +-
 rpm/SPECS/dwarves.spec | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.17.1

[PATCH 1/2] pahole: fix compiler warning

[Yulia Kartseva]

From: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>

Signed-off-by: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
---
 pahole.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pahole.c b/pahole.c
index 829c9ab..7ac49c2 100644
--- a/pahole.c
+++ b/pahole.c
@@ -684,8 +684,8 @@ static void print_structs_with_pointer_to(struct cu *cu, uint32_t type)
 	uint32_t id;
 
 	cu__for_each_struct_or_union(cu, id, pos) {
+		struct structure *str = NULL;
 		bool looked = false;
-		struct structure *str;
 
 		if (pos->type.namespace.name == 0)
 			continue;
-- 
2.17.1

[PATCH 2/2] pahole: fix changelog date in dwarves.spec

[Yulia Kartseva]

From: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>

Signed-off-by: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
---
 rpm/SPECS/dwarves.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rpm/SPECS/dwarves.spec b/rpm/SPECS/dwarves.spec
index 82cb971..6155608 100644
--- a/rpm/SPECS/dwarves.spec
+++ b/rpm/SPECS/dwarves.spec
@@ -127,7 +127,7 @@ make install DESTDIR=%{buildroot}
 %{_libdir}/%{libname}_reorganize.so
 
 %changelog
-* Mon 16 Dec 2019 Arnaldo Carvalho de Melo <acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - 1.16-1
+* Mon Dec 16 2019 Arnaldo Carvalho de Melo <acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - 1.16-1
 - New release: 1.16
 - BTF encoder: Preserve and encode exported functions as BTF_KIND_FUNC.
 - BTF loader: Add support for BTF_KIND_FUNC
-- 
2.17.1

Re: [PATCH 1/2] pahole: fix compiler warning

[Arnaldo Carvalho de Melo]

Em Thu, Jan 16, 2020 at 04:59:12PM -0800, Yulia Kartseva escreveu:
> From: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
> 
> Signed-off-by: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
> ---
>  pahole.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pahole.c b/pahole.c
> index 829c9ab..7ac49c2 100644
> --- a/pahole.c
> +++ b/pahole.c
> @@ -684,8 +684,8 @@ static void print_structs_with_pointer_to(struct cu *cu, uint32_t type)
>  	uint32_t id;
>  
>  	cu__for_each_struct_or_union(cu, id, pos) {
> +		struct structure *str = NULL;
>  		bool looked = false;
> -		struct structure *str;

I just fixed this one after trying to build it on RHEL7, thanks!

https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=9b09f578b7d1e75cf168e9b3098d4fb17504f26e

- Arnaldo
  
>  		if (pos->type.namespace.name == 0)
>  			continue;
> -- 
> 2.17.1
> 

-- 

- Arnaldo

Re: [PATCH 2/2] pahole: fix changelog date in dwarves.spec

[Arnaldo Carvalho de Melo]

Em Thu, Jan 16, 2020 at 04:59:13PM -0800, Yulia Kartseva escreveu:
> From: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
> 
> Signed-off-by: Julia Kartseva <hex-b10kYP2dOMg@public.gmane.org>
> ---
>  rpm/SPECS/dwarves.spec | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied, my bad :-\

- Arnaldo
 
> diff --git a/rpm/SPECS/dwarves.spec b/rpm/SPECS/dwarves.spec
> index 82cb971..6155608 100644
> --- a/rpm/SPECS/dwarves.spec
> +++ b/rpm/SPECS/dwarves.spec
> @@ -127,7 +127,7 @@ make install DESTDIR=%{buildroot}
>  %{_libdir}/%{libname}_reorganize.so
>  
>  %changelog
> -* Mon 16 Dec 2019 Arnaldo Carvalho de Melo <acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - 1.16-1
> +* Mon Dec 16 2019 Arnaldo Carvalho de Melo <acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> - 1.16-1
>  - New release: 1.16
>  - BTF encoder: Preserve and encode exported functions as BTF_KIND_FUNC.
>  - BTF loader: Add support for BTF_KIND_FUNC
> -- 
> 2.17.1
> 

-- 

- Arnaldo