From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Luca Boccassi <bluca@debian.org>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>, dwarves@vger.kernel.org
Subject: Re: [PATCH dwarves] libbpf: allow to use packaged version
Date: Wed, 9 Jun 2021 13:07:10 -0300 [thread overview]
Message-ID: <YMDnLoL3H7bo3HOv@kernel.org> (raw)
In-Reply-To: <c3a211f0bef8aed1c097f13f0a178f838dc5f520.camel@debian.org>
Em Fri, Jan 15, 2021 at 03:40:34PM +0000, Luca Boccassi escreveu:
> On Fri, 2021-01-15 at 12:29 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Jan 04, 2021 at 12:23:25PM -0800, Andrii Nakryiko escreveu:
> > > On Sun, Jan 3, 2021 at 1:30 PM Luca Boccassi <bluca@debian.org> wrote:
> > > > On Sun, 2021-01-03 at 11:10 -0800, Andrii Nakryiko wrote:
> > > > > On Sat, Jan 2, 2021 at 10:25 AM Luca Boccassi <bluca@debian.org>
> > > > > wrote:
> > > > > > Add a new CMake option, LIBBPF_EMBEDDED, to switch between the
> > > > > > embedded version and the system version (searched via pkg-config)
> > > > > > of libbpf. Set the system version as the default.
> > > > > >
> > > > >
> > > > > There's been a lot of arguments about libbpf as a submodule, so I
> > > > > don't think we need to go about pros and cons again, but I just
> > > > > wanted
> > > > > to cast my vote against doing this at all. Having pahole built with
> > > > > libbpf statically (only) was a great thing for me so far with
> > > > > iterating quickly and adopting new APIs without overcomplicating the
> > > > > source code with all sorts of feature detection code. Without it,
> > > > > adopting libbpf's faster string deduplication, BTF writing APIs,
> > > > > module/split BTFs, etc, etc, would be much bigger PITA and/or would
> > > > > prolong such changes. To the point that I personally wouldn't bother
> > > > > with some of them at all. Distro maintainers obviously don't care
> > > > > about such inconveniences for developers, but it's a real factor in
> > > > > determining what kind of functionality is implemented in pahole, so I
> > > > > hope Arnaldo won't dismiss this without thinking about this
> > > > > carefully.
> >
> > Hey, having tools/perf/ and tools/lib/perf, tools/lib/bpf, etc all in
> > one place is really nice :-)
> >
> > > > You know very well that it's not about caring or not caring :-) There
> > > > are simply conflicting interests, and both sides are valid.
> >
> > > I didn't mean it in a negative way. Different priorities and interests
> > > is a better way to put it, sure.
> >
> > I think the default should be submodules as we're still very much in
> > flux, adding new features, etc.
> >
> > Disto maintainers can make sure they know what they're doing when making
> > tools use libbpf as a separate package.
>
> Sure, v3 has the option as default-disabled already, not a problem at
> all.
Does this mean that if I have libbpf-devel installed in my system the
default build will _not_ link with it?
I have libbpf-devel installed in my machine but, by default, I _don't_
want pahole to build with it, libbpf-devel is there for other needs.
- Arnaldo
next prev parent reply other threads:[~2021-06-09 16:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 18:22 [PATCH dwarves] libbpf: allow to use packaged version Luca Boccassi
2021-01-03 19:10 ` Andrii Nakryiko
2021-01-03 21:30 ` Luca Boccassi
2021-01-04 20:23 ` Andrii Nakryiko
2021-01-04 22:17 ` Luca Boccassi
2021-01-21 13:29 ` Arnaldo Carvalho de Melo
2021-01-21 20:02 ` Andrii Nakryiko
2021-01-21 20:33 ` Arnaldo Carvalho de Melo
2021-01-21 20:34 ` Arnaldo Carvalho de Melo
2021-01-21 21:19 ` Luca Boccassi
2021-01-15 15:29 ` Arnaldo Carvalho de Melo
2021-01-15 15:40 ` Luca Boccassi
2021-06-09 16:07 ` Arnaldo Carvalho de Melo [this message]
2021-06-09 16:11 ` Luca Boccassi
2021-01-03 21:32 ` [PATCH dwarves v2] " Luca Boccassi
2021-01-04 22:16 ` [PATCH dwarves v3] " Luca Boccassi
2021-01-13 11:18 ` Arnaldo Carvalho de Melo
2021-03-30 4:47 ` Dominique Martinet
2021-03-30 10:50 ` Luca Boccassi
2021-03-30 11:06 ` Luca Boccassi
2021-03-30 11:45 ` Dominique Martinet
2021-03-30 15:12 ` Arnaldo Carvalho de Melo
2021-03-31 1:05 ` Dominique Martinet
2021-04-13 13:42 ` Luca Boccassi
2021-05-18 14:07 ` Luca Boccassi
2021-06-09 4:10 ` Dominique Martinet
2021-06-09 16:25 ` Arnaldo Carvalho de Melo
2021-06-09 16:38 ` Arnaldo Carvalho de Melo
2021-06-09 16:43 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMDnLoL3H7bo3HOv@kernel.org \
--to=acme@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=bluca@debian.org \
--cc=dwarves@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).