From: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> To: Joel Stanley <joel@jms.id.au> Cc: Andrew Jeffery <andrew@aj.id.au>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Jamie Iles <quic_jiles@quicinc.com>, Graeme Gregory <quic_ggregory@quicinc.com>, devicetree <devicetree@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, linux-aspeed <linux-aspeed@lists.ozlabs.org> Subject: Re: [PATCH v3 0/7] Fix AST2600 quad mode SPI pinmux settings Date: Thu, 31 Mar 2022 08:44:09 -0700 [thread overview] Message-ID: <ea2ecef9-f47f-2a4e-8dda-ffd0c3691389@quicinc.com> (raw) In-Reply-To: <CACPK8Xed5Kh_Y2B3NY41bjgoALvz1gC4zbNfmUaHn_8EbHio4g@mail.gmail.com> On 3/30/2022 10:50 PM, Joel Stanley wrote: > On Tue, 29 Mar 2022 at 17:40, Jae Hyun Yoo <quic_jaehyoo@quicinc.com> wrote: >> >> I’m sending this patch series to fix current issues in AST2600 pinmux >> settings while enabling quad mode SPI support. >> >> FWSPI18 pins are basically 1.8v logic pins that are different from the >> dedicated FWSPI pins that provide 3.3v logic level, so FWSPI18 pins can’t >> be grouped with FWSPIDQ2 and FWSPIDQ3, so this series fix the issue. >> >> Also, fixes QSPI1 and QSPI2 function settings in AST2600 pinctrl dtsi to >> make it able to enable quad mode on SPI1 and SPI2 interfaces. >> >> With this series, quad mode pinmux can be set like below. >> >> FW SPI: >> &fmc { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_fwqspi_default>; >> } >> >> SPI1: >> &spi1 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_qspi1_default>; >> } >> >> SPI2: >> &spi2 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_qspi2_default>; >> } > > Thanks. I hope to see a board from you that uses this soon :) > > I'll send the patches as fixes once -rc1 is out. Thanks Joel! Yes, I would be able to send my BMC board dts soon. Thanks in advance for your review on that too. Best, Jae >> >> Please review. >> >> Thanks, >> Jae >> >> Changes in v3: >> * Added bindings patches. (Andrew) >> >> Changes in v2: >> * Rebased it on the latest. >> >> Jae Hyun Yoo (5): >> ARM: dts: aspeed-g6: remove FWQSPID group in pinctrl dtsi >> pinctrl: pinctrl-aspeed-g6: remove FWQSPID group in pinctrl >> dt-bindings: pinctrl: aspeed-g6: remove FWQSPID group >> dt-bindings: pinctrl: aspeed-g6: add FWQSPI function/group >> ARM: dts: aspeed-g6: fix SPI1/SPI2 quad pin group >> >> Johnny Huang (2): >> pinctrl: pinctrl-aspeed-g6: add FWQSPI function-group >> ARM: dts: aspeed-g6: add FWQSPI group in pinctrl dtsi >> >> .../pinctrl/aspeed,ast2600-pinctrl.yaml | 4 ++-- >> arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi | 10 +++++----- >> drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 17 ++++++++--------- >> 3 files changed, 15 insertions(+), 16 deletions(-) >> >> -- >> 2.25.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> To: Joel Stanley <joel@jms.id.au> Cc: Andrew Jeffery <andrew@aj.id.au>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Jamie Iles <quic_jiles@quicinc.com>, Graeme Gregory <quic_ggregory@quicinc.com>, devicetree <devicetree@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, linux-aspeed <linux-aspeed@lists.ozlabs.org> Subject: Re: [PATCH v3 0/7] Fix AST2600 quad mode SPI pinmux settings Date: Thu, 31 Mar 2022 08:44:09 -0700 [thread overview] Message-ID: <ea2ecef9-f47f-2a4e-8dda-ffd0c3691389@quicinc.com> (raw) In-Reply-To: <CACPK8Xed5Kh_Y2B3NY41bjgoALvz1gC4zbNfmUaHn_8EbHio4g@mail.gmail.com> On 3/30/2022 10:50 PM, Joel Stanley wrote: > On Tue, 29 Mar 2022 at 17:40, Jae Hyun Yoo <quic_jaehyoo@quicinc.com> wrote: >> >> I’m sending this patch series to fix current issues in AST2600 pinmux >> settings while enabling quad mode SPI support. >> >> FWSPI18 pins are basically 1.8v logic pins that are different from the >> dedicated FWSPI pins that provide 3.3v logic level, so FWSPI18 pins can’t >> be grouped with FWSPIDQ2 and FWSPIDQ3, so this series fix the issue. >> >> Also, fixes QSPI1 and QSPI2 function settings in AST2600 pinctrl dtsi to >> make it able to enable quad mode on SPI1 and SPI2 interfaces. >> >> With this series, quad mode pinmux can be set like below. >> >> FW SPI: >> &fmc { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_fwqspi_default>; >> } >> >> SPI1: >> &spi1 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_qspi1_default>; >> } >> >> SPI2: >> &spi2 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_qspi2_default>; >> } > > Thanks. I hope to see a board from you that uses this soon :) > > I'll send the patches as fixes once -rc1 is out. Thanks Joel! Yes, I would be able to send my BMC board dts soon. Thanks in advance for your review on that too. Best, Jae >> >> Please review. >> >> Thanks, >> Jae >> >> Changes in v3: >> * Added bindings patches. (Andrew) >> >> Changes in v2: >> * Rebased it on the latest. >> >> Jae Hyun Yoo (5): >> ARM: dts: aspeed-g6: remove FWQSPID group in pinctrl dtsi >> pinctrl: pinctrl-aspeed-g6: remove FWQSPID group in pinctrl >> dt-bindings: pinctrl: aspeed-g6: remove FWQSPID group >> dt-bindings: pinctrl: aspeed-g6: add FWQSPI function/group >> ARM: dts: aspeed-g6: fix SPI1/SPI2 quad pin group >> >> Johnny Huang (2): >> pinctrl: pinctrl-aspeed-g6: add FWQSPI function-group >> ARM: dts: aspeed-g6: add FWQSPI group in pinctrl dtsi >> >> .../pinctrl/aspeed,ast2600-pinctrl.yaml | 4 ++-- >> arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi | 10 +++++----- >> drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 17 ++++++++--------- >> 3 files changed, 15 insertions(+), 16 deletions(-) >> >> -- >> 2.25.1 >>
next prev parent reply other threads:[~2022-03-31 15:45 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-29 17:39 [PATCH v3 0/7] Fix AST2600 quad mode SPI pinmux settings Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-29 17:39 ` [PATCH v3 1/7] ARM: dts: aspeed-g6: remove FWQSPID group in pinctrl dtsi Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-29 17:39 ` [PATCH v3 2/7] pinctrl: pinctrl-aspeed-g6: remove FWQSPID group in pinctrl Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-30 2:00 ` Andrew Jeffery 2022-03-30 2:00 ` Andrew Jeffery 2022-03-29 17:39 ` [PATCH v3 3/7] dt-bindings: pinctrl: aspeed-g6: remove FWQSPID group Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-29 23:38 ` Rob Herring 2022-03-29 23:38 ` Rob Herring 2022-03-30 2:01 ` Andrew Jeffery 2022-03-30 2:01 ` Andrew Jeffery 2022-03-29 17:39 ` [PATCH v3 4/7] pinctrl: pinctrl-aspeed-g6: add FWQSPI function-group Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-30 2:02 ` Andrew Jeffery 2022-03-30 2:02 ` Andrew Jeffery 2022-03-29 17:39 ` [PATCH v3 5/7] dt-bindings: pinctrl: aspeed-g6: add FWQSPI function/group Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-29 23:38 ` Rob Herring 2022-03-29 23:38 ` Rob Herring 2022-03-30 2:03 ` Andrew Jeffery 2022-03-30 2:03 ` Andrew Jeffery 2022-03-29 17:39 ` [PATCH v3 6/7] ARM: dts: aspeed-g6: add FWQSPI group in pinctrl dtsi Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-30 2:03 ` Andrew Jeffery 2022-03-30 2:03 ` Andrew Jeffery 2022-03-29 17:39 ` [PATCH v3 7/7] ARM: dts: aspeed-g6: fix SPI1/SPI2 quad pin group Jae Hyun Yoo 2022-03-29 17:39 ` Jae Hyun Yoo 2022-03-31 5:50 ` [PATCH v3 0/7] Fix AST2600 quad mode SPI pinmux settings Joel Stanley 2022-03-31 5:50 ` Joel Stanley 2022-03-31 15:44 ` Jae Hyun Yoo [this message] 2022-03-31 15:44 ` Jae Hyun Yoo 2022-03-31 15:56 ` Cédric Le Goater 2022-03-31 15:56 ` Cédric Le Goater 2022-03-31 16:06 ` Jae Hyun Yoo 2022-03-31 16:06 ` Jae Hyun Yoo 2022-04-01 14:10 ` Jae Hyun Yoo 2022-04-01 14:10 ` Jae Hyun Yoo 2022-04-01 22:07 ` Cédric Le Goater 2022-04-01 22:07 ` Cédric Le Goater 2022-04-01 22:25 ` Jae Hyun Yoo 2022-04-01 22:25 ` Jae Hyun Yoo 2022-04-17 23:28 ` Linus Walleij 2022-04-17 23:28 ` Linus Walleij 2022-04-18 14:07 ` Jae Hyun Yoo 2022-04-18 14:07 ` Jae Hyun Yoo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ea2ecef9-f47f-2a4e-8dda-ffd0c3691389@quicinc.com \ --to=quic_jaehyoo@quicinc.com \ --cc=andrew@aj.id.au \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=krzk+dt@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=quic_ggregory@quicinc.com \ --cc=quic_jiles@quicinc.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.