From: gengdongjiu <gengdongjiu@huawei.com> To: Igor Mammedov <imammedo@redhat.com> Cc: <pbonzini@redhat.com>, <mst@redhat.com>, <shannon.zhaosl@gmail.com>, <peter.maydell@linaro.org>, <lersek@redhat.com>, <james.morse@arm.com>, <mtosatti@redhat.com>, <rth@twiddle.net>, <ehabkost@redhat.com>, <zhengxiang9@huawei.com>, <jonathan.cameron@huawei.com>, <xuwei5@huawei.com>, <kvm@vger.kernel.org>, <qemu-devel@nongnu.org>, <qemu-arm@nongnu.org>, <linuxarm@huawei.com> Subject: Re: [Qemu-devel] [PATCH v17 02/10] ACPI: add some GHES structures and macros definition Date: Fri, 21 Jun 2019 01:17:48 +0800 [thread overview] Message-ID: <ec089c94-589b-782c-1bdc-1b2c74e0ea46@huawei.com> (raw) In-Reply-To: <20190620170934.39eae310@redhat.com> On 2019/6/20 23:09, Igor Mammedov wrote: > On Thu, 20 Jun 2019 22:04:01 +0800 > gengdongjiu <gengdongjiu@huawei.com> wrote: > >> Hi Igor, >> Thanks for your review. >> >> On 2019/6/20 20:10, Igor Mammedov wrote: >>>> + */ >>>> +struct AcpiGenericErrorStatus { >>>> + /* It is a bitmask composed of ACPI_GEBS_xxx macros */ >>>> + uint32_t block_status; >>>> + uint32_t raw_data_offset; >>>> + uint32_t raw_data_length; >>>> + uint32_t data_length; >>>> + uint32_t error_severity; >>>> +} QEMU_PACKED; >>>> +typedef struct AcpiGenericErrorStatus AcpiGenericErrorStatus; >>> there shouldn't be packed structures, >>> is it a leftover from previous version? >> >> I remember some people suggest to add QEMU_PACKED before, anyway I will remove it in my next version patch. > > Question is why it's there and where it is used? sorry, it is my carelessness. it should be packed structures. I used this structures to get its actual total size and member offset in [PATCH v17 10/10]. If it is not packed structures, the total size and member offset may be not right. > > BTW: > series doesn't apply to master anymore. > Do you have a repo somewhere available for testing? Thanks, I appreciated that you can have a test. I still do not upload repo, you can reset to below commit[1] in master and apply this series. BTW: If test series, you should make an guest memory hardware error, let guest access the error address, then it will happen RAS error. I provide a software hard code method to test this series, you can refer to https://www.mail-archive.com/qemu-devel@nongnu.org/msg619771.html [1]: commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8 Merge: 5f02262 e841257 Author: Peter Maydell <peter.maydell@linaro.org> Date: Fri May 10 14:49:36 2019 +0100 > >> >>> >>>> + >>>> +/* >>>> + * Masks for block_status flags above >>>> + */ >>>> +#define ACPI_GEBS_UNCORRECTABLE 1 >>>> + >>>> +/* >> > > . >
WARNING: multiple messages have this Message-ID (diff)
From: gengdongjiu <gengdongjiu@huawei.com> To: Igor Mammedov <imammedo@redhat.com> Cc: peter.maydell@linaro.org, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, linuxarm@huawei.com, shannon.zhaosl@gmail.com, zhengxiang9@huawei.com, qemu-arm@nongnu.org, james.morse@arm.com, xuwei5@huawei.com, jonathan.cameron@huawei.com, pbonzini@redhat.com, lersek@redhat.com, rth@twiddle.net Subject: Re: [Qemu-devel] [PATCH v17 02/10] ACPI: add some GHES structures and macros definition Date: Fri, 21 Jun 2019 01:17:48 +0800 [thread overview] Message-ID: <ec089c94-589b-782c-1bdc-1b2c74e0ea46@huawei.com> (raw) In-Reply-To: <20190620170934.39eae310@redhat.com> On 2019/6/20 23:09, Igor Mammedov wrote: > On Thu, 20 Jun 2019 22:04:01 +0800 > gengdongjiu <gengdongjiu@huawei.com> wrote: > >> Hi Igor, >> Thanks for your review. >> >> On 2019/6/20 20:10, Igor Mammedov wrote: >>>> + */ >>>> +struct AcpiGenericErrorStatus { >>>> + /* It is a bitmask composed of ACPI_GEBS_xxx macros */ >>>> + uint32_t block_status; >>>> + uint32_t raw_data_offset; >>>> + uint32_t raw_data_length; >>>> + uint32_t data_length; >>>> + uint32_t error_severity; >>>> +} QEMU_PACKED; >>>> +typedef struct AcpiGenericErrorStatus AcpiGenericErrorStatus; >>> there shouldn't be packed structures, >>> is it a leftover from previous version? >> >> I remember some people suggest to add QEMU_PACKED before, anyway I will remove it in my next version patch. > > Question is why it's there and where it is used? sorry, it is my carelessness. it should be packed structures. I used this structures to get its actual total size and member offset in [PATCH v17 10/10]. If it is not packed structures, the total size and member offset may be not right. > > BTW: > series doesn't apply to master anymore. > Do you have a repo somewhere available for testing? Thanks, I appreciated that you can have a test. I still do not upload repo, you can reset to below commit[1] in master and apply this series. BTW: If test series, you should make an guest memory hardware error, let guest access the error address, then it will happen RAS error. I provide a software hard code method to test this series, you can refer to https://www.mail-archive.com/qemu-devel@nongnu.org/msg619771.html [1]: commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8 Merge: 5f02262 e841257 Author: Peter Maydell <peter.maydell@linaro.org> Date: Fri May 10 14:49:36 2019 +0100 > >> >>> >>>> + >>>> +/* >>>> + * Masks for block_status flags above >>>> + */ >>>> +#define ACPI_GEBS_UNCORRECTABLE 1 >>>> + >>>> +/* >> > > . >
next prev parent reply other threads:[~2019-06-20 17:18 UTC|newest] Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-14 11:18 [PATCH v17 00/10] Add ARMv8 RAS virtualization support in QEMU Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-05-14 11:18 ` [PATCH v17 01/10] hw/arm/virt: Add RAS platform version for migration Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-20 12:04 ` Igor Mammedov 2019-06-20 12:04 ` [Qemu-devel] " Igor Mammedov 2019-06-24 12:19 ` gengdongjiu 2019-06-24 12:19 ` [Qemu-devel] " gengdongjiu 2019-06-25 13:16 ` Igor Mammedov 2019-06-25 13:16 ` [Qemu-devel] " Igor Mammedov 2019-06-25 13:29 ` gengdongjiu 2019-06-25 13:29 ` [Qemu-devel] " gengdongjiu 2019-05-14 11:18 ` [PATCH v17 02/10] ACPI: add some GHES structures and macros definition Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-05-29 3:40 ` Michael S. Tsirkin 2019-05-29 3:40 ` [Qemu-devel] " Michael S. Tsirkin 2019-05-30 14:58 ` gengdongjiu 2019-05-30 14:58 ` [Qemu-devel] " gengdongjiu 2019-06-20 12:10 ` Igor Mammedov 2019-06-20 12:10 ` Igor Mammedov 2019-06-20 14:04 ` gengdongjiu 2019-06-20 14:04 ` gengdongjiu 2019-06-20 15:09 ` Igor Mammedov 2019-06-20 15:09 ` Igor Mammedov 2019-06-20 17:17 ` gengdongjiu [this message] 2019-06-20 17:17 ` gengdongjiu 2019-06-24 11:16 ` Igor Mammedov 2019-06-24 11:16 ` Igor Mammedov 2019-06-25 9:56 ` gengdongjiu 2019-06-25 9:56 ` gengdongjiu 2019-06-25 13:33 ` Igor Mammedov 2019-06-25 13:33 ` Igor Mammedov 2019-05-14 11:18 ` [PATCH v17 03/10] acpi: add build_append_ghes_notify() helper for Hardware Error Notification Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-24 11:21 ` Igor Mammedov 2019-06-24 11:21 ` [Qemu-devel] " Igor Mammedov 2019-05-14 11:18 ` [PATCH v17 04/10] acpi: add build_append_ghes_generic_data() helper for Generic Error Data Entry Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-20 12:28 ` Igor Mammedov 2019-06-20 12:28 ` [Qemu-devel] " Igor Mammedov 2019-06-24 12:37 ` gengdongjiu 2019-06-24 12:37 ` [Qemu-devel] " gengdongjiu 2019-05-14 11:18 ` [PATCH v17 05/10] acpi: add build_append_ghes_generic_status() helper for Generic Error Status Block Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-20 12:42 ` Igor Mammedov 2019-06-20 12:42 ` [Qemu-devel] " Igor Mammedov 2019-06-25 12:11 ` gengdongjiu 2019-06-25 12:11 ` [Qemu-devel] " gengdongjiu 2019-06-25 13:41 ` Igor Mammedov 2019-06-25 13:41 ` [Qemu-devel] " Igor Mammedov 2019-05-14 11:18 ` [PATCH v17 06/10] docs: APEI GHES generation and CPER record description Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-24 11:39 ` Igor Mammedov 2019-06-24 11:39 ` [Qemu-devel] " Igor Mammedov 2019-05-14 11:18 ` [PATCH v17 07/10] ACPI: Add APEI GHES table generation support Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-05-29 3:37 ` Michael S. Tsirkin 2019-05-29 3:37 ` [Qemu-devel] " Michael S. Tsirkin 2019-05-30 14:47 ` gengdongjiu 2019-05-30 14:47 ` [Qemu-devel] " gengdongjiu 2019-06-06 13:43 ` Jonathan Cameron 2019-06-06 13:43 ` [Qemu-devel] " Jonathan Cameron 2019-06-24 12:27 ` Igor Mammedov 2019-06-24 12:27 ` [Qemu-devel] " Igor Mammedov 2019-06-25 13:48 ` gengdongjiu 2019-06-25 13:48 ` [Qemu-devel] " gengdongjiu 2019-06-26 14:25 ` Igor Mammedov 2019-05-14 11:18 ` [PATCH v17 08/10] KVM: Move related hwpoison page functions to accel/kvm/ folder Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-24 12:32 ` Igor Mammedov 2019-06-24 12:32 ` [Qemu-devel] " Igor Mammedov 2019-06-25 12:28 ` gengdongjiu 2019-06-25 12:28 ` [Qemu-devel] " gengdongjiu 2019-05-14 11:18 ` [PATCH v17 09/10] target-arm: kvm64: inject synchronous External Abort Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-05-14 11:18 ` [PATCH v17 10/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM Dongjiu Geng 2019-05-14 11:18 ` [Qemu-devel] " Dongjiu Geng 2019-06-06 13:31 ` Jonathan Cameron 2019-06-06 13:31 ` [Qemu-devel] " Jonathan Cameron 2019-06-24 13:08 ` Igor Mammedov 2019-06-24 13:08 ` [Qemu-devel] " Igor Mammedov 2019-06-25 12:24 ` gengdongjiu 2019-06-25 12:24 ` [Qemu-devel] " gengdongjiu 2019-06-25 13:32 ` Igor Mammedov 2019-06-25 13:32 ` [Qemu-devel] " Igor Mammedov 2019-05-15 9:40 ` [PATCH v17 00/10] Add ARMv8 RAS virtualization support in QEMU gengdongjiu 2019-05-15 9:40 ` [Qemu-devel] " gengdongjiu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ec089c94-589b-782c-1bdc-1b2c74e0ea46@huawei.com \ --to=gengdongjiu@huawei.com \ --cc=ehabkost@redhat.com \ --cc=imammedo@redhat.com \ --cc=james.morse@arm.com \ --cc=jonathan.cameron@huawei.com \ --cc=kvm@vger.kernel.org \ --cc=lersek@redhat.com \ --cc=linuxarm@huawei.com \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=shannon.zhaosl@gmail.com \ --cc=xuwei5@huawei.com \ --cc=zhengxiang9@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.