From: Michael Walle <michael@walle.cc>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-gpio <linux-gpio@vger.kernel.org>,
linux-devicetree <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org,
LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
arm-soc <linux-arm-kernel@lists.infradead.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Lee Jones" <lee.jones@linaro.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Shawn Guo" <shawnguo@kernel.org>, "Li Yang" <leoyang.li@nxp.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jason Cooper" <jason@lakedaemon.net>,
"Marc Zyngier" <maz@kernel.org>
Subject: Re: [PATCH 12/18] gpio: add support for the sl28cpld GPIO controller
Date: Sat, 28 Mar 2020 13:04:50 +0100 [thread overview]
Message-ID: <ef10a6f07f093c282df7fe94057cc7c7@walle.cc> (raw)
In-Reply-To: <CAMpxmJW770v6JLdveEe1hkgNEJByVyArhorSyUZBYOyFiVyOeg@mail.gmail.com>
Hi Bartosz,
Am 2020-03-18 10:14, schrieb Bartosz Golaszewski:
> wt., 17 mar 2020 o 21:50 Michael Walle <michael@walle.cc> napisał(a):
>>
>> This adds support for the GPIO controller of the sl28 board management
>> controller. This driver is part of a multi-function device.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>
> Hi Michael,
>
> thanks for the driver. Please take a look at some comments below.
>
>> ---
[..]
>> +#define GPIO_REG_DIR 0
>> +#define GPIO_REG_OUT 1
>> +#define GPIO_REG_IN 2
>> +#define GPIO_REG_IE 3
>> +#define GPIO_REG_IP 4
>
> These values would be more clear if they were defined as hex.
>
>> +
>> +#define GPI_REG_IN 0
>> +
>> +#define GPO_REG_OUT 0
>
> Please also use a common prefix even for defines.
The GPIO_, GPI_ and GPO_ prefixes corresponds to the different
flavours. Do they still need a common prefix? Ie. the GPI_REG_IN
has nothing to do with GPO_REG_OUT, nor has both something
to do with the GPIO_REG_IN and GPIO_REG_OUT. I could prefix them
with SL28CPLD_ though. But I don't know if that is what you had
in mind because then they would be SL28CPLD_GPIO_REG_IN and
SL28CPLD_GPI_REG_IN for example.
-michael
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael-QKn5cuLxLXY@public.gmane.org>
To: Bartosz Golaszewski
<bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
Cc: linux-gpio <linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-devicetree
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LINUXWATCHDOG
<linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
arm-soc
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"Linus Walleij"
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Jean Delvare" <jdelvare-IBi9RG/b67k@public.gmane.org>,
"Guenter Roeck" <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
"Lee Jones" <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Thierry Reding"
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Wim Van Sebroeck"
<wim-Q8PRGTgFL9WUCWQAtAn6Ix2eb7JE58TQ@public.gmane.org>,
"Shawn Guo" <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Li Yang" <leoyang.li-3arQi8VN3Tc@public.gmane.org>,
"Thomas Gleixner" <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
"Jason Cooper" <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
Subject: Re: [PATCH 12/18] gpio: add support for the sl28cpld GPIO controller
Date: Sat, 28 Mar 2020 13:04:50 +0100 [thread overview]
Message-ID: <ef10a6f07f093c282df7fe94057cc7c7@walle.cc> (raw)
In-Reply-To: <CAMpxmJW770v6JLdveEe1hkgNEJByVyArhorSyUZBYOyFiVyOeg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Bartosz,
Am 2020-03-18 10:14, schrieb Bartosz Golaszewski:
> wt., 17 mar 2020 o 21:50 Michael Walle <michael-QKn5cuLxLXY@public.gmane.org> napisał(a):
>>
>> This adds support for the GPIO controller of the sl28 board management
>> controller. This driver is part of a multi-function device.
>>
>> Signed-off-by: Michael Walle <michael-QKn5cuLxLXY@public.gmane.org>
>
> Hi Michael,
>
> thanks for the driver. Please take a look at some comments below.
>
>> ---
[..]
>> +#define GPIO_REG_DIR 0
>> +#define GPIO_REG_OUT 1
>> +#define GPIO_REG_IN 2
>> +#define GPIO_REG_IE 3
>> +#define GPIO_REG_IP 4
>
> These values would be more clear if they were defined as hex.
>
>> +
>> +#define GPI_REG_IN 0
>> +
>> +#define GPO_REG_OUT 0
>
> Please also use a common prefix even for defines.
The GPIO_, GPI_ and GPO_ prefixes corresponds to the different
flavours. Do they still need a common prefix? Ie. the GPI_REG_IN
has nothing to do with GPO_REG_OUT, nor has both something
to do with the GPIO_REG_IN and GPIO_REG_OUT. I could prefix them
with SL28CPLD_ though. But I don't know if that is what you had
in mind because then they would be SL28CPLD_GPIO_REG_IN and
SL28CPLD_GPI_REG_IN for example.
-michael
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org,
"Jean Delvare" <jdelvare@suse.com>,
"Marc Zyngier" <maz@kernel.org>,
LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
linux-devicetree <devicetree@vger.kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
"Li Yang" <leoyang.li@nxp.com>,
linux-gpio <linux-gpio@vger.kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Lee Jones" <lee.jones@linaro.org>,
arm-soc <linux-arm-kernel@lists.infradead.org>,
"Jason Cooper" <jason@lakedaemon.net>
Subject: Re: [PATCH 12/18] gpio: add support for the sl28cpld GPIO controller
Date: Sat, 28 Mar 2020 13:04:50 +0100 [thread overview]
Message-ID: <ef10a6f07f093c282df7fe94057cc7c7@walle.cc> (raw)
In-Reply-To: <CAMpxmJW770v6JLdveEe1hkgNEJByVyArhorSyUZBYOyFiVyOeg@mail.gmail.com>
Hi Bartosz,
Am 2020-03-18 10:14, schrieb Bartosz Golaszewski:
> wt., 17 mar 2020 o 21:50 Michael Walle <michael@walle.cc> napisał(a):
>>
>> This adds support for the GPIO controller of the sl28 board management
>> controller. This driver is part of a multi-function device.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>
> Hi Michael,
>
> thanks for the driver. Please take a look at some comments below.
>
>> ---
[..]
>> +#define GPIO_REG_DIR 0
>> +#define GPIO_REG_OUT 1
>> +#define GPIO_REG_IN 2
>> +#define GPIO_REG_IE 3
>> +#define GPIO_REG_IP 4
>
> These values would be more clear if they were defined as hex.
>
>> +
>> +#define GPI_REG_IN 0
>> +
>> +#define GPO_REG_OUT 0
>
> Please also use a common prefix even for defines.
The GPIO_, GPI_ and GPO_ prefixes corresponds to the different
flavours. Do they still need a common prefix? Ie. the GPI_REG_IN
has nothing to do with GPO_REG_OUT, nor has both something
to do with the GPIO_REG_IN and GPIO_REG_OUT. I could prefix them
with SL28CPLD_ though. But I don't know if that is what you had
in mind because then they would be SL28CPLD_GPIO_REG_IN and
SL28CPLD_GPI_REG_IN for example.
-michael
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-28 12:04 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 20:49 [PATCH 00/18] Add support for Kontron sl28cpld Michael Walle
2020-03-17 20:49 ` Michael Walle
2020-03-17 20:50 ` [PATCH 01/18] include/linux/ioport.h: add helper to define REG resource constructs Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` [PATCH 02/18] mfd: mfd-core: Don't overwrite the dma_mask of the child device Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` [PATCH 03/18] mfd: mfd-core: match device tree node against reg property Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` [PATCH 04/18] dt-bindings: mfd: Add bindings for sl28cpld Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-30 22:35 ` Rob Herring
2020-03-30 22:35 ` Rob Herring
2020-03-31 7:40 ` Michael Walle
2020-03-31 7:40 ` Michael Walle
2020-03-17 20:50 ` [PATCH 05/18] mfd: Add support for Kontron sl28cpld management controller Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-18 3:28 ` Guenter Roeck
2020-03-18 3:28 ` Guenter Roeck
2020-03-18 16:38 ` Michael Walle
2020-03-18 16:38 ` Michael Walle
2020-03-17 20:50 ` [PATCH 06/18] irqchip: add sl28cpld interrupt controller support Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-18 16:53 ` Guenter Roeck
2020-03-18 16:53 ` Guenter Roeck
2020-03-18 17:06 ` Michael Walle
2020-03-18 17:06 ` Michael Walle
2020-03-18 17:06 ` Michael Walle
2020-03-18 20:35 ` Guenter Roeck
2020-03-18 20:35 ` Guenter Roeck
2020-03-17 20:50 ` [PATCH 07/18] dt-bindings: watchdog: Add bindings for sl28cpld watchdog Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` [PATCH 08/18] watchdog: add support " Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-18 3:17 ` Guenter Roeck
2020-03-18 3:17 ` Guenter Roeck
2020-03-18 3:17 ` Guenter Roeck
2020-03-17 20:50 ` [PATCH 09/18] dt-bindings: pwm: Add bindings for sl28cpld PWM controller Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` [PATCH 10/18] pwm: add support " Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` [PATCH 11/18] dt-bindings: gpio: Add bindings for sl28cpld GPIO controller Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` [PATCH 12/18] gpio: add support for the " Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-18 9:14 ` Bartosz Golaszewski
2020-03-18 9:14 ` Bartosz Golaszewski
2020-03-18 9:14 ` Bartosz Golaszewski
2020-03-18 12:45 ` Michael Walle
2020-03-18 12:45 ` Michael Walle
2020-03-18 12:45 ` Michael Walle
2020-03-25 11:50 ` Bartosz Golaszewski
2020-03-25 11:50 ` Bartosz Golaszewski
2020-03-25 11:50 ` Bartosz Golaszewski
2020-03-26 20:05 ` Michael Walle
2020-03-26 20:05 ` Michael Walle
2020-03-26 20:05 ` Michael Walle
2020-03-27 10:20 ` Linus Walleij
2020-03-27 10:20 ` Linus Walleij
2020-03-27 10:20 ` Linus Walleij
2020-03-27 15:28 ` Michael Walle
2020-03-27 15:28 ` Michael Walle
2020-03-27 15:28 ` Michael Walle
2020-03-27 19:01 ` Linus Walleij
2020-03-27 19:01 ` Linus Walleij
2020-03-27 19:01 ` Linus Walleij
2020-03-30 11:21 ` Bartosz Golaszewski
2020-03-30 11:21 ` Bartosz Golaszewski
2020-03-30 11:21 ` Bartosz Golaszewski
2020-03-30 11:48 ` Michael Walle
2020-03-30 11:48 ` Michael Walle
2020-03-30 11:48 ` Michael Walle
2020-03-28 12:04 ` Michael Walle [this message]
2020-03-28 12:04 ` Michael Walle
2020-03-28 12:04 ` Michael Walle
2020-03-28 17:20 ` Michael Walle
2020-03-28 17:20 ` Michael Walle
2020-03-28 17:20 ` Michael Walle
2020-03-17 20:50 ` [PATCH 13/18] dt-bindings: hwmon: Add bindings for sl28cpld hardware monitoring Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` [PATCH 14/18] hwmon: add support for the sl28cpld hardware monitoring controller Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-18 3:27 ` Guenter Roeck
2020-03-18 3:27 ` Guenter Roeck
2020-03-18 3:27 ` Guenter Roeck
2020-03-18 16:32 ` Michael Walle
2020-03-18 16:32 ` Michael Walle
2020-03-17 20:50 ` [PATCH 15/18] arm64: dts: freescale: sl28: enable sl28cpld Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` [PATCH 16/18] arm64: dts: freescale: sl28: map GPIOs to input events Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` [PATCH 17/18] arm64: dts: freescale: sl28: enable LED support Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` Michael Walle
2020-03-17 20:50 ` [PATCH 18/18] arm64: dts: freescale: sl28: enable fan support Michael Walle
2020-03-17 20:50 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef10a6f07f093c282df7fe94057cc7c7@walle.cc \
--to=michael@walle.cc \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.