Re: [PATCH v2 1/5] dt-bindings: arm: uniphier: Add system controller bindings

From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Masami Hiramatsu <mhiramat@kernel.org>
Cc: soc@kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: arm: uniphier: Add system controller bindings
Date: Fri, 11 Nov 2022 17:49:05 +0900	[thread overview]
Message-ID: <f1c8a87c-b084-5496-d3e1-2c524e83e2a3@socionext.com> (raw)
In-Reply-To: <784c5975-661a-c71c-1489-229ada0a4e72@linaro.org>

On 2022/11/09 0:08, Krzysztof Kozlowski wrote:
> On 08/11/2022 15:30, Kunihiko Hayashi wrote:
>>>> +additionalProperties:
>>>> +  type: object
>>>
>>> No, instead you should describe the children. This must me
>>> additionalProperties: false
>>
>> Each controller has different children, so need to define children
>> for each controller using "if".
> 
> Then you should have different binding documents. Bindings should be
> specific.

I see. I'll separate this document into the specific documents.

Thank you,

---
Best Regards
Kunihiko Hayashi