From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, jank@cadence.com,
srinivas.kandagatla@linaro.org, rander.wang@linux.intel.com,
ranjani.sridharan@linux.intel.com, hui.wang@canonical.com,
sanyog.r.kale@intel.com, bard.liao@intel.com
Subject: Re: [PATCH 3/3] soundwire: bus: clear parity interrupt before the mask is enabled
Date: Mon, 1 Feb 2021 10:29:44 -0600 [thread overview]
Message-ID: <f5ef9a07-73df-c2b6-3e03-001f53700c5b@linux.intel.com> (raw)
In-Reply-To: <20210201110921.GZ2771@vkoul-mobl>
>> * Set SCP_INT1_MASK register, typically bus clash and
>> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
>> index f7ba1a77a1df..c1fdc85d0a74 100644
>> --- a/drivers/soundwire/intel.c
>> +++ b/drivers/soundwire/intel.c
>> @@ -1286,7 +1286,8 @@ static int sdw_master_read_intel_prop(struct sdw_bus *bus)
>> if (quirk_mask & SDW_INTEL_QUIRK_MASK_BUS_DISABLE)
>> prop->hw_disabled = true;
>>
>> - prop->quirks = SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH;
>> + prop->quirks = SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH |
>> + SDW_MASTER_QUIRKS_CLEAR_INITIAL_PARITY;
>
> move this to intel patch please..
>
>>
>> return 0;
>> }
>> diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
>> index a2766c3b603d..30415354d419 100644
>> --- a/include/linux/soundwire/sdw.h
>> +++ b/include/linux/soundwire/sdw.h
>> @@ -426,6 +426,7 @@ struct sdw_master_prop {
>> };
>>
>> #define SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH BIT(0)
>> +#define SDW_MASTER_QUIRKS_CLEAR_INITIAL_PARITY BIT(1)
>
> Why not add this quirk in patch 1..?
There is an element of history here. We first found out about the bus
clash on multiple devices and dealt with a specific bug number. Then we
spend weeks on the parity issue on a new platform and ultimately showed
we needed a similar work-around.
All these problems are not typical from a user perspective; they appear
when loading/unloading modules in loops, at some point it seems some
hardware devices don't always reset properly or there's something
problematic in power delivery.
I don't think it's an issue if we refactor the code to add the quirks
first, and add the intel.c patches later. We probably want 2 intel
changes to keep the references to the bugs though and the detailed
explanations.
> Also add comments about each quirk, hopefully it wont be a big table
Sounds fine.
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, ranjani.sridharan@linux.intel.com,
hui.wang@canonical.com, srinivas.kandagatla@linaro.org,
jank@cadence.com, sanyog.r.kale@intel.com,
rander.wang@linux.intel.com, bard.liao@intel.com
Subject: Re: [PATCH 3/3] soundwire: bus: clear parity interrupt before the mask is enabled
Date: Mon, 1 Feb 2021 10:29:44 -0600 [thread overview]
Message-ID: <f5ef9a07-73df-c2b6-3e03-001f53700c5b@linux.intel.com> (raw)
In-Reply-To: <20210201110921.GZ2771@vkoul-mobl>
>> * Set SCP_INT1_MASK register, typically bus clash and
>> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
>> index f7ba1a77a1df..c1fdc85d0a74 100644
>> --- a/drivers/soundwire/intel.c
>> +++ b/drivers/soundwire/intel.c
>> @@ -1286,7 +1286,8 @@ static int sdw_master_read_intel_prop(struct sdw_bus *bus)
>> if (quirk_mask & SDW_INTEL_QUIRK_MASK_BUS_DISABLE)
>> prop->hw_disabled = true;
>>
>> - prop->quirks = SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH;
>> + prop->quirks = SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH |
>> + SDW_MASTER_QUIRKS_CLEAR_INITIAL_PARITY;
>
> move this to intel patch please..
>
>>
>> return 0;
>> }
>> diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
>> index a2766c3b603d..30415354d419 100644
>> --- a/include/linux/soundwire/sdw.h
>> +++ b/include/linux/soundwire/sdw.h
>> @@ -426,6 +426,7 @@ struct sdw_master_prop {
>> };
>>
>> #define SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH BIT(0)
>> +#define SDW_MASTER_QUIRKS_CLEAR_INITIAL_PARITY BIT(1)
>
> Why not add this quirk in patch 1..?
There is an element of history here. We first found out about the bus
clash on multiple devices and dealt with a specific bug number. Then we
spend weeks on the parity issue on a new platform and ultimately showed
we needed a similar work-around.
All these problems are not typical from a user perspective; they appear
when loading/unloading modules in loops, at some point it seems some
hardware devices don't always reset properly or there's something
problematic in power delivery.
I don't think it's an issue if we refactor the code to add the quirks
first, and add the intel.c patches later. We probably want 2 intel
changes to keep the references to the bugs though and the detailed
explanations.
> Also add comments about each quirk, hopefully it wont be a big table
Sounds fine.
next prev parent reply other threads:[~2021-02-01 18:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 8:37 [PATCH 0/3] soundwire: clear bus clash/parity interrupt before the mask is enabled Bard Liao
2021-01-26 8:37 ` Bard Liao
2021-01-26 8:37 ` [PATCH 1/3] soundwire: bus: clear bus clash " Bard Liao
2021-01-26 8:37 ` Bard Liao
2021-02-01 10:28 ` Vinod Koul
2021-02-01 10:28 ` Vinod Koul
2021-02-01 10:38 ` Vinod Koul
2021-02-01 10:38 ` Vinod Koul
2021-02-01 16:18 ` Pierre-Louis Bossart
2021-02-02 4:39 ` Vinod Koul
2021-02-02 4:39 ` Vinod Koul
2021-02-02 16:52 ` Pierre-Louis Bossart
2021-02-02 16:52 ` Pierre-Louis Bossart
2021-02-03 11:03 ` Vinod Koul
2021-02-03 11:03 ` Vinod Koul
2021-01-26 8:37 ` [PATCH 2/3] soundwire: intel: add SDW_MASTER_QUIRKS_CLEAR_INITIAL_CLASH quirk Bard Liao
2021-01-26 8:37 ` Bard Liao
2021-02-01 10:42 ` Vinod Koul
2021-02-01 10:42 ` Vinod Koul
2021-02-01 16:20 ` Pierre-Louis Bossart
2021-02-02 4:41 ` Vinod Koul
2021-02-02 4:41 ` Vinod Koul
2021-02-02 16:53 ` Pierre-Louis Bossart
2021-01-26 8:37 ` [PATCH 3/3] soundwire: bus: clear parity interrupt before the mask is enabled Bard Liao
2021-01-26 8:37 ` Bard Liao
2021-02-01 11:09 ` Vinod Koul
2021-02-01 11:09 ` Vinod Koul
2021-02-01 16:29 ` Pierre-Louis Bossart [this message]
2021-02-01 16:29 ` Pierre-Louis Bossart
2021-02-02 4:44 ` Vinod Koul
2021-02-02 4:44 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5ef9a07-73df-c2b6-3e03-001f53700c5b@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.