* [PATCH] generic/530: Require metadata journaling
@ 2020-07-09 9:57 Jan Kara
2020-07-09 19:13 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kara @ 2020-07-09 9:57 UTC (permalink / raw)
To: fstests; +Cc: linux-ext4, Jan Kara
Test generic/530 doesn't make sence without metadata journalling as in
that case, there's no way to recover shutdown fs besides fsck. ext4
can be configured without a journal and it supports shutdown ioctl even
in that mode which makes this test fail for that configuration. Add
requirement for metadata journalling to this test so that it's properly
skipped.
Signed-off-by: Jan Kara <jack@suse.cz>
---
tests/generic/530 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/generic/530 b/tests/generic/530
index cb874ace902b..153a045dca87 100755
--- a/tests/generic/530
+++ b/tests/generic/530
@@ -33,6 +33,7 @@ _supported_fs generic
_supported_os Linux
_require_scratch
_require_scratch_shutdown
+_require_metadata_journaling
_require_test_program "t_open_tmpfiles"
rm -f $seqres.full
--
2.16.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] generic/530: Require metadata journaling
2020-07-09 9:57 [PATCH] generic/530: Require metadata journaling Jan Kara
@ 2020-07-09 19:13 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2020-07-09 19:13 UTC (permalink / raw)
To: Jan Kara; +Cc: fstests, linux-ext4
On Thu, Jul 09, 2020 at 11:57:53AM +0200, Jan Kara wrote:
> Test generic/530 doesn't make sence without metadata journalling as in
> that case, there's no way to recover shutdown fs besides fsck. ext4
> can be configured without a journal and it supports shutdown ioctl even
> in that mode which makes this test fail for that configuration. Add
> requirement for metadata journalling to this test so that it's properly
> skipped.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
<shudder> Right, I forgot about that...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/generic/530 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/530 b/tests/generic/530
> index cb874ace902b..153a045dca87 100755
> --- a/tests/generic/530
> +++ b/tests/generic/530
> @@ -33,6 +33,7 @@ _supported_fs generic
> _supported_os Linux
> _require_scratch
> _require_scratch_shutdown
> +_require_metadata_journaling
> _require_test_program "t_open_tmpfiles"
>
> rm -f $seqres.full
> --
> 2.16.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-09 19:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09 9:57 [PATCH] generic/530: Require metadata journaling Jan Kara
2020-07-09 19:13 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).