From: Christian Brauner <christian.brauner@ubuntu.com>
To: Eryu Guan <guan@eryu.me>
Cc: Christian Brauner <brauner@kernel.org>,
fstests@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Darrick J . Wong" <djwong@kernel.org>,
David Howells <dhowells@redhat.com>,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH v12 2/6] generic/632: add fstests for idmapped mounts
Date: Sun, 11 Apr 2021 17:18:57 +0200 [thread overview]
Message-ID: <20210411151857.wd6gd46u53vlh2xv@wittgenstein> (raw)
In-Reply-To: <20210411151249.6y34x7yatqtpcvi6@wittgenstein>
On Sun, Apr 11, 2021 at 05:12:49PM +0200, Christian Brauner wrote:
> On Sun, Apr 11, 2021 at 10:30:20PM +0800, Eryu Guan wrote:
> > On Mon, Mar 29, 2021 at 12:33:56AM +0200, Christian Brauner wrote:
> > > From: Christian Brauner <christian.brauner@ubuntu.com>
> > >
> > > Add a test suite to verify the behavior of idmapped mounts. The test
> > > suite also includes a range of vfs tests to verify that no regressions
> > > are introduced by idmapped mounts. The following tests are currently
> > > available with more to come in the future:
> > >
> > > 01. posix acls on regular and idmapped mounts
> >
> > I'm getting failures like below when testing on btrfs and overlayfs
> >
> > [root@fedoravm xfstests]# diff -u
> > /root/workspace/xfstests/tests/generic/633.out /root/workspace/xfstests/results//btrfs/generic/633.out.bad
> > --- /root/workspace/xfstests/tests/generic/633.out 2021-04-11 22:18: 24.458518716 +0800
> > +++ /root/workspace/xfstests/results//btrfs/generic/633.out.bad 2021-04-11 22:19:58.887980770 +0800
> > @@ -1,2 +1,4 @@
> > QA output created by 633
> > Silence is golden
> > +idmapped-mounts.c: 6622: acls - Invalid argument - failure: sys_mount_setattr
> > +failure: posix acls on regular mounts
> >
> > Is this a known issue or test needs some fix?
>
> Ah, this is very likely just the getfacl command missing which is part
> of the "acl" package, at least on Ubuntu.
And it should actually skip the tests on all filesystems that don't
support idmapped mounts which is every fs apart from xfs and ext4.
Christian
next prev parent reply other threads:[~2021-04-11 15:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 22:33 [PATCH v12 0/6] fstests: add idmapped mounts tests Christian Brauner
2021-03-28 22:33 ` [PATCH v12 1/6] generic/631: add test for detached mount propagation Christian Brauner
2021-03-28 22:33 ` [PATCH v12 3/6] common/rc: add _scratch_{u}mount_idmapped() helpers Christian Brauner
2021-03-28 22:33 ` [PATCH v12 4/6] common/quota: move _qsetup() helper to common code Christian Brauner
2021-03-28 22:33 ` [PATCH v12 5/6] xfs/529: quotas and idmapped mounts Christian Brauner
2021-03-28 22:34 ` [PATCH v12 6/6] xfs/530: quotas on " Christian Brauner
[not found] ` <20210328223400.1800301-3-brauner@kernel.org>
2021-04-11 14:30 ` [PATCH v12 2/6] generic/632: add fstests for " Eryu Guan
2021-04-11 15:12 ` Christian Brauner
2021-04-11 15:18 ` Christian Brauner [this message]
2021-04-11 15:21 ` Eryu Guan
2021-04-11 15:32 ` Christian Brauner
2021-04-12 0:40 ` Theodore Ts'o
2021-04-12 11:54 ` Christian Brauner
2021-04-12 22:41 ` Theodore Ts'o
2021-04-14 20:47 ` [PATCH -RFC] ext4: add feature file to advertise that ext4 supports " Theodore Ts'o
2021-04-15 5:54 ` Christoph Hellwig
2021-04-15 7:49 ` Christian Brauner
2021-04-15 7:55 ` Christoph Hellwig
2021-04-15 8:13 ` Christian Brauner
2021-04-15 14:59 ` Theodore Ts'o
2021-04-12 7:22 ` [PATCH v12 2/6] generic/632: add fstests for " Christoph Hellwig
2021-04-12 7:30 ` Christian Brauner
2021-04-11 15:19 ` Eryu Guan
2021-04-11 14:37 ` [PATCH v12 0/6] fstests: add idmapped mounts tests Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210411151857.wd6gd46u53vlh2xv@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).