From: Christoph Hellwig <hch@lst.de>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Christian Brauner <christian.brauner@ubuntu.com>,
Eryu Guan <guan@eryu.me>, Christian Brauner <brauner@kernel.org>,
fstests@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
linux-ext4@vger.kernel.org,
"Darrick J . Wong" <djwong@kernel.org>,
David Howells <dhowells@redhat.com>,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH -RFC] ext4: add feature file to advertise that ext4 supports idmapped mounts
Date: Thu, 15 Apr 2021 07:54:08 +0200 [thread overview]
Message-ID: <20210415055408.GA8947@lst.de> (raw)
In-Reply-To: <YHdUzqZ7PZtb64zf@mit.edu>
On Wed, Apr 14, 2021 at 04:47:10PM -0400, Theodore Ts'o wrote:
> On Mon, Apr 12, 2021 at 06:41:20PM -0400, Theodore Ts'o wrote:
> > In the ideal world, if the kernel wasn't compiled with the necessary
> > CONFIG options enabled, it's desirable of the test can detect that
> > fact and skip running the test instead failing and forcing the person
> > running the test to try to figure out whether this is a legitmate file
> > system bug or a just a test setup bug.
>
> So it would make it easier for me to manage running xfstests on ext4
> if I had added something like this to ext4 and sent it to Linus before
> v5.12 is released. What do folks think?
Completely stupid. This is a VFS-level feature and we need to have
proper VFS-level testing (which we have through creating a mount
with the option), not fs-specific band aids.
next prev parent reply other threads:[~2021-04-15 5:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 22:33 [PATCH v12 0/6] fstests: add idmapped mounts tests Christian Brauner
2021-03-28 22:33 ` [PATCH v12 1/6] generic/631: add test for detached mount propagation Christian Brauner
2021-03-28 22:33 ` [PATCH v12 3/6] common/rc: add _scratch_{u}mount_idmapped() helpers Christian Brauner
2021-03-28 22:33 ` [PATCH v12 4/6] common/quota: move _qsetup() helper to common code Christian Brauner
2021-03-28 22:33 ` [PATCH v12 5/6] xfs/529: quotas and idmapped mounts Christian Brauner
2021-03-28 22:34 ` [PATCH v12 6/6] xfs/530: quotas on " Christian Brauner
[not found] ` <20210328223400.1800301-3-brauner@kernel.org>
2021-04-11 14:30 ` [PATCH v12 2/6] generic/632: add fstests for " Eryu Guan
2021-04-11 15:12 ` Christian Brauner
2021-04-11 15:18 ` Christian Brauner
2021-04-11 15:21 ` Eryu Guan
2021-04-11 15:32 ` Christian Brauner
2021-04-12 0:40 ` Theodore Ts'o
2021-04-12 11:54 ` Christian Brauner
2021-04-12 22:41 ` Theodore Ts'o
2021-04-14 20:47 ` [PATCH -RFC] ext4: add feature file to advertise that ext4 supports " Theodore Ts'o
2021-04-15 5:54 ` Christoph Hellwig [this message]
2021-04-15 7:49 ` Christian Brauner
2021-04-15 7:55 ` Christoph Hellwig
2021-04-15 8:13 ` Christian Brauner
2021-04-15 14:59 ` Theodore Ts'o
2021-04-12 7:22 ` [PATCH v12 2/6] generic/632: add fstests for " Christoph Hellwig
2021-04-12 7:30 ` Christian Brauner
2021-04-11 15:19 ` Eryu Guan
2021-04-11 14:37 ` [PATCH v12 0/6] fstests: add idmapped mounts tests Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415055408.GA8947@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).