FSTests Archive on lore.kernel.org
 help / color / Atom feed
* shared/032: add options for reiser4
@ 2020-01-31 20:55 Christian Kujau
  2020-02-17 12:47 ` Eryu Guan
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Kujau @ 2020-01-31 20:55 UTC (permalink / raw)
  To: fstests

Last night I had xfstests running and after a while it hung at shared/032 
because I had reiser4progs installed and it was waiting for input:

-----------------------------------------------------------------
mkfs -t reiser4 /dev/ram0
mkfs.reiser4 1.2.1
Format release: 4.0.2
Copyright (C) 2001-2005 by Hans Reiser, licensing governed by 
reiser4progs/COPYING. 

Block size 4096 will be used.                                                                                                                                                                         
Linux 5.5.0-rc5-amd64 is detected.                                                                                                                                                                    
Uuid 2006a590-832a-49f5-9317-cf91bf866dd7 will be used.                                                                                                                                               
Reiser4 is going to be created on /dev/ram0.                                                                                                                                                          
(Yes/No): 
-----------------------------------------------------------------

The patch below adds an option (cf. reiserfs the line above) so that the 
test continues.

Curiously enough the test still "succeeds" for reiser{fs,4} (and jfs too) 
because the userspace tools don't appear to have a routine to check for 
"contains an existing filesystem", but that could be addressed in a 
different patch.

Signed-off-by: Christian Kujau <lists@nerdbynature.de>

--- tests/shared/032.orig	2020-01-12 08:43:34.000000000 -0800
+++ tests/shared/032	2020-01-31 12:30:27.158763104 -0800
@@ -49,6 +49,7 @@
 	[ $fs = gfs ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
 	[ $fs = gfs2 ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
 	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
+	[ $fs = reiser4 ] && preop="echo y |" && preargs="-f"
 	# cramfs mkfs requires a directory argument
 	[ $fs = cramfs ] && preargs=/proc/fs
 	[ $fs = ext2 ] && preargs="-F"

-- 
BOFH excuse #164:

root rot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: shared/032: add options for reiser4
  2020-01-31 20:55 shared/032: add options for reiser4 Christian Kujau
@ 2020-02-17 12:47 ` Eryu Guan
  2020-02-19  0:29   ` Christian Kujau
  0 siblings, 1 reply; 3+ messages in thread
From: Eryu Guan @ 2020-02-17 12:47 UTC (permalink / raw)
  To: Christian Kujau; +Cc: fstests

On Fri, Jan 31, 2020 at 12:55:47PM -0800, Christian Kujau wrote:
> Last night I had xfstests running and after a while it hung at shared/032 
> because I had reiser4progs installed and it was waiting for input:
> 
> -----------------------------------------------------------------
> mkfs -t reiser4 /dev/ram0
> mkfs.reiser4 1.2.1
> Format release: 4.0.2
> Copyright (C) 2001-2005 by Hans Reiser, licensing governed by 
> reiser4progs/COPYING. 
> 
> Block size 4096 will be used.                                                                                                                                                                         
> Linux 5.5.0-rc5-amd64 is detected.                                                                                                                                                                    
> Uuid 2006a590-832a-49f5-9317-cf91bf866dd7 will be used.                                                                                                                                               
> Reiser4 is going to be created on /dev/ram0.                                                                                                                                                          
> (Yes/No): 
> -----------------------------------------------------------------
> 
> The patch below adds an option (cf. reiserfs the line above) so that the 
> test continues.
> 
> Curiously enough the test still "succeeds" for reiser{fs,4} (and jfs too) 
> because the userspace tools don't appear to have a routine to check for 
> "contains an existing filesystem", but that could be addressed in a 
> different patch.
> 
> Signed-off-by: Christian Kujau <lists@nerdbynature.de>

Thanks for the patch! But This patch cannot be applied, seems the format
is wrong.

But it's easy enough to apply manually, just please make sure the patch
format is correct next time.

Thanks,
Eryu

> 
> --- tests/shared/032.orig	2020-01-12 08:43:34.000000000 -0800
> +++ tests/shared/032	2020-01-31 12:30:27.158763104 -0800
> @@ -49,6 +49,7 @@
>  	[ $fs = gfs ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
>  	[ $fs = gfs2 ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
>  	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
> +	[ $fs = reiser4 ] && preop="echo y |" && preargs="-f"
>  	# cramfs mkfs requires a directory argument
>  	[ $fs = cramfs ] && preargs=/proc/fs
>  	[ $fs = ext2 ] && preargs="-F"
> 
> -- 
> BOFH excuse #164:
> 
> root rot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: shared/032: add options for reiser4
  2020-02-17 12:47 ` Eryu Guan
@ 2020-02-19  0:29   ` Christian Kujau
  0 siblings, 0 replies; 3+ messages in thread
From: Christian Kujau @ 2020-02-19  0:29 UTC (permalink / raw)
  To: Eryu Guan; +Cc: fstests

On Mon, 17 Feb 2020, Eryu Guan wrote:
> Thanks for the patch! But This patch cannot be applied, seems the format
> is wrong.

Weird, I thought I double checked and test-applied it again to my checkout 
of xfstests-dev, but apparently not :(

> But it's easy enough to apply manually, just please make sure the patch
> format is correct next time.

OK, thanks for taking the time review this, and sorry for the garbled 
patch.

Christian.

-- 
BOFH excuse #70:

nesting roaches shorted out the ether cable

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-31 20:55 shared/032: add options for reiser4 Christian Kujau
2020-02-17 12:47 ` Eryu Guan
2020-02-19  0:29   ` Christian Kujau

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git