From: Philip Oakley <philipoakley@iee.email>
To: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>,
Alexandr Miloslavskiy via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/1] contrib/buildsystems: fix Visual Studio Debug configuration
Date: Sun, 1 Dec 2019 23:41:52 +0000 [thread overview]
Message-ID: <021de37a-5317-6c96-eae3-d0228a193d8b@iee.email> (raw)
In-Reply-To: <0b2124b5-6d40-08bb-6cc5-a8cef2b7a9b1@syntevo.com>
On 28/11/2019 10:07, Alexandr Miloslavskiy wrote:
> On 28.11.2019 1:34, Philip Oakley wrote:
>
>> Hmm, 45 minutes of cloning and rebuild, but finally it compiled clean
>> (both Release and Debug)
>
> I understand that the issue is resolved now.
>
> Probably your old repo was missing the libraries for whatever reason
> (like antivirus deleting them, etc), but build script thought that
> dependencies are properly built, so didn't attempt to rebuild them.
I was searching for how Visual Studio managed to decide if the vcpkg
needed installing. I think I've found it in 384a61bc6a
("contrib/buildsystems: add a backend for modern Visual Studio
versions", 2019-07-29) where dscho says:
we initialize the `vcpkg` conditionally, in the `libgit` project's
`PreBuildEvent`. To allow for parallel building of the projects, we
therefore put `libgit` at the bottom of the project hierarchy.
What's not clear is if the conditional pre-build can have an if-else
option so that we can have an 'update' check if already installed.
Adding the vcpkg update to the vcpkg_install.bat didn't work :-(
Philip
PS. the https://github.com/CoatiSoftware/Sourcetrail visualiser is
looking nice.
prev parent reply other threads:[~2019-12-01 23:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 8:28 [PATCH 0/1] contrib/buildsystems: fix Visual Studio Debug configuration Alexandr Miloslavskiy via GitGitGadget
2019-09-23 8:28 ` [PATCH 1/1] " Alexandr Miloslavskiy via GitGitGadget
2019-09-24 14:17 ` Alexandr Miloslavskiy
2019-09-25 15:20 ` Johannes Schindelin
2019-11-27 17:56 ` Philip Oakley
2019-11-27 18:59 ` Alexandr Miloslavskiy
2019-11-27 21:42 ` Philip Oakley
2019-11-28 0:34 ` Philip Oakley
2019-11-28 10:07 ` Alexandr Miloslavskiy
2019-11-29 11:53 ` Philip Oakley
2019-11-29 13:19 ` Philip Oakley
2019-12-01 23:41 ` Philip Oakley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=021de37a-5317-6c96-eae3-d0228a193d8b@iee.email \
--to=philipoakley@iee.email \
--cc=alexandr.miloslavskiy@syntevo.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).