Re: [PATCH 1/1] contrib/buildsystems: fix Visual Studio Debug configuration

From: Philip Oakley <philipoakley@iee.email>
To: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>,
	Alexandr Miloslavskiy via GitGitGadget  <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/1] contrib/buildsystems: fix Visual Studio Debug configuration
Date: Wed, 27 Nov 2019 21:42:23 +0000	[thread overview]
Message-ID: <e011e16d-7832-9f3c-78c2-004d3ffbe64d@iee.email> (raw)
In-Reply-To: <8e7ff0b2-9f62-8ec6-5316-eb9cee25024e@syntevo.com>

Hi Alexandr,

On 27/11/2019 18:59, Alexandr Miloslavskiy wrote:
> On 27.11.2019 18:56, Philip Oakley wrote:
>> I just bumped against a potential issue like this. I was test 
>> compiling [1a,b] the `vs/master` branch from Git-For-Windows and got 
>> the LINK error that the 'libcurl-d.lib' was not found (4 places).
>>
>> Error    LNK1104    cannot open file 'libcurl-d.lib' git-imap-send 
>> C:\git-sdk-64\usr\src\git\git-imap-send\ LINK    1
>>
>> Having just located this email, I changed the build type to 'Release' 
>> and the errors disappeared.
>>
>> Do we also need to identify where the libcurl-d.lib will be found? 
>> i.e. is it something that needs including via the sdk pacman list (I 
>> think I'm up to date but maybe not..)
>>
>> A quick web search didn't show any hits for `libcurl-d.lib` (with the 
>> dash `-`), though did find a few for `libcurld.lib`.
>
> If you clone `git-for-windows` and build in VS using `git.sln`, it 
> will automatically clone `git-for-windows\compat\vcbuild\vcpkg` and 
> build various things there, resulting in
>
> `git-for-windows\compat\vcbuild\vcpkg\buildtrees\curl\x64-windows-dbg\lib\libcurl-d.dll` 
>
>
> `git-for-windows\compat\vcbuild\vcpkg\installed\x64-windows\debug\bin\libcurl-d.dll` 
>
>
> `git-for-windows\compat\vcbuild\vcpkg\packages\curl_x64-windows\debug\bin\libcurl-d.dll` 
>
>
> Which will be picked up by solution to build git.
>
> I have built Debug many times now and didn't have any issues. If you 
> do, I would suggest to clone a new copy and build it.

I already have the clone of vcpkg from 30/03/2019 with those three files 
already present. Have they been updated since then?

The error report is specifically that the .lib file is missing (which I 
can't find..)

However the plain `libcurl.lib` is present with matching dll's. It just 
feels a little unusual.

On a side note there's a few (not many) Stackoverflow questions about 
building libcurl-d.lib, but they feel almost tangential
https://stackoverflow.com/questions/51418238/libcurl-a-debug-lib-libcurl-a-lib-are-generated-instead-of-libcurld-lib-libcur
https://stackoverflow.com/questions/37126943/libcurld-dll-is-missing-from-your-computer-adding-libcurl-to-visual-studio-pr

quick look..
not sure if the assertion about choosing "ONE" (of debug/release) in 
https://github.com/git-for-windows/git/blob/master/compat/vcbuild/README#L26-L30 
is part of the issue.
That README doesn't really cover the update method for the vcpkg 
repository. It presumes you start from a fresh clone, which can be slow.
I fetched/pulled the vcpkg repoo but no sign of an update.

Philip