From: "Alexandr Miloslavskiy via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/1] contrib/buildsystems: fix Visual Studio Debug configuration
Date: Mon, 23 Sep 2019 01:28:34 -0700 (PDT) [thread overview]
Message-ID: <pull.348.git.gitgitgadget@gmail.com> (raw)
Even though Debug configuration builds, the resulting build is incorrect in
a subtle way: it mixes up Debug and Release binaries, which in turn causes
hard-to-predict bugs.
In my case, when git calls iconv library, iconv sets 'errno' and git then
tests it, but in Debug and Release CRT those 'errno' are different memory
locations.
This patch addresses 3 connected bugs: 1) Typo in '(Configuration)'. As a
result, Debug configuration condition is always false and Release path is
taken instead. 2) Regexp that replaced 'zlib.lib' with 'zlibd.lib' was only
affecting the first occurrence. However, some projects have it listed twice.
Previously this bug was hidden, because Debug path was never taken. I
decided that avoiding double -lz in makefile is fragile and I'd better
replace all occurrences instead. 3) In Debug, 'libcurl-d.lib' should be used
instead of 'libcurl.lib'. Previously this bug was hidden, because Debug path
was never taken.
Signed-off-by: Alexandr Miloslavskiy alexandr.miloslavskiy@syntevo.com
[alexandr.miloslavskiy@syntevo.com]
Alexandr Miloslavskiy (1):
contrib/buildsystems: fix Visual Studio Debug configuration
contrib/buildsystems/Generators/Vcxproj.pm | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
base-commit: 4c86140027f4a0d2caaa3ab4bd8bfc5ce3c11c8a
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-348%2FSyntevoAlex%2F%230188_VisualStudio_Debug_build_fixes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-348/SyntevoAlex/#0188_VisualStudio_Debug_build_fixes-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/348
--
gitgitgadget
next reply other threads:[~2019-09-23 8:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 8:28 Alexandr Miloslavskiy via GitGitGadget [this message]
2019-09-23 8:28 ` [PATCH 1/1] contrib/buildsystems: fix Visual Studio Debug configuration Alexandr Miloslavskiy via GitGitGadget
2019-09-24 14:17 ` Alexandr Miloslavskiy
2019-09-25 15:20 ` Johannes Schindelin
2019-11-27 17:56 ` Philip Oakley
2019-11-27 18:59 ` Alexandr Miloslavskiy
2019-11-27 21:42 ` Philip Oakley
2019-11-28 0:34 ` Philip Oakley
2019-11-28 10:07 ` Alexandr Miloslavskiy
2019-11-29 11:53 ` Philip Oakley
2019-11-29 13:19 ` Philip Oakley
2019-12-01 23:41 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.348.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).