* [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out
@ 2008-03-13 6:10 Christian Couder
2008-03-13 6:22 ` Junio C Hamano
2008-03-14 1:00 ` Xavier Maillard
0 siblings, 2 replies; 3+ messages in thread
From: Christian Couder @ 2008-03-13 6:10 UTC (permalink / raw)
To: Junio Hamano, Pascal Obry, Xavier Maillard; +Cc: git
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
help.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
This was suggested by Xavier Maillard.
diff --git a/help.c b/help.c
index 5da8c9c..ecaca77 100644
--- a/help.c
+++ b/help.c
@@ -139,7 +139,7 @@ static int add_man_viewer(const char *value)
else if (!strcasecmp(value, "konqueror"))
do_add_man_viewer(exec_man_konqueror);
else
- return error("'%s': unsupported man viewer.", value);
+ warning("'%s': unsupported man viewer.", value);
return 0;
}
--
1.5.4.3.395.g492b.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out
2008-03-13 6:10 [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out Christian Couder
@ 2008-03-13 6:22 ` Junio C Hamano
2008-03-14 1:00 ` Xavier Maillard
1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2008-03-13 6:22 UTC (permalink / raw)
To: Christian Couder
Cc: Pascal Obry, Xavier Maillard,
=?iso-2022-jp?B?GyRCJDckaSQkJDckSiRKJDMbKEIs?=,
git
Christian Couder <chriscool@tuxfamily.org> writes:
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
> help.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> This was suggested by Xavier Maillard.
>
> diff --git a/help.c b/help.c
> index 5da8c9c..ecaca77 100644
> --- a/help.c
> +++ b/help.c
> @@ -139,7 +139,7 @@ static int add_man_viewer(const char *value)
> else if (!strcasecmp(value, "konqueror"))
> do_add_man_viewer(exec_man_konqueror);
> else
> - return error("'%s': unsupported man viewer.", value);
> + warning("'%s': unsupported man viewer.", value);
>
> return 0;
> }
While I'd agree this is a good change, the author should justify it in the
commit log message. I ask list regulars like you to set a good example
for others.
When a document viewer that is unknown to the current version of
git is specified in the .git/config file, instead of erroring out
the process completely, just issue a warning. It might be that
the user usually is using a newer git that supports it (and the
configuration is written for that version) but is temporarily
using an older git that does not know the viewer.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out
2008-03-13 6:10 [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out Christian Couder
2008-03-13 6:22 ` Junio C Hamano
@ 2008-03-14 1:00 ` Xavier Maillard
1 sibling, 0 replies; 3+ messages in thread
From: Xavier Maillard @ 2008-03-14 1:00 UTC (permalink / raw)
To: Christian Couder; +Cc: junkio, pascal, nanako3, git
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
It's perfect. Thank you Christian.
Tested-by: Xavier Maillard <xma@gnu.org>
Xavier
--
http://www.gnu.org
http://www.april.org
http://www.lolica.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-14 1:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-13 6:10 [PATCH] help: warn if specified 'man.viewer' is unsupported, instead of erroring out Christian Couder
2008-03-13 6:22 ` Junio C Hamano
2008-03-14 1:00 ` Xavier Maillard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).