From: Heiko Voigt <hvoigt@hvoigt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: [PATCH] lessen the impression of unexpectedness on remote hangup
Date: Sun, 10 Jun 2012 20:23:10 +0200 [thread overview]
Message-ID: <20120610182310.GB2427@book.hvoigt.net> (raw)
If a server accessed through ssh is denying access git will currently
issue the message
"fatal: The remote end hung up unexpectedly"
as the last line. This sounds as if something really ugly just happened.
Since this is a quite typical situation in which users regularly get
lets just say:
"fatal: The remote end hung up"
Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
We just got this bug report in msysgit
https://github.com/msysgit/msysgit/issues/28
and IIRC there have been more people questioning that line.
pkt-line.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkt-line.c b/pkt-line.c
index 5a04984..d2b8267 100644
--- a/pkt-line.c
+++ b/pkt-line.c
@@ -141,7 +141,7 @@ static void safe_read(int fd, void *buffer, unsigned size)
if (ret < 0)
die_errno("read error");
else if (ret < size)
- die("The remote end hung up unexpectedly");
+ die("The remote end hung up");
}
static int packet_length(const char *linelen)
--
1.7.11.rc2.3.g15e800d
next reply other threads:[~2012-06-10 18:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-10 18:23 Heiko Voigt [this message]
2012-06-10 18:44 ` [PATCH] lessen the impression of unexpectedness on remote hangup Jonathan Nieder
2012-06-11 16:41 ` Junio C Hamano
2012-06-11 19:02 ` Jeff King
2012-06-13 21:28 ` Heiko Voigt
2012-06-14 7:13 ` [PATCH] remove the impression of unexpectedness when access is denied Heiko Voigt
2012-06-14 7:39 ` Heiko Voigt
2012-06-14 17:11 ` Junio C Hamano
2012-06-14 20:37 ` Heiko Voigt
2012-06-19 18:24 ` [PATCH v2] " Heiko Voigt
2013-05-04 3:10 ` Jonathan Nieder
2013-05-06 14:02 ` Junio C Hamano
2013-05-07 18:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120610182310.GB2427@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).