git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] lessen the impression of unexpectedness on remote hangup
Date: Mon, 11 Jun 2012 09:41:42 -0700	[thread overview]
Message-ID: <7vmx497qd5.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120610182310.GB2427@book.hvoigt.net> (Heiko Voigt's message of "Sun, 10 Jun 2012 20:23:10 +0200")

Heiko Voigt <hvoigt@hvoigt.net> writes:

> If a server accessed through ssh is denying access git will currently
> issue the message
>
> 	"fatal: The remote end hung up unexpectedly"
>
> as the last line. This sounds as if something really ugly just happened.
> Since this is a quite typical situation in which users regularly get
> lets just say:
>
> 	"fatal: The remote end hung up"
>
> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> ---

This change makes sense, but you would need to adjust tests for the
change, perhaps at least these:

 t/t5512-ls-remote.sh    | 2 +-
 t/t5522-pull-symlink.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t5512-ls-remote.sh b/t/t5512-ls-remote.sh
index 5c546c9..a24eb42 100755
--- a/t/t5512-ls-remote.sh
+++ b/t/t5512-ls-remote.sh
@@ -104,7 +104,7 @@ test_expect_success 'use branch.<name>.remote if possible' '
 
 cat >exp <<EOF
 fatal: 'refs*master' does not appear to be a git repository
-fatal: The remote end hung up unexpectedly
+fatal: The remote end hung up
 EOF
 test_expect_success 'confuses pattern as remote when no remote specified' '
 	#
diff --git a/t/t5522-pull-symlink.sh b/t/t5522-pull-symlink.sh
index 8e9b204..f06ffb4 100755
--- a/t/t5522-pull-symlink.sh
+++ b/t/t5522-pull-symlink.sh
@@ -46,7 +46,7 @@ test_expect_success SYMLINKS 'pulling from real subdir' '
 # Instead, the error pull gave was:
 #
 #   fatal: 'origin': unable to chdir or not a git archive
-#   fatal: The remote end hung up unexpectedly
+#   fatal: The remote end hung up
 #
 # because git would find the .git/config for the "trash directory"
 # repo, not for the clone-repo repo.  The "trash directory" repo

  parent reply	other threads:[~2012-06-11 16:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-10 18:23 [PATCH] lessen the impression of unexpectedness on remote hangup Heiko Voigt
2012-06-10 18:44 ` Jonathan Nieder
2012-06-11 16:41 ` Junio C Hamano [this message]
2012-06-11 19:02 ` Jeff King
2012-06-13 21:28   ` Heiko Voigt
2012-06-14  7:13   ` [PATCH] remove the impression of unexpectedness when access is denied Heiko Voigt
2012-06-14  7:39     ` Heiko Voigt
2012-06-14 17:11     ` Junio C Hamano
2012-06-14 20:37       ` Heiko Voigt
2012-06-19 18:24         ` [PATCH v2] " Heiko Voigt
2013-05-04  3:10           ` Jonathan Nieder
2013-05-06 14:02             ` Junio C Hamano
2013-05-07 18:39               ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vmx497qd5.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hvoigt@hvoigt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).