From: Jeff King <peff@peff.net>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] lessen the impression of unexpectedness on remote hangup
Date: Mon, 11 Jun 2012 15:02:07 -0400 [thread overview]
Message-ID: <20120611190207.GA20889@sigill.intra.peff.net> (raw)
In-Reply-To: <20120610182310.GB2427@book.hvoigt.net>
On Sun, Jun 10, 2012 at 08:23:10PM +0200, Heiko Voigt wrote:
> If a server accessed through ssh is denying access git will currently
> issue the message
>
> "fatal: The remote end hung up unexpectedly"
>
> as the last line. This sounds as if something really ugly just happened.
> Since this is a quite typical situation in which users regularly get
> lets just say:
>
> "fatal: The remote end hung up"
>
> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> ---
> We just got this bug report in msysgit
>
> https://github.com/msysgit/msysgit/issues/28
>
> and IIRC there have been more people questioning that line.
This does not seem like it would lessen the surprise all that much. I
wonder if we could use some context about where we are in the protocol
to tell more. For example, if the remote end hangs up before advertising
its refs, it is probably an authentication error or a missing
repository. And we should say that. If it happens during ref negotiation
or during the pack file, then it really is unexpected; the other end has
broken protocol, and it probably makes sense to say so.
-Peff
next prev parent reply other threads:[~2012-06-11 19:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-10 18:23 [PATCH] lessen the impression of unexpectedness on remote hangup Heiko Voigt
2012-06-10 18:44 ` Jonathan Nieder
2012-06-11 16:41 ` Junio C Hamano
2012-06-11 19:02 ` Jeff King [this message]
2012-06-13 21:28 ` Heiko Voigt
2012-06-14 7:13 ` [PATCH] remove the impression of unexpectedness when access is denied Heiko Voigt
2012-06-14 7:39 ` Heiko Voigt
2012-06-14 17:11 ` Junio C Hamano
2012-06-14 20:37 ` Heiko Voigt
2012-06-19 18:24 ` [PATCH v2] " Heiko Voigt
2013-05-04 3:10 ` Jonathan Nieder
2013-05-06 14:02 ` Junio C Hamano
2013-05-07 18:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611190207.GA20889@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).