From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Junio C Hamano <gitster@pobox.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t4014: shell portability fix
Date: Tue, 31 May 2016 23:44:13 -0400 [thread overview]
Message-ID: <20160601034413.GC5411@sigill.intra.peff.net> (raw)
In-Reply-To: <20160601033139.GB5411@sigill.intra.peff.net>
On Tue, May 31, 2016 at 11:31:40PM -0400, Jeff King wrote:
> I wondered if we could implement our own "env" in the shell, but it's a
> little non-trivial, because:
> [...]
> Here's what I came up with, which does seem to work. It's pretty gnarly,
> though.
Here's a revised version that drops the shellquoting by using extra
layers of "eval" indirection. You may have heard of 3-star C
programmers. I think I just became a 2-dollar shell programmer.
So this is gross, but I think it actually _is_ portable, with the
exception of the "is it exported" check.
-- >8 --
# is there a simpler way, even when the contents are "unset"?
is_unset () {
eval "test -z \"\${$1}\" && test unset = \"\${$1-unset}\""
}
# probably not portable; also, possible without sub-program?
is_exported () {
export -p | grep "^declare -x $1="
}
# set var named by $1 to contents of $2
set_var () {
eval "$1=\$2"
}
# set var named by $1 to contents of var named by $2
copy_var () {
eval "set_var \$1 \"\$$2\""
}
# just a syntactic convenience
add_to () {
eval "$1=\"\$$1
\$2\""
}
fake_env () {
fake_env_restore_=
while test $# -gt 0
do
case "$1" in
*=*)
# this whole thing is not safe when the var name has
# spaces or other meta-characters, but since the names
# all come from our test scripts, that should be OK
fake_env_var_=${1%%=*}
fake_env_orig_=fake_env_orig_$fake_env_var_
copy_var $fake_env_orig_ $fake_env_var_
fake_env_val_=${1#*=}
shift
# unset value and clear export flag...
add_to fake_env_restore_ "unset $fake_env_var_"
# ...and then restore what was there, if anything
if ! is_unset "$fake_env_var_"
then
add_to fake_env_restore_ \
"copy_var $fake_env_var_ $fake_env_orig_"
if is_exported "$fake_env_var_"
then
add_to fake_env_restore_ \
"export $fake_env_var_"
fi
fi
# and then clean up our temp variable
add_to fake_env_restore_ "unset $fake_env_orig_"
set_var $fake_env_var_ "$fake_env_val_"
eval "export $fake_env_var_"
;;
*)
"$@"
fake_env_ret_=$?
eval "$fake_env_restore_"
return $fake_env_ret_
;;
esac
done
}
# simple exercise
foo() {
echo >&2 "$1: bar=$bar"
}
bar="horrible \"\\' mess"
foo before
fake_env bar="temporary $bar" foo during
foo after
next prev parent reply other threads:[~2016-06-01 3:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 22:53 [PATCH] t4014: shell portability fix Junio C Hamano
2016-05-31 22:56 ` Jeff King
2016-06-01 0:09 ` Eric Sunshine
2016-06-01 2:31 ` Jeff King
2016-06-01 3:31 ` Jeff King
2016-06-01 3:44 ` Jeff King [this message]
2016-06-01 3:54 ` Jeff King
2016-06-01 5:33 ` Jeff King
2016-06-01 5:40 ` Jeff King
2016-06-01 6:49 ` Junio C Hamano
2016-06-01 6:57 ` Junio C Hamano
2016-06-01 7:04 ` Jeff King
2016-06-01 15:07 ` Junio C Hamano
2016-06-01 16:07 ` Jeff King
2016-06-01 16:57 ` Junio C Hamano
2016-06-01 16:58 ` Jeff King
2016-06-01 5:48 ` Johannes Sixt
2016-06-01 5:48 ` Jeff King
2016-06-01 6:39 ` Eric Sunshine
2016-06-01 0:09 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601034413.GC5411@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).