From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Eric Sunshine <sunshine@sunshineco.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t4014: shell portability fix
Date: Tue, 31 May 2016 23:49:10 -0700 [thread overview]
Message-ID: <xmqqshwx1k0p.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160601054048.GB20797@sigill.intra.peff.net> (Jeff King's message of "Wed, 1 Jun 2016 01:40:48 -0400")
Jeff King <peff@peff.net> writes:
> OK, last email tonight, I promise.
>
> Here's the subshell version. I'm a little embarrassed not to have
> thought of it sooner (though the other one was a fun exercise).
>
> test_env () {
> (
> while test $# -gt 0
> do
> case "$1" in
> *=*)
> eval "${1%%=*}=\${1#*=}"
Is this an elaborate way to say 'eval "$1"', or is there anything
more subtle going on?
> eval "export ${1%%=*}"
> shift
> ;;
> *)
> "$@"
> exit
... or 'exec "$@"'
> ;;
> esac
> done
> )
> }
You can dedent the whole thing and remove the outermost {} pair.
Other than that, looks good to me.
>
> -Peff
next prev parent reply other threads:[~2016-06-01 6:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 22:53 [PATCH] t4014: shell portability fix Junio C Hamano
2016-05-31 22:56 ` Jeff King
2016-06-01 0:09 ` Eric Sunshine
2016-06-01 2:31 ` Jeff King
2016-06-01 3:31 ` Jeff King
2016-06-01 3:44 ` Jeff King
2016-06-01 3:54 ` Jeff King
2016-06-01 5:33 ` Jeff King
2016-06-01 5:40 ` Jeff King
2016-06-01 6:49 ` Junio C Hamano [this message]
2016-06-01 6:57 ` Junio C Hamano
2016-06-01 7:04 ` Jeff King
2016-06-01 15:07 ` Junio C Hamano
2016-06-01 16:07 ` Jeff King
2016-06-01 16:57 ` Junio C Hamano
2016-06-01 16:58 ` Jeff King
2016-06-01 5:48 ` Johannes Sixt
2016-06-01 5:48 ` Jeff King
2016-06-01 6:39 ` Eric Sunshine
2016-06-01 0:09 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqshwx1k0p.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).