[PATCH] mw-to-git/t9360: fix broken &&-chain

[PATCH] mw-to-git/t9360: fix broken &&-chain

[Eric Sunshine]

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---

Jonathan's discovery[1] of a broken &&-chain in a contrib/subtree test
prompted me to check other tests bundled in contrib/. This was the
only other problem found. Unlike the subtree &&-chain case, this
breakage is at the top-level, thus was caught by the normal
--chain-lint mechanism, not the subshell linter.

[1]: https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google.
com/

 contrib/mw-to-git/t/t9360-mw-to-git-clone.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
index 22f069db48..cfbfe7ddf6 100755
--- a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
+++ b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
@@ -247,7 +247,7 @@ test_expect_success 'Test of resistance to modification of category on wiki for
 	wiki_editpage Notconsidered "this page will not appear on local" false &&
 	wiki_editpage Othercategory "this page will not appear on local" false -c=Cattwo &&
 	wiki_editpage Tobeedited "this page have been modified" true -c=Catone &&
-	wiki_delete_page Tobedeleted
+	wiki_delete_page Tobedeleted &&
 	git clone -c remote.origin.categories="Catone" \
 		mediawiki::'"$WIKI_URL"' mw_dir_14 &&
 	wiki_getallpage ref_page_14 Catone &&
-- 
2.18.0.597.ga71716f1ad

Re: [PATCH] mw-to-git/t9360: fix broken &&-chain

[Jonathan Nieder]

(+cc: some folks interested in git-remote-mediawiki)
Hi,

Eric Sunshine wrote:

> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
> ---
> Jonathan's discovery[1] of a broken &&-chain in a contrib/subtree test
> prompted me to check other tests bundled in contrib/. This was the
> only other problem found. Unlike the subtree &&-chain case, this
> breakage is at the top-level, thus was caught by the normal
> --chain-lint mechanism, not the subshell linter.
>
> [1]: https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google.
> com/

A small detail from there would be useful to have in the commit
message: namely that this was detected using --chain-lint (and what
command I can run to reproduce it myself).

With or without such a tweak to the commit message,

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

>  contrib/mw-to-git/t/t9360-mw-to-git-clone.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
> index 22f069db48..cfbfe7ddf6 100755
> --- a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
> +++ b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
> @@ -247,7 +247,7 @@ test_expect_success 'Test of resistance to modification of category on wiki for
>  	wiki_editpage Notconsidered "this page will not appear on local" false &&
>  	wiki_editpage Othercategory "this page will not appear on local" false -c=Cattwo &&
>  	wiki_editpage Tobeedited "this page have been modified" true -c=Catone &&
> -	wiki_delete_page Tobedeleted
> +	wiki_delete_page Tobedeleted &&
>  	git clone -c remote.origin.categories="Catone" \
>  		mediawiki::'"$WIKI_URL"' mw_dir_14 &&
>  	wiki_getallpage ref_page_14 Catone &&
> -- 
> 2.18.0.597.ga71716f1ad
> 

Re: [PATCH] mw-to-git/t9360: fix broken &&-chain

[Matthieu Moy]

"jrnieder" <jrnieder@gmail.com> wrote:

> (+cc: some folks interested in git-remote-mediawiki)

Thanks.

In case it still matters, an obvious Acked-by: Matthieu Moy <git@matthieu-moy.fr>

-- 
Matthieu Moy

Re: [PATCH] mw-to-git/t9360: fix broken &&-chain

[Antoine Beaupré]

On 2018-08-08 18:10:22, Matthieu Moy wrote:
> "jrnieder" <jrnieder@gmail.com> wrote:
>
>> (+cc: some folks interested in git-remote-mediawiki)
>
> Thanks.
>
> In case it still matters, an obvious Acked-by: Matthieu Moy <git@matthieu-moy.fr>

Hi,

I seem to have lost context of the original email, and can't find a copy
on public-inbox.org... Is there a patch we should merge back into
git-mediawiki already?

Thanks!

A.

-- 
Your injured body has become the burden of your digital soul.
                        - Yin Aiwen, 2013, The Massage is the Medium

Re: [PATCH] mw-to-git/t9360: fix broken &&-chain

[Eric Sunshine]

On Tue, Aug 21, 2018 at 2:55 PM Antoine Beaupré <anarcat@debian.org> wrote:
> On 2018-08-08 18:10:22, Matthieu Moy wrote:
> > "jrnieder" <jrnieder@gmail.com> wrote:
> >> (+cc: some folks interested in git-remote-mediawiki)
> >
> > In case it still matters, an obvious Acked-by: Matthieu Moy <git@matthieu-moy.fr>
>
> I seem to have lost context of the original email, and can't find a copy
> on public-inbox.org... Is there a patch we should merge back into
> git-mediawiki already?

The patch is here[1].

[1]: https://public-inbox.org/git/20180730204646.32312-1-sunshine@sunshineco.com/

Re: [PATCH] mw-to-git/t9360: fix broken &&-chain

[Antoine Beaupré]

On 2018-08-21 15:22:43, Eric Sunshine wrote:
> On Tue, Aug 21, 2018 at 2:55 PM Antoine Beaupré <anarcat@debian.org> wrote:
>> On 2018-08-08 18:10:22, Matthieu Moy wrote:
>> > "jrnieder" <jrnieder@gmail.com> wrote:
>> >> (+cc: some folks interested in git-remote-mediawiki)
>> >
>> > In case it still matters, an obvious Acked-by: Matthieu Moy <git@matthieu-moy.fr>
>>
>> I seem to have lost context of the original email, and can't find a copy
>> on public-inbox.org... Is there a patch we should merge back into
>> git-mediawiki already?
>
> The patch is here[1].
>
> [1]: https://public-inbox.org/git/20180730204646.32312-1-sunshine@sunshineco.com/

Thanks, so

Acked-by: Antoine Beaupré <anarcat@debian.org>

FWIW. :)

A.

-- 
The history of any one part of the earth, like the life of a soldier,
consists of long periods of boredom and short periods of terror.
                       - British geologist Derek V. Ager