* [PATCH] mw-to-git/t9360: fix broken &&-chain
[not found] <https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google.com/>
@ 2018-07-30 20:46 ` Eric Sunshine
2018-07-30 21:04 ` Jonathan Nieder
[not found] ` <9a96cf8f5254446fa244e4107cef4f3c@BPMBX2013-01.univ-lyon1.fr>
0 siblings, 2 replies; 6+ messages in thread
From: Eric Sunshine @ 2018-07-30 20:46 UTC (permalink / raw)
To: git; +Cc: Jonathan Nieder, Eric Sunshine
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---
Jonathan's discovery[1] of a broken &&-chain in a contrib/subtree test
prompted me to check other tests bundled in contrib/. This was the
only other problem found. Unlike the subtree &&-chain case, this
breakage is at the top-level, thus was caught by the normal
--chain-lint mechanism, not the subshell linter.
[1]: https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google.
com/
contrib/mw-to-git/t/t9360-mw-to-git-clone.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
index 22f069db48..cfbfe7ddf6 100755
--- a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
+++ b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
@@ -247,7 +247,7 @@ test_expect_success 'Test of resistance to modification of category on wiki for
wiki_editpage Notconsidered "this page will not appear on local" false &&
wiki_editpage Othercategory "this page will not appear on local" false -c=Cattwo &&
wiki_editpage Tobeedited "this page have been modified" true -c=Catone &&
- wiki_delete_page Tobedeleted
+ wiki_delete_page Tobedeleted &&
git clone -c remote.origin.categories="Catone" \
mediawiki::'"$WIKI_URL"' mw_dir_14 &&
wiki_getallpage ref_page_14 Catone &&
--
2.18.0.597.ga71716f1ad
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mw-to-git/t9360: fix broken &&-chain
2018-07-30 20:46 ` [PATCH] mw-to-git/t9360: fix broken &&-chain Eric Sunshine
@ 2018-07-30 21:04 ` Jonathan Nieder
[not found] ` <9a96cf8f5254446fa244e4107cef4f3c@BPMBX2013-01.univ-lyon1.fr>
1 sibling, 0 replies; 6+ messages in thread
From: Jonathan Nieder @ 2018-07-30 21:04 UTC (permalink / raw)
To: Eric Sunshine; +Cc: git, Antoine Beaupré, Matthieu Moy
(+cc: some folks interested in git-remote-mediawiki)
Hi,
Eric Sunshine wrote:
> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
> ---
> Jonathan's discovery[1] of a broken &&-chain in a contrib/subtree test
> prompted me to check other tests bundled in contrib/. This was the
> only other problem found. Unlike the subtree &&-chain case, this
> breakage is at the top-level, thus was caught by the normal
> --chain-lint mechanism, not the subshell linter.
>
> [1]: https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google.
> com/
A small detail from there would be useful to have in the commit
message: namely that this was detected using --chain-lint (and what
command I can run to reproduce it myself).
With or without such a tweak to the commit message,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
> contrib/mw-to-git/t/t9360-mw-to-git-clone.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
> index 22f069db48..cfbfe7ddf6 100755
> --- a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
> +++ b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
> @@ -247,7 +247,7 @@ test_expect_success 'Test of resistance to modification of category on wiki for
> wiki_editpage Notconsidered "this page will not appear on local" false &&
> wiki_editpage Othercategory "this page will not appear on local" false -c=Cattwo &&
> wiki_editpage Tobeedited "this page have been modified" true -c=Catone &&
> - wiki_delete_page Tobedeleted
> + wiki_delete_page Tobedeleted &&
> git clone -c remote.origin.categories="Catone" \
> mediawiki::'"$WIKI_URL"' mw_dir_14 &&
> wiki_getallpage ref_page_14 Catone &&
> --
> 2.18.0.597.ga71716f1ad
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mw-to-git/t9360: fix broken &&-chain
[not found] ` <9a96cf8f5254446fa244e4107cef4f3c@BPMBX2013-01.univ-lyon1.fr>
@ 2018-08-08 16:10 ` Matthieu Moy
2018-08-21 18:55 ` Antoine Beaupré
0 siblings, 1 reply; 6+ messages in thread
From: Matthieu Moy @ 2018-08-08 16:10 UTC (permalink / raw)
To: jrnieder; +Cc: Eric Sunshine, git, Antoine Beaupré, Matthieu Moy
"jrnieder" <jrnieder@gmail.com> wrote:
> (+cc: some folks interested in git-remote-mediawiki)
Thanks.
In case it still matters, an obvious Acked-by: Matthieu Moy <git@matthieu-moy.fr>
--
Matthieu Moy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mw-to-git/t9360: fix broken &&-chain
2018-08-08 16:10 ` Matthieu Moy
@ 2018-08-21 18:55 ` Antoine Beaupré
2018-08-21 19:22 ` Eric Sunshine
0 siblings, 1 reply; 6+ messages in thread
From: Antoine Beaupré @ 2018-08-21 18:55 UTC (permalink / raw)
To: Matthieu Moy, jrnieder; +Cc: Eric Sunshine, git, Matthieu Moy
On 2018-08-08 18:10:22, Matthieu Moy wrote:
> "jrnieder" <jrnieder@gmail.com> wrote:
>
>> (+cc: some folks interested in git-remote-mediawiki)
>
> Thanks.
>
> In case it still matters, an obvious Acked-by: Matthieu Moy <git@matthieu-moy.fr>
Hi,
I seem to have lost context of the original email, and can't find a copy
on public-inbox.org... Is there a patch we should merge back into
git-mediawiki already?
Thanks!
A.
--
Your injured body has become the burden of your digital soul.
- Yin Aiwen, 2013, The Massage is the Medium
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mw-to-git/t9360: fix broken &&-chain
2018-08-21 18:55 ` Antoine Beaupré
@ 2018-08-21 19:22 ` Eric Sunshine
2018-08-21 19:29 ` Antoine Beaupré
0 siblings, 1 reply; 6+ messages in thread
From: Eric Sunshine @ 2018-08-21 19:22 UTC (permalink / raw)
To: Antoine Beaupré
Cc: Matthieu Moy, Jonathan Nieder, Git List, Matthieu Moy
On Tue, Aug 21, 2018 at 2:55 PM Antoine Beaupré <anarcat@debian.org> wrote:
> On 2018-08-08 18:10:22, Matthieu Moy wrote:
> > "jrnieder" <jrnieder@gmail.com> wrote:
> >> (+cc: some folks interested in git-remote-mediawiki)
> >
> > In case it still matters, an obvious Acked-by: Matthieu Moy <git@matthieu-moy.fr>
>
> I seem to have lost context of the original email, and can't find a copy
> on public-inbox.org... Is there a patch we should merge back into
> git-mediawiki already?
The patch is here[1].
[1]: https://public-inbox.org/git/20180730204646.32312-1-sunshine@sunshineco.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mw-to-git/t9360: fix broken &&-chain
2018-08-21 19:22 ` Eric Sunshine
@ 2018-08-21 19:29 ` Antoine Beaupré
0 siblings, 0 replies; 6+ messages in thread
From: Antoine Beaupré @ 2018-08-21 19:29 UTC (permalink / raw)
To: Eric Sunshine; +Cc: Matthieu Moy, Jonathan Nieder, Git List, Matthieu Moy
On 2018-08-21 15:22:43, Eric Sunshine wrote:
> On Tue, Aug 21, 2018 at 2:55 PM Antoine Beaupré <anarcat@debian.org> wrote:
>> On 2018-08-08 18:10:22, Matthieu Moy wrote:
>> > "jrnieder" <jrnieder@gmail.com> wrote:
>> >> (+cc: some folks interested in git-remote-mediawiki)
>> >
>> > In case it still matters, an obvious Acked-by: Matthieu Moy <git@matthieu-moy.fr>
>>
>> I seem to have lost context of the original email, and can't find a copy
>> on public-inbox.org... Is there a patch we should merge back into
>> git-mediawiki already?
>
> The patch is here[1].
>
> [1]: https://public-inbox.org/git/20180730204646.32312-1-sunshine@sunshineco.com/
Thanks, so
Acked-by: Antoine Beaupré <anarcat@debian.org>
FWIW. :)
A.
--
The history of any one part of the earth, like the life of a soldier,
consists of long periods of boredom and short periods of terror.
- British geologist Derek V. Ager
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-21 19:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google.com/>
2018-07-30 20:46 ` [PATCH] mw-to-git/t9360: fix broken &&-chain Eric Sunshine
2018-07-30 21:04 ` Jonathan Nieder
[not found] ` <9a96cf8f5254446fa244e4107cef4f3c@BPMBX2013-01.univ-lyon1.fr>
2018-08-08 16:10 ` Matthieu Moy
2018-08-21 18:55 ` Antoine Beaupré
2018-08-21 19:22 ` Eric Sunshine
2018-08-21 19:29 ` Antoine Beaupré
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).