From: Danh Doan <congdanhqx@gmail.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v2] submodule: teach set-url subcommand
Date: Tue, 29 Oct 2019 16:15:38 +0700 [thread overview]
Message-ID: <20191029091538.GB17223@danh.dev> (raw)
In-Reply-To: <d8841c6009c91ac921d30b35ed9a441c87b332e2.1572337964.git.liu.denton@gmail.com>
On 2019-10-29 01:34:19 -0700, Denton Liu wrote:
> diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
> index 1f46380af2..f1c4689f24 100644
> --- a/Documentation/git-submodule.txt
> +++ b/Documentation/git-submodule.txt
> @@ -16,6 +16,7 @@ SYNOPSIS
> 'git submodule' [--quiet] deinit [-f|--force] (--all|[--] <path>...)
> 'git submodule' [--quiet] update [<options>] [--] [<path>...]
> 'git submodule' [--quiet] set-branch [<options>] [--] <path>
> +'git submodule' [--quiet] set-url [<options>] [--] <path> <newurl>
I skimmed over this patch and found no options.
[<options>] should be removed
> @@ -180,6 +181,11 @@ set-branch (-d|--default) [--] <path>::
> `--default` option removes the submodule.<name>.branch configuration
> key, which causes the tracking branch to default to 'master'.
>
> +set-url [--] <path> <newurl>::
> + Sets the URL of the specified submodule to <newurl>. Then, it will
> + automatically synchronize the submodule's new remote URL
> + configuration.
> +
> summary [--cached|--files] [(-n|--summary-limit) <n>] [commit] [--] [<path>...]::
> Show commit summary between the given commit (defaults to HEAD) and
> working tree/index. For a submodule in question, a series of commits
> diff --git a/git-submodule.sh b/git-submodule.sh
> index c7f58c5756..f7374ddbd6 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -12,6 +12,7 @@ USAGE="[--quiet] [--cached]
> or: $dashless [--quiet] deinit [-f|--force] (--all| [--] <path>...)
> or: $dashless [--quiet] update [--init] [--remote] [-N|--no-fetch] [-f|--force] [--checkout|--merge|--rebase] [--[no-]recommend-shallow] [--reference <repository>] [--recursive] [--] [<path>...]
> or: $dashless [--quiet] set-branch (--default|--branch <branch>) [--] <path>
> + or: $dashless [--quiet] set-url [--] <path> <newurl>
> or: $dashless [--quiet] summary [--cached|--files] [--summary-limit <n>] [commit] [--] [<path>...]
> or: $dashless [--quiet] foreach [--recursive] <command>
> or: $dashless [--quiet] sync [--recursive] [--] [<path>...]
> diff --git a/t/t7420-submodule-set-url.sh b/t/t7420-submodule-set-url.sh
> new file mode 100755
> index 0000000000..9bc941ced3
> --- /dev/null
> +++ b/t/t7420-submodule-set-url.sh
> + grep "url = \.\./newsubmodule" .gitmodules &&
grep -F "url = ../newsubmodule"
will be easier to read.
--
Danh
next prev parent reply other threads:[~2019-10-29 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 20:03 [PATCH] submodule: teach set-url subcommand Denton Liu
2019-10-29 8:34 ` [PATCH v2] " Denton Liu
2019-10-29 9:15 ` Danh Doan [this message]
2019-10-29 17:01 ` [PATCH v3] " Denton Liu
2019-10-30 5:54 ` Junio C Hamano
2019-10-30 17:58 ` Denton Liu
2019-11-02 4:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029091538.GB17223@danh.dev \
--to=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).