From: Chuck Lever <cel@citi.umich.edu>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Carl Baldwin <cnb@fc.hp.com>, "H. Peter Anvin" <hpa@zytor.com>,
Git Mailing List <git@vger.kernel.org>,
Catalin Marinas <catalin.marinas@gmail.com>
Subject: Re: auto-packing on kernel.org? please?
Date: Tue, 22 Nov 2005 13:18:53 -0500 [thread overview]
Message-ID: <4383610D.7080100@citi.umich.edu> (raw)
In-Reply-To: <Pine.LNX.4.64.0511212134330.13959@g5.osdl.org>
[-- Attachment #1: Type: text/plain, Size: 2357 bytes --]
Linus Torvalds wrote:
>
> On Tue, 22 Nov 2005, Chuck Lever wrote:
>
>>there are some things repacking does that breaks StGIT, though.
>>
>>git repack -d
>>
>>seems to remove old commits that StGIT was still depending on.
>
>
> If that is true, then "git-fsck-cache" probably also reports errors on a
> StGIT repository. No? Basically, it implies that the tool doesn't know how
> to find all the "heads".
indeed. this is one area where StGIT is "not safe" to use with other
porcelains. these raw GIT commands can show a bunch of confusing
"dangling references" type errors, or actually modify the index in ways
that eliminate StGIT-related commits that aren't currently attached to
any ancestry. (i think Catalin mentioned these are related to the
unapplied patches in a stack, but there could be others; see below).
> The preferred way would be to just list the references somewhere under
> .git/refs/stgit, in which case fsck and repack should pick them up
> automatically (so clearly stgit doesn't do that right now ;).
that could be an extremely large number of commits on a large repository
with a lot of patches that have been worked on over a long period. so
whatever mechanism is created to do this needs to scale well in the
number of commits.
> It also implies that doing a "git prune" will do horribly bad things to a
> stgit repo, since it would remove all the objects that it thinks aren't
> reachable..
yup. been there, done that. lucky for me i have an excellent hourly
backup scheme.
>>git repack -a -n
>>
>>seems to work fine with StGIT,
>
>
> Well, it "works", but not "fine". Since it doesn't know about the stgit
> objects, it won't ever pack them.
ah!
> But maybe that's what stgit wants (since they are "temporary"), but it
> does mean that if you see a big advantage from packing, you might be
> losing some of it.
actually, those commits aren't all that "temporary". the
history/revision feature i'm working on would like to maintain all the
commits ever done to an StGIT patch.
the only time you can throw away such commits is when the patch is
deleted or when it is finally committed to the repository via "stg
commit". otherwise, keeping these commits in a pack would be quite a
good thing.
maybe the first thing to do is to get a basic understanding of an StGIT
commit's lifetime.
[-- Attachment #2: cel.vcf --]
[-- Type: text/x-vcard, Size: 439 bytes --]
begin:vcard
fn:Chuck Lever
n:Lever;Charles
org:Network Appliance, Incorporated;Linux NFS Client Development
adr:535 West William Street, Suite 3100;;Center for Information Technology Integration;Ann Arbor;MI;48103-4943;USA
email;internet:cel@citi.umich.edu
title:Member of Technical Staff
tel;work:+1 734 763-4415
tel;fax:+1 734 763 4434
tel;home:+1 734 668-1089
x-mozilla-html:FALSE
url:http://www.monkey.org/~cel/
version:2.1
end:vcard
next prev parent reply other threads:[~2005-11-22 18:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-13 18:44 auto-packing on kernel.org? please? Linus Torvalds
[not found] ` <434EABFD.5070604@zytor.com>
[not found] ` <434EC07C.30505@pobox.com>
2005-10-13 21:23 ` [kernel.org users] " Linus Torvalds
2005-10-16 14:33 ` Dirk Behme
2005-10-16 15:44 ` Daniel Barkalow
2005-10-16 16:12 ` Nick Hengeveld
2005-10-16 16:23 ` Brian Gerst
2005-10-16 16:56 ` Junio C Hamano
2005-10-16 21:33 ` Nick Hengeveld
2005-10-16 22:12 ` Junio C Hamano
2005-10-17 6:06 ` Nick Hengeveld
2005-10-17 8:21 ` Junio C Hamano
2005-10-17 17:41 ` Nick Hengeveld
2005-10-17 20:08 ` Junio C Hamano
2005-10-17 22:56 ` Daniel Barkalow
2005-10-17 23:19 ` Linus Torvalds
2005-10-17 23:54 ` Nick Hengeveld
2005-10-17 19:13 ` Daniel Barkalow
2005-10-16 17:10 ` Johannes Schindelin
2005-10-16 17:15 ` Brian Gerst
2005-11-21 19:01 ` Carl Baldwin
2005-11-21 19:24 ` Linus Torvalds
2005-11-21 19:58 ` Junio C Hamano
2005-11-21 20:38 ` Linus Torvalds
2005-11-21 21:35 ` Junio C Hamano
2005-11-22 5:26 ` Chuck Lever
2005-11-22 5:41 ` Linus Torvalds
2005-11-22 14:13 ` Catalin Marinas
2005-11-22 17:05 ` Linus Torvalds
[not found] ` <7v64qkfwhe.fsf@assigned-by-dhcp.cox.net>
[not found] ` <b0943d9e0511220946o3b62842ey@mail.gmail.com>
[not found] ` <7v1x18eddp.fsf@assigned-by-dhcp.cox.net>
2005-11-23 14:10 ` Catalin Marinas
2005-11-22 18:18 ` Chuck Lever [this message]
2005-11-23 14:18 ` Catalin Marinas
2005-11-22 17:25 ` Carl Baldwin
2005-11-22 17:58 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4383610D.7080100@citi.umich.edu \
--to=cel@citi.umich.edu \
--cc=catalin.marinas@gmail.com \
--cc=cnb@fc.hp.com \
--cc=git@vger.kernel.org \
--cc=hpa@zytor.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).