From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "Jonathan Nieder" <jrnieder@gmail.com>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Thomas Rast" <trast@student.ethz.ch>,
"Scott Bronson" <bronson@rinspin.com>,
"Nathan Broadbent" <nathan.f77@gmail.com>
Subject: Re: [RFC/PATCH v4 5/6] completion: calculate argument position properly
Date: Mon, 07 May 2012 14:52:27 -0700 [thread overview]
Message-ID: <7v8vh34q1w.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAMP44s3rC6bT3rjrBFdnywwsp5NrXt54L5L-7oKZ=bNFKccq+w@mail.gmail.com> (Felipe Contreras's message of "Mon, 7 May 2012 23:01:12 +0200")
Felipe Contreras <felipe.contreras@gmail.com> writes:
>> Together with 4/6, I am guessing that you are using $cmd and $cmd_pos
>> as a global variable to pass state to/from helper functions. Are they
>> properly documented in code (if not, please do so)?
>
> Like cur, prev, words, and cwords? Wait a second... they are not
> documented anywhere. I'm also not going to work on this... not my
> itch.
The usual thing to do is to clean up after other people's mess while you
are mucking with the vicinity of them anyway, especially if you are making
things worse by adding another.
And I am fully aware that it may not be your itch---otherwise I wouldn't
have asked. I would have said "This needs to be fixed (or else)".
Why is it that everybody on the list, who is working together well in the
community, seems to have trouble only when interacting with you? Please
remember that it is not my itch to live with an unnecessarily abrasive
behaviour from you, either.
next prev parent reply other threads:[~2012-05-07 21:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 1:23 [RFC/PATCH v4 0/6] completion: __git_complete and other stuff Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 1/6] completion: add new __git_complete helper Felipe Contreras
2012-05-07 9:51 ` SZEDER Gábor
2012-05-07 18:51 ` Junio C Hamano
2012-05-07 20:53 ` Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 2/6] tests: add more bash completion tests Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 3/6] completion: simplify _git_bundle Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 4/6] completion: simplify command stuff Felipe Contreras
2012-05-07 10:08 ` SZEDER Gábor
2012-05-07 1:23 ` [RFC/PATCH v4 5/6] completion: calculate argument position properly Felipe Contreras
2012-05-07 1:27 ` Felipe Contreras
2012-05-07 18:59 ` Junio C Hamano
2012-05-07 21:01 ` Felipe Contreras
2012-05-07 21:52 ` Junio C Hamano [this message]
2012-05-08 12:50 ` Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 6/6] completion: add public _GIT_complete helper Felipe Contreras
2012-05-07 18:56 ` Junio C Hamano
2012-05-07 20:57 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v8vh34q1w.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=bronson@rinspin.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=nathan.f77@gmail.com \
--cc=szeder@ira.uka.de \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).