From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Jonathan Nieder" <jrnieder@gmail.com>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Thomas Rast" <trast@student.ethz.ch>
Subject: Re: [RFC/PATCH v4 1/6] completion: add new __git_complete helper
Date: Mon, 7 May 2012 22:53:40 +0200 [thread overview]
Message-ID: <CAMP44s15BbH2-kVQCO9s9ZEQLDTLcNRUw=4XiTmHoABa06kwUQ@mail.gmail.com> (raw)
In-Reply-To: <7vfwbb6czu.fsf@alter.siamese.dyndns.org>
On Mon, May 7, 2012 at 8:51 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>
>> +# this is NOT a public function; use at your own risk
>> +__git_complete ()
>
> The comment is enough to scare away people who might use it and then come
> back to complain when this changes its implementation detail, but saying
> "This is not X" without saying "This does Y" does not help those who want
> to contribute updates to git-completion script. Is there a short and
> sweet description of what this is for and/or what this does?
No. And this patch is not meant to help those people; I don't even
need this, it's not my itch, I just did it because other people
complained. Those people would have to scratch their own itch if they
want some description of __git_complete (), I only want to reorganize
the code and already did more than my fair share.
--
Felipe Contreras
next prev parent reply other threads:[~2012-05-07 20:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 1:23 [RFC/PATCH v4 0/6] completion: __git_complete and other stuff Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 1/6] completion: add new __git_complete helper Felipe Contreras
2012-05-07 9:51 ` SZEDER Gábor
2012-05-07 18:51 ` Junio C Hamano
2012-05-07 20:53 ` Felipe Contreras [this message]
2012-05-07 1:23 ` [RFC/PATCH v4 2/6] tests: add more bash completion tests Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 3/6] completion: simplify _git_bundle Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 4/6] completion: simplify command stuff Felipe Contreras
2012-05-07 10:08 ` SZEDER Gábor
2012-05-07 1:23 ` [RFC/PATCH v4 5/6] completion: calculate argument position properly Felipe Contreras
2012-05-07 1:27 ` Felipe Contreras
2012-05-07 18:59 ` Junio C Hamano
2012-05-07 21:01 ` Felipe Contreras
2012-05-07 21:52 ` Junio C Hamano
2012-05-08 12:50 ` Felipe Contreras
2012-05-07 1:23 ` [RFC/PATCH v4 6/6] completion: add public _GIT_complete helper Felipe Contreras
2012-05-07 18:56 ` Junio C Hamano
2012-05-07 20:57 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s15BbH2-kVQCO9s9ZEQLDTLcNRUw=4XiTmHoABa06kwUQ@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=szeder@ira.uka.de \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).