Re: [RFC/PATCH v4 5/6] completion: calculate argument position properly

From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Jonathan Nieder" <jrnieder@gmail.com>,
	"SZEDER Gábor" <szeder@ira.uka.de>,
	"Thomas Rast" <trast@student.ethz.ch>,
	"Scott Bronson" <bronson@rinspin.com>,
	"Nathan Broadbent" <nathan.f77@gmail.com>
Subject: Re: [RFC/PATCH v4 5/6] completion: calculate argument position properly
Date: Tue, 8 May 2012 14:50:30 +0200	[thread overview]
Message-ID: <CAMP44s187xd-78SUBVnc5qrgqi+n5ft1cASM4qAgMguApF+0Wg@mail.gmail.com> (raw)
In-Reply-To: <7v8vh34q1w.fsf@alter.siamese.dyndns.org>

On Mon, May 7, 2012 at 11:52 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>>> Together with 4/6, I am guessing that you are using $cmd and $cmd_pos
>>> as a global variable to pass state to/from helper functions. Are they
>>> properly documented in code (if not, please do so)?
>>
>> Like cur, prev, words, and cwords? Wait a second... they are not
>> documented anywhere. I'm also not going to work on this... not my
>> itch.
>
> The usual thing to do is to clean up after other people's mess while you
> are mucking with the vicinity of them anyway, especially if you are making
> things worse by adding another.

People have different ideas of what is a mess. You think it's a mess,
I don't. Why should I clean it up?

Of course, you as a maintainer have all the right to reject my patches
because they introduce more "mess", and if I want the patch in, I am
forced to do what you say, but it just so happens that I don't care if
this goes in or not, so I have the right to don't do anything; it's my
own free time.

> And I am fully aware that it may not be your itch---otherwise I wouldn't
> have asked.  I would have said "This needs to be fixed (or else)".
>
> Why is it that everybody on the list, who is working together well in the
> community, seems to have trouble only when interacting with you?  Please
> remember that it is not my itch to live with an unnecessarily abrasive
> behaviour from you, either.

Why am I being abrasive here? The only reason I sent these patches
was, as I said, to simplify the discussion about what would make
'alias gf' work, I did not, and I do not intent to propose these
patches for inclusion (as I know the pain (for me) that would entail).

If you would rather have me send no patches at all rather than to show
what I have (in fact I cleaned them quite a lot) and stop there, I can
do that; less work for me.

To be honest, I don't see what's the problem in sending partial stuff;
in a collaborative effort somebody else that actually has this itch
would pick these and finish the job; nothing wrong with that. Why
should it be me who finish the job? And why am I problematic if I
don't want to?

As I said, I only care about the first patch.

Cheers.

-- 
Felipe Contreras